sp-requesting-code-review

name	sp-requesting-code-review
description	Use when completing tasks, implementing major features, or before merging. Dispatches a code-reviewer session to catch issues before they cascade. Review early, review often.
tags	["code-review","communication","quality","workflow","verification"]
version	1.0.0
risk	safe
triggers	["request code review","get code reviewed","dispatch code reviewer","code review before merge","review my implementation","requesting code review","review this code"]
requirements	{"cli":["git"],"env":[]}
upstream_ref	skills/requesting-code-review/SKILL.md
author	AlphaComposite
license	MIT
dependencies	[]

Requesting Code Review

Dispatch a code-reviewer session to catch issues before they cascade.

Core principle: Review early, review often.

When to Request Review

Mandatory:

• After each task in subagent-driven development
• After completing a major feature
• Before merge to main

Optional but valuable:

• When stuck (fresh perspective)
• Before refactoring (baseline check)
• After fixing a complex bug

How to Request

1. Get git SHAs:

BASE_SHA=$(git rev-parse HEAD~1)  # or origin/main
HEAD_SHA=$(git rev-parse HEAD)

2. Spawn a code-reviewer session:

Use sessions_spawn (OpenClaw sub-agent) with the code-reviewer prompt template at code-reviewer.md.

Fill in these placeholders:

• {WHAT_WAS_IMPLEMENTED} — What you just built
• {PLAN_OR_REQUIREMENTS} — What it should do
• {BASE_SHA} — Starting commit
• {HEAD_SHA} — Ending commit
• {DESCRIPTION} — Brief summary

3. Act on feedback:

• Fix Critical issues immediately
• Fix Important issues before proceeding
• Note Minor issues for later
• Push back if reviewer is wrong (with technical reasoning)

Example

[Just completed Task 2: Add verification function]

Get SHAs:
  BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
  HEAD_SHA=$(git rev-parse HEAD)

Spawn code-reviewer session with:
  WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
  PLAN_OR_REQUIREMENTS: Task 2 from docs/plans/deployment-plan.md
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types

Reviewer returns:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

[Fix progress indicators]
[Continue to Task 3]

Integration with Workflows

Subagent-Driven Development:

• Review after EACH task
• Catch issues before they compound
• Fix before moving to the next task

Executing Plans:

• Review after each batch (3 tasks)
• Get feedback, apply, continue

Ad-Hoc Development:

• Review before merge
• Review when stuck

Red Flags

Never:

• Skip review because "it's simple"
• Ignore Critical issues
• Proceed with unfixed Important issues
• Argue with valid technical feedback

If reviewer is wrong:

• Push back with technical reasoning
• Show code/tests that prove it works
• Request clarification

See reviewer prompt template at: sp-requesting-code-review/code-reviewer.md