القائمة
Use when reviewing a Trovara code change — checks correctness, MVVM layering, security, performance, i18n parity, file-size limits, and test coverage like a senior engineer.
التثبيت باستخدام Codex أو Claude انسخ هذا Prompt والصقه في Codex أو Claude أو مساعد آخر ليراجع صفحة Skill ويثبّتها لك.
| name | code-review |
| description | Use when reviewing a Trovara code change — checks correctness, MVVM layering, security, performance, i18n parity, file-size limits, and test coverage like a senior engineer. |
| allowed-tools | Read, Grep, Glob, Bash |
| model | opus |
Senior-engineer review of Trovara diffs. Covers correctness, security, architecture, performance, and maintainability in that priority order.
git diff develop..HEAD --stat # files changed
git diff develop..HEAD --name-only # file list
git log develop..HEAD --oneline # commits
Load the area-specific CLAUDE.md for every changed directory before commenting.
Review in this order; stop and report blockers before continuing:
notifyListeners in loops, main-thread blockingViewModelProvider<T> — no direct service calls from build()BaseViewModel, inject services via constructor or ServiceLocator().<getter>INoteRepository), never ObjectBox* concretionsServiceLocator() calls inside a service constructordiff <(jq -r '[paths(scalars)|join(".")]|sort|.[]' assets/translations/en.json) \
<(jq -r '[paths(scalars)|join(".")]|sort|.[]' assets/translations/km.json)
Must be empty. Any new user-visible string needs a key in both files.
git diff develop..HEAD --name-only | grep '\.dart$' | grep -v '\.g\.dart$' | while read f; do
[ -f "$f" ] && wc -l < "$f" | xargs -I{} echo "{} $f"
done | awk '$1 > 250'
Soft limit 250, hard limit 300. Flag files approaching the limit.
String.fromEnvironment(...) from config_constants.dartlogger.d level)*.g.dart and objectbox-model.json not edited manually./scripts/build_runner.sh was runIcons.* — only LucideIcons.* from lucide_icons_flutterColors.* or raw hex — only Theme.of(context).colorScheme.*TextStyle(...) — only Theme.of(context).textTheme.*patrol_test/ testpatrol_test/)patrolTest wrapper from test_support.dart, not from package:patrol| Level | Examples |
|---|---|
| Blocker | API key exposure, MVVM violation, null crash, i18n missing |
| Major | N+1 query, untested public API, file over 300 LOC, DI leak |
| Minor | DRY violation, unclear naming, unused import |
| Nitpick | Trailing whitespace, lint warning |
For each finding:
[Level] Description
File:path/to/file.dart:line
Problem: what's wrong (cite CLAUDE.md rule if applicable)
Impact: why it matters
Fix: concrete recommendation
## Review Summary
### Blockers (must fix before merging)
- ...
### Major
- ...
### Minor / Nitpick
- ...
### ✅ Passes
- flutter analyze
- i18n parity
- file sizes
- MVVM layering
استنادا إلى تصنيف SOC المهني
Use when inserting a new i18n key into Trovara's locale files — adds the key to both en.json and km.json under the correct nested path and verifies parity.
Use when incrementing the Trovara app version before a release — updates the semver and build number in pubspec.yaml following the project's versioning convention.
Use when a developer needs orientation to the Trovara codebase — new team member, returning after a gap, or asking "how does X work", "where is Y", or "how do I add a new feature".
Use when a new service, repository, or subsystem needs documentation — CLAUDE.md for new directories, dartdoc for public APIs, or updating existing architecture docs after a structural change.
Use when adding a new screen, modifying existing feature behavior, or wiring new business logic end-to-end in Trovara — creates MVVM scaffold, route, ServiceLocator wiring, and i18n keys.
Use when adding a new persistable data entity to Trovara — scaffolds the ObjectBox model class, repository interface, ObjectBox implementation, and ServiceLocator wiring, then runs codegen.
