// General-purpose code review checklist. Use when reviewing any code change without a narrower specialization. Complements security-review, pr-review (multi-perspective), and the other review skills — pull this when you need the standard correctness/quality rubric without a specific angle.
| name | review |
| description | General-purpose code review checklist. Use when reviewing any code change without a narrower specialization. Complements security-review, pr-review (multi-perspective), and the other review skills — pull this when you need the standard correctness/quality rubric without a specific angle. |
| allowed-tools | ["Bash","Read","Glob","Grep"] |
A general-purpose review rubric for any code change. Use as the "correctness" specialist dimension of a multi-perspective review, or as a standalone checklist when reviewing a diff without a specialization.
Review ONLY the assigned diff. Cross-module concerns go to architecture; security-sensitive code goes to security-review.
See checklist.md for the full detailed checklist with all sub-items.
Findings table per finding:
| Severity | Location | Issue | Suggested fix | Confidence |
|---|---|---|---|---|
| MEDIUM | lionagi/operations/act.py:87 | Off-by-one in range(len(xs)) | Use enumerate(xs) | High |
Verdict line at top: APPROVE | APPROVE-WITH-FIXES | REQUEST CHANGES.
Cite file:line for every finding.
CRITICAL — will break production on mergeHIGH — correctness bug affecting real use casesMEDIUM — edge case bug, significant maintainability issueLOW — style, naming, minor refactorINFO — future consideration, not blockingSystematic debug workflow: research → orchestrate agents → escalate. Suggest when: stuck after 2-3 attempts, unfamiliar tooling, tempted to "try random things", or errors don't match documentation.
Plan and execute multi-agent workflows using lionagi's CLI: li o flow (DAG pipelines), li o fanout (parallel workers), and li play (playbook invocations). Use when a task needs multiple agents working in parallel or staged phases.
Author lionagi playbooks — reusable YAML workflow templates that define parametric agent tasks. Playbooks live at ~/.lionagi/playbooks/ and run via li play <name>. Use when: creating reusable workflows, parameterizing agent tasks, or setting up repeatable pipelines.
Multi-perspective PR review procedure. Plan a minimal DAG of specialists scoped to what the PR actually touches, synthesize with a critic, post ONE consolidated comment per verbosity tier. Pull before any structured PR review so the methodology stays consistent.
Threat-model rubric for a focused security review of a code change. Use when reviewing auth / input validation / crypto / secrets / supply chain, or as the "security" dimension of a multi-perspective PR review. Pull this skill before starting so severity calibration and coverage stay consistent.
Orchestrate multi-play shows: decompose a complex goal into sequential plays (each a li play invocation), gate each output for quality, adapt the plan based on results, and merge work into an integration branch. Shows are first-class entities in Lion Studio with dedicated UI at /shows.