reviewing-code

name	reviewing-code
description	Use when reviewing code changes, checking PRs, or evaluating code quality.
skills	["reviewing-code"]
agent-roles	["reviewer"]

Code Review

Quick Commands

# Run ALL checks at once (tests + linting)
bpsai-pair ci

# Validate project structure
bpsai-pair validate

# See what changed
git diff main...HEAD --stat
git diff main...HEAD

Review Output Format

## Code Review: [Description]

### Summary
Brief assessment.

### P0 (blocks merge -- breaking state, auto-reject)
1. **[File:Line]** - Issue and fix

### P1 (fix before merge -- quality issue, not breaking)
1. **[File:Line]** - Suggestion

### P2 (signal -- improvement opportunity, enters SigInt pipeline)
1. **[File:Line]** - Optional improvement

### Positive Notes
- What was done well

### Verdict
- [ ] Approve
- [ ] Approve with comments
- [ ] Request changes

Project-Specific Checks

• Type hints on public functions
• Docstrings on public interfaces
• No hardcoded values (use config)
• Tests for new functionality
• Mock external services (Trello, GitHub APIs)
• Follow existing patterns in codebase

Quick Checks

# Find debug statements
git diff main...HEAD | grep -E "print\(|breakpoint|pdb"

# Find TODOs in changes
git diff main...HEAD --name-only | xargs grep -n "TODO\|FIXME"

# Check for secrets
git diff main...HEAD | grep -iE "password|secret|api.?key|token"