git-commit

name	git-commit
description	Complete git commit workflow for PyPTO including pre-commit review, staging, message generation, and verification. Use when creating commits, preparing changes for commit, or when the user asks to commit changes.

PyPTO Git Commit Workflow

Task Tracking

Create tasks and check them off as you complete each step:

- [ ] Step 0: Code simplification decision
- [ ] Step 1: Analyze changes & launch review/test skills
- [ ] Step 2: Address issues, stage & commit
- [ ] Step 3: Post-commit verification

Step 0: Code Simplification Decision

Decide whether to run code simplification based on the nature of changes.

Check what changed:

git diff --name-only
git diff --cached --name-only

Skip code simplification when:

• Changes are docs/rules/skills only (.md, .rst, docs/, .claude/rules/, .claude/skills/)
• Changes are config only (.json, .yaml, .toml, .github/)
• Changes are purely mechanical (renaming, typo fixes, import reordering, moving code without logic changes)

Run code simplification for all other cases — any change involving logic, even small ones. If changes include any code files mixed with docs/config, run it.

User override: If the user explicitly requests or declines code simplification, honor their preference.

If running → Run code simplification on changed files, then proceed to Step 1.

If skipping → Briefly state why (e.g., "Skipping code simplification — docs-only changes"), then proceed to Step 1.

Step 1: Analyze Changes & Launch Review/Test Skills

Check what changed:

git diff --name-only
git diff --cached --name-only

Determine what to run based on changed files:

File Types Changed	Run Code Review	Run Testing	Run Clang-Tidy
C++ (.cpp, .h)	✅ Yes	✅ Yes	✅ Yes
Python (.py, bindings, tests)	✅ Yes	✅ Yes	❌ Skip
Build system (.cmake, CMakeLists.txt)	✅ Yes	✅ Yes	✅ Yes
Docs only (.md, .rst, docs/)	✅ Yes	❌ Skip	❌ Skip
Config only (.json, .yaml, .toml, .github/)	✅ Yes	❌ Skip	❌ Skip
Mixed (code + docs/config)	✅ Yes	✅ Yes	If C++ changed

Launch in parallel (each runs in its own forked context):

• code-review skill — ALWAYS run for all changes
• testing skill — ONLY run if code files changed
• clang-tidy via Bash: python tests/lint/clang_tidy.py --diff-base HEAD — ONLY if C++ changed

Wait for all to complete, then address any issues found.

Step 2: Stage Changes & Commit

Related changes together:

git add path/to/file1.cpp path/to/file2.h
git diff --staged  # Review

Cross-layer pattern (C++ + Python + Type stubs + Tests):

git add include/pypto/ir/expr.h python/bindings/ir_binding.cpp \
        python/pypto/pypto_core/__init__.pyi tests/ut/ir/test_expr.py

Never stage: Build artifacts (build/, *.o), temp files, IDE configs

Commit Message Format

Structure: type(scope): description (≤72 chars)

Types: feat, fix, refactor, test, docs, style, chore, perf Scope: Module/component (ir, printer, builder) Description: Present tense, action verb, no period

Good examples:

feat(ir): Add unique identifier field to MemRef
fix(printer): Update printer to use yield_ instead of yield
refactor(builder): Simplify tensor construction logic
test(ir): Add edge case coverage for structural comparison

Bad examples (avoid):

❌ feat(ir): Added feature.  # Past tense, has period
❌ Fix bug                   # Missing type prefix
❌ WIP                       # Not descriptive

Commit

# Short message
git commit -m "feat(ir): Add tensor rank validation"

# Detailed message (in editor)
git commit

In editor:

feat(ir): Add tensor rank validation

Validates tensor rank is positive before setting shape.
Raises ValueError for invalid ranks.
Updates tests with edge case coverage.

Co-Author Policy

❌ NEVER add AI assistants: No Claude, ChatGPT, Cursor AI, etc. ✅ Only credit human contributors: Co-authored-by: Name <email>

Why? AI tools are not collaborators. Commits reflect human authorship.

Step 3: Post-Commit Verification

git show HEAD              # View commit
git log -1                 # Check message
git show HEAD --name-only  # Verify files

Fix issues (only if not pushed):

git commit --amend -m "Corrected message"      # Fix message
git add file && git commit --amend --no-edit   # Add forgotten file

⚠️ Only amend unpushed commits!

Checklist

• Code simplification: ran (for logic changes) or skipped with reason (if docs/config/mechanical)
• Changed files analyzed (code vs docs/config only)
• Code review completed
• Tests passed (if code changed) or skipped (if docs/config only)
• Clang-tidy passed (if C++ changed) or skipped (if no C++)
• Only relevant files staged
• No build artifacts
• Message format: type(scope): description (≤72 chars, present tense, no period)
• No AI co-authors

Remember

A good commit is thoroughly reviewed, groups related changes, has clear "why" message, and attributes only human authors.