application-service-implementation

name	application-service-implementation
description	implement or revise traditional application service business logic in an existing service file. use when a c# application service class has incomplete or incorrect operation logic and chatgpt should update service methods, add private helper methods, and extend application or domain abstractions such as repositories, read services, or domain services if required, while avoiding direct infrastructure dependencies in the service.
template-id	Intent.Application.ServiceImplementations.ServiceImplementationSkillTemplate
contentHash	75AF7B2B952E00DCDA6C3F0EC7C7B423A678BACC4EBEDFD959EEF482369F71F3

Traditional Service Implementation

Implement business logic inside an existing traditional application service file. Keep service implementations aligned with the modeled domain, nearby service patterns, and application-layer boundaries.

Core rules

• Treat the existing service file as the starting point. Update the relevant service operation(s) rather than rewriting unrelated parts.
• NEVER modify the signature of an existing service operation unless the user explicitly asks for that change.
• ALWAYS if you modify a service operation body, ensure that the IntentManaged attribute indicates that the body of the method must be in Mode.Ignore (e.g. [IntentManaged(Mode.Fully, Body = Mode.Ignore)]).
• Inject only dependencies from the Domain or Application layers.
• Never introduce direct dependencies on infrastructure packages or infrastructure types in the service, including Entity Framework, Dapper, concrete DbContexts, SQL clients, or vendor-specific APIs.
• If data access is required, favor using an existing repository, read service, or domain/application abstraction, but extend them if required.
• ALWAYS if the response requires any aggregation (Count/Sum/Average/Min/Max/First/Last/GroupBy), the service MUST NOT compute it in memory. The service MUST call a Domain/Application abstraction that returns an aggregated result/summary/shaped dataset. If no suitable method exists, the assistant must extend the appropriate repository/read abstraction (contract first, then implementation) and then call it. No temporary in-service aggregation is allowed.
• Favor domain methods on aggregates/entities when they exist. If no such methods exist, follow the general implementation style already used by similar services in the solution.
• Follow the modeled domain language already present in the codebase: aggregates, entities, value objects, statuses, DTOs, projections, policies, filters, and business terms should drive the implementation.
• Search the codebase for similar services, repository methods, domain operations, mapping conventions, validation flows, error patterns, and save conventions before introducing a new approach.
• Add private helper methods inside the service when they improve readability, encapsulate repeated branching logic, or keep the main business flow clear.
• Keep orchestration in the service and place durable business rules in domain entities, value objects, specifications, or domain/application services when those patterns already exist nearby.

Workflow

1. Inspect the existing service class, interface, operation signatures, DTOs, repositories/read services/domain services, and related domain types.
2. Search for code usages of:

• similar traditional application services
• repository, read-service, or domain-service abstractions
• domain operations on the target aggregate or entity
• DTO mapping conventions
• validation, authorization, and error/result patterns
• save and unit-of-work conventions in nearby services

3. Infer the intended business flow from the operation names, parameters, return types, surrounding domain model, and nearby feature implementations.
4. Implement the service operation using existing patterns first.
5. If the service needs missing DAL capabilities, extend the relevant repository/read/application abstraction in an allowed layer instead of introducing infrastructure access into the service.
6. Add focused private helper methods when the flow becomes easier to read, reuse, or validate.
7. Ensure cancellation tokens are threaded through async calls where applicable.
8. Verify the final code preserves layer boundaries, follows surrounding service conventions, and avoids infrastructure leakage.

Service-specific guidance

Traditional services may combine command-style and query-style operations. Prefer patterns like these when supported by the surrounding codebase:

For state-changing operations

• load the aggregate or entity through a repository abstraction
• validate existence, eligibility, ownership, or other business preconditions
• invoke domain behavior rather than mutating state ad hoc when domain methods exist
• fall back to nearby established mutation style only when domain methods do not exist
• persist through the established repository/unit-of-work conventions
• return the established command/service result type used by the solution

For read operations

• retrieve through an existing repository or read abstraction
• apply business-relevant filters and visibility rules consistently with nearby services
• avoid over-fetching and avoid in-memory aggregation where an abstraction can shape the data more efficiently
• map to DTOs or response contracts using the existing mapping conventions
• keep read flows free of domain mutation or hidden write behavior

Repository and abstraction guidance

When a needed capability is missing:

• Extend the existing repository, read service, or domain/application abstraction closest to the business concept.
• Keep new methods shaped around domain or application intent, not storage mechanics.
• Prefer expressive names such as FindByIdAsync, GetDetailsAsync, ListByCriteriaAsync, ExistsBy...Async, SearchActive...Async, or GetSummaryAsync.
• Do not add infrastructure comments or instructions to the service.
• Do not reference EF includes, Dapper SQL, joins, transactions, or storage-specific tuning from the service.

Mapping guidance

• Reuse the existing DTO mapping approach already present in the solution, whether that is mapper-based, extension-method-based, projection-based, or another established convention.
• Keep mapping logic lightweight in the service.
• If mapping is repetitive or already centralized elsewhere, reuse the existing mapping helpers/extensions instead of inlining ad hoc conversions.
• For query-like operations, allow simple fetch-and-map flows in the service, but push complex shaping, filtering, or aggregation into abstractions where appropriate for performance and consistency.

Error and result guidance

• Follow the existing application error/result conventions already used in the solution.
• Reuse nearby patterns for not found, validation failures, business rule failures, and authorization failures.
• Do not invent a new exception or result style when the surrounding code already establishes one.

EF Related Data Loading guidance

• NEVER use Include or ThenInclude in the Application Layer, these are only available in the Infrastructure layer.
• Lazy loading with proxies is enabled.
• Entities are configured using the Owns apis, so compsitional children will be automatically loaded with their parents.
• You can rely on navigation properties being automatically loaded when accessed.
• (CRITICAL) If your implementation will cause a lot of Lazy loading consider other alternatives, like moving the data loading into the repository layer.

Unit of Work guidance

• SaveChanges rule (STRICT): Do not call UnitOfWork.SaveChangesAsync(...) / SaveChangesAsync(...) in a handler/service method unless the operation returns a payload that requires DB-generated values, such as a generated Id, surrogate key, RowVersion/concurrency token, DB-generated timestamp, or computed column.
• If the operation returns Unit, void, Task, or IRequest with no result: do not call SaveChangesAsync.
• If the operation returns an identifier or DTO that needs generated fields: call SaveChangesAsync before returning.
• If unsure, omit SaveChangesAsync and assume an outer unit-of-work/pipeline commit.
• When reviewing code, remove SaveChangesAsync unless there is a clear generated-value or immediate-commit requirement.

Entity Framework repository guidance

• Repository update rule (STRICT): Do not call repository.Update(...) / repo.Update(...) when using EF repositories.
• EF tracks loaded entities automatically. Modify the entity properties directly and let the Unit of Work persist the tracked changes.
• Only call Add/Create/Delete operations when inserting or removing entities.
• When reviewing code, remove unnecessary Update calls for entities loaded from an EF repository.

Mapperly guidance

• Any read/query method, including MediatR query handlers and application services, that returns Application-layer DTOs (*Dto) derived from Domain entities MUST use Mapperly.
  • Do not manually construct DTOs (new XxxDto { ... }) on read/query paths..
• Mapperly gate (absolute): If a handler/service returns entity-shaped DTOs or uses any mapper call, you MUST:
  • verify a Mapperly mapper exists by locating a [Mapper] partial mapper class with the required mapping method, e.g. CustomerToCustomerDto(Customer customer), and cite file path + excerpt, OR
  • if verification fails, immediately create the required Mapperly mapper(s), including all required nested mappers.
  • verify collection mappings when returning lists, e.g. CustomerToCustomerDtoList(IEnumerable<Customer> customers).
  • verify nested mapper dependencies use [UseMapper] and constructor injection where needed.
• Registration gate:
  • If a mapper is injected into a handler/service, verify it is registered in Application DI.
  • Follow the existing registration style. Mapperly sample projects register mappers as singletons, e.g. services.AddSingleton<CustomerDtoMapper>();.
  • If registration is missing, add the minimal mapper registration, including nested mapper registrations.
• Manual DTO construction is allowed only when the DTO is a non-entity-shaped view model/aggregation and Mapperly is not reasonable.
  • This must include an inline code comment explaining why Mapperly is not reasonable.
  • “Mapping doesn’t exist yet” is not a valid exception.
• If you can't find any existing mappings, create them in the same project as the services under:
  • ./Mappings/<FeatureOrAggregate>/<Entity>DtoMapper.cs
  • Example: MyApp.Application/Mappings/Invoices/InvoiceDtoMapper.cs

Example:

    [Mapper]
    public partial class OrderDtoMapper
    {
        [UseMapper]
        private readonly OrderLineDtoMapper _orderLineDtoMapper;

        public OrderDtoMapper(OrderLineDtoMapper orderLineDtoMapper)
        {
            _orderLineDtoMapper = orderLineDtoMapper;
        }

        [MapProperty(nameof(Order.Lines), nameof(OrderDto.OrderLines))]
        [MapPropertyFromSource(nameof(OrderDto.IsActive), Use = nameof(MapIsActive))]
        public partial OrderDto OrderToOrderDto(Order order);

        public partial List<OrderDto> OrderToOrderDtoList(IEnumerable<Order> orders);

        private bool MapIsActive(Order source) => source.IsActive();
}

Output expectations

Produce a concrete code update that:

• fills in or corrects the relevant service operation bodies
• adds private helper methods in the service if useful
• extends allowed-layer abstractions when needed for the service to be correct and performant
• preserves the existing feature style, naming, mapping conventions, and response shape
• keeps unrelated refactors out of scope

Review checklist

Before finishing, check that:

• every injected dependency belongs to the Domain or Application layers
• the service imports no infrastructure package namespaces
• repository/read-service/domain-service changes, if any, are expressed as abstractions only
• the implementation follows existing usage patterns for service orchestration, mapping, filtering, and persistence
• aggregation is not performed in memory when it should live behind an abstraction
• business language matches the surrounding domain model
• the code path is cancellation-aware and async-safe where applicable
• explicit save behavior matches nearby conventions and is only added when the use case requires it