finstack-quant

Prepares finstack for production release by orchestrating deprecated API removal, documentation readiness, semver review, dependency/security audits, performance regression checks, version metadata, release notes, and final quality gates. Use for release readiness, tagging, or publish-prep work; use finstack-quality-gate-triage or finstack-simplify for narrow failure or cleanup tasks.

Diagnoses and fixes pasted finstack quality-gate failures, including mise pre-commit-run, Rust clippy/test failures, cargo deny, OSV, Python build/lint/type/parity failures, WASM build/test failures, and iterative bug-hunting loops. Use when the user shares terminal output, asks to fix CI/pre-commit/lint/test failures, or asks to find and fix bugs until checks are clean.

Maintains finstack documentation across API docs, README/spec/changelog cleanup, stale reference audits, generated docs, examples, notebooks, and financial/math references. Use when adding or reviewing documentation, cleaning AI/process language, validating code references, completing public API docs, or checking docs against current source and tests.

Reviews finstack cross-language API parity across canonical Rust crates, PyO3 bindings, WASM bindings, Python stubs, package exports, JS facades, parity_contract.toml, tests, and examples. Use when touching finstack-quant-py, finstack-quant-wasm, public Rust APIs exposed through bindings, .pyi files, binding parity tests, or when the user mentions binding drift, Python/WASM parity, or Rust canonical API alignment.

Reviews finstack-quant code for cross-module consistency: naming conventions, pattern drift, Rust/Python/WASM naming triplets, builder/error/module conventions, and convention inventory updates. Use when the user asks to make patterns consistent, unify naming, check conventions, or find pattern drift. Prefer finstack-simplify for dedupe/API-surface consolidation and finstack-refactor for implementation changes.

Reviews code for performance issues focusing on algorithmic complexity, memory allocation, cache efficiency, numerical computation, and concurrency. Prioritizes simple, high-impact optimizations over micro-optimizations. Use when reviewing performance-sensitive code, optimizing hot paths, or when the user mentions performance, speed, latency, throughput, or memory efficiency.

Use when reviewing quant finance code, pricing models, trading logic, risk calculations, calibration, market convention handling, or numerical stability in Rust, Python, WASM, or SQL. Trigger for full-workspace quant production audits, line-level correctness reviews, pricing/risk defect hunts, and benchmark-convention checks.

Improves existing code structure without changing externally observable behavior. Use for behavior-preserving implementation refactors after scope is clear: extracting helpers/modules, renaming symbols, tightening types, splitting large files, or removing understood dead paths. Prefer finstack-simplify for finstack-wide dedupe/API-surface audits, finstack-binding-parity-reviewer for cross-language API drift, and finstack-documentation-maintainer for doc-only work.

Use when reviewing existing Rust crates, Rust libraries, Rust applications, or multi-crate workspaces for architecture quality, ownership boundaries, async design, error strategy, dependency direction, public API shape, or maintainability risks.

Simplifies, dedupes, audits, and refactors finstack Rust crates and Python/WASM bindings when the user mentions slop, wrapper bloat, parallel APIs, registry drift, builder sprawl, API-surface reduction, or over-engineering. Runs a phased Audit -> Plan -> Refactor -> Verify loop that preserves Rust-canonical behavior, binding parity, Decimal/currency/serde invariants, and project `mise run` verification.

Use when creating or updating architecture documentation for an existing Rust library, Rust crate, or multi-crate workspace, especially when docs must explain current module structure, public APIs, ownership, errors, async behavior, invariants, extension points, or handoff guidance.

General senior hedge-fund code review fallback focused on correctness, simplicity, production readiness, and avoiding over-engineering. Use when the user asks for a broad review and no narrower finstack specialist applies. Prefer finstack-quant-finance-review for pricing/risk/numerics, finstack-performance-reviewer for benchmark or hot-path work, finstack-rust-architecture-review for crate structure, finstack-binding-parity-reviewer for Python/WASM parity, and finstack-simplify for dedupe or API-surface consolidation.