| name | finishing-work |
| description | Use when shipping work. Pre-PR checklist, structured merge/PR decision, branch cleanup. |
Finishing Work
When to Use
โ ship workflow, after reviews pass.
Pre-PR Checklist
Before creating PR, verify:
- โ tests pass (fresh run, ยฌcached)
- โ lint/typecheck pass
- No debug code (console.log, debugger, TODO)
- Commits follow conventions
- Changes match plan (ยฌ scope creep)
- No generated files committed
- No secrets (.env, credentials, API keys)
PR Creation
gh pr create --base <target-branch> --head <feature-branch> \
--title "<type>(<scope>): <summary>" \
--body "$(cat <<'EOF'
## Summary
<what and why>
## Acceptance Criteria
- [x] AC1: ...
- [x] AC2: ...
## Test Plan
- [ ] Manual verification of ...
EOF
)"
Merge Gate
- NEVER merge directly โ only create PR
- User approves โง merges via GitHub
- After merge: cleanup worktree, close slice via tff-tools, delete branches
Anti-Patterns
- Merging without user approval
- Creating PR before all reviews pass
- Leaving stale worktrees after merge
- Force-pushing to shared branches
Rules
- โ PR: show URL to user
- โ cleanup: worktree delete, branch delete (local + remote)
- โ merge: rebase milestone branch on origin