devisland-approval-proxy

name	devisland-approval-proxy
description	Change DevIsland Approval Proxy behavior, IPC framing, policy evaluation, SQLite persistence, pending approval queues, replay logs, PTY transcript handling, fallback policy, or approval-related plugin observation events. Use for AppState, ApprovalProxyController, ApprovalPolicyEngine, SQLiteApprovalStore, HookSocketServer, IPCProtocol, and related tests.

DevIsland Approval Proxy

Use this when changing the app-side proxy daemon behavior. Read docs/agent/approval-proxy.md and docs/agent/stability-standards.md before editing.

Boundaries

Keep bridge scripts thin. They may receive stdin, add terminal metadata, forward IPC, and print provider-specific responses. Do not move DB access, policy evaluation, UI rendering, pack loading, audio playback, or long-running work into the bridge.

The macOS app owns:

• HookSocketServer / IPC listener behavior (TCP loopback + Unix socket).
• BridgeTokenManager / HookEventHandler IPC token lifecycle and message authentication.
• ApprovalProxyController orchestration.
• ApprovalPolicyEngine rule evaluation and ApprovalRuleService rule management.
• SQLiteApprovalStore persistence.
• HookEventClassifier event classification, HookEventRouter routing/auto-approve judgment, and ApprovalQueuePolicy pending-queue policy.
• ProviderAdapter provider response JSON.
• ApprovalFlowCoordinator pending-queue entry, display selection, decision dispatch, and approval timeout.
• AppState session state and notch presentation state (via ApprovalFlowContext).

Plugin observation events are best-effort side effects. They must not gate provider responses, approval queue draining, or persistence required for the approval decision.

Security Invariants

Do not regress these when changing transports or message parsing:

• The TCP listener binds to loopback (127.0.0.1) only.
• Raw JSON on TCP is rejected when a token file is present (authenticated envelope required); legacy raw JSON belongs on the Unix socket path.
• Envelope token validation failures deny the request.
• HookSocketServerTests and GoldenResponseTests lock this behavior — keep them passing unchanged.

Non-Blocking Rules

Do not block the UI or hook response path with heavy work.

• SQLite writes go through the persistence queue.
• AppleScript uses Process with timeout, not main-thread NSAppleScript.
• Network I/O and pack scans stay off the UI path.
• Best-effort side effects must not change approval/deny behavior.

When the app is unreachable, bridge fallback must preserve the configured policy and avoid freezing the originating CLI.

Session And Approval Flow

Preserve FIFO handling of pending approval requests. Approval timeouts, response handlers, and selected session state must not corrupt each other.

For session close or pruning, clean associated pending requests and PTY buffers. Always consider ptyBuffer.remove(sessionId:) when session lifecycle logic changes.

Tests

Choose focused tests based on the touched area:

• ApprovalProxyControllerTests
• ApprovalPolicyEngineTests
• SQLiteApprovalStoreTests
• IPCProtocolTests
• HookSocketServerTests
• GoldenResponseTests (handleMessage → response JSON behavior lock)
• ApprovalFlowCoordinatorTests
• ApprovalQueuePolicyTests
• ApprovalRuleServiceTests
• HookEventClassifierTests
• HookEventRouterTests
• AppStateTests
• HookEventNormalizerTests
• ProviderAdapterTests

Then run:

./scripts/run-tests.sh

Use devisland-change-verification before final handoff.