ds-code-quality-review

name	ds-code-quality-review
description	Run an extremely strict maintainability + single-source-of-truth review of code changes — abstraction quality, file sprawl, spaghetti-condition growth, and duplicate/competing implementations. Reports findings by default; `--fix` applies the mechanical, unambiguous ones — structural/code-judo restructurings rest on judgment and stay reported.
disable-model-invocation	true

When invoked, perform a deep code-quality audit focused on implementation quality, maintainability, abstraction quality, single source of truth, and overall codebase health. Be ambitious about structure: do not merely identify local cleanup opportunities — actively search for "code judo" moves that preserve behavior while making the implementation dramatically simpler, smaller, more direct, and more elegant. This works at the file/function/abstraction altitude, within the existing architecture — whether the architecture itself is sound is /ds-architecture-plan's question, not this one.

Arguments

Treat every argument as review scope (files or directories). If no scope is given, review the changed files on the current branch.

--full → review the entire codebase instead of just the branch's changes. Explicit paths still win; --full only replaces the no-scope default.

--fix → after reporting, apply only the findings whose fix is mechanical and unambiguous (a single obvious, behavior-preserving edit — e.g. deleting a dead wrapper or redundant helper, or pointing a duplicated literal at its canonical definition). The structural and code-judo restructurings this review favors — and structural consolidations like merging two implementations or deleting a subsystem — rest on judgment, so they stay report-only. Summarize what was applied vs. left.

Core Prompt

Start from this baseline:

Perform a deep code quality audit of the changes in scope. Rethink how to structure / implement the changes to meaningfully improve code quality without impacting behavior. Work to improve abstractions, modularity, reduce spaghetti code, improve succinctness and legibility. Be ambitious: if there is a clear path to improving the implementation that involves restructuring some of the codebase, go for it. Be extremely thorough and rigorous. Measure twice, cut once.

Non-Negotiable Standards

Apply the baseline prompt above, plus these explicit review rules:

0. Be ambitious about structural simplification.

   • Do not stop at "this could be a bit cleaner."
   • Look for opportunities to reframe the change so that whole branches, helpers, modes, conditionals, or layers disappear entirely.
   • Prefer the solution that makes the code feel inevitable in hindsight.
   • Assume there is often a "code judo" move available: a re-organization that uses the existing architecture more effectively and makes the change dramatically simpler and more elegant.
   • If you see a path to delete complexity rather than rearrange it, push hard for that path.

1. Do not let a change push a file from under 1k lines to over 1k lines without a very strong reason.

   • Treat this as a strong code-quality smell by default.
   • Prefer extracting helpers, subcomponents, modules, or local abstractions instead of letting a file sprawl past 1000 lines.
   • If the diff crosses that threshold, explicitly ask whether the code should be decomposed first.
   • Only waive this if there is a compelling structural reason and the resulting file is still clearly organized.

2. Do not allow random spaghetti growth in existing code.

   • Be highly suspicious of new ad-hoc conditionals, scattered special cases, or one-off branches inserted into unrelated flows.
   • If a change adds "weird if statements in random places", treat that as a design problem, not a stylistic nit.
   • Prefer pushing the logic into a dedicated abstraction, helper, state machine, policy object, or separate module instead of tangling an existing path.
   • Call out changes that make the surrounding code harder to reason about, even if they technically work.

3. Bias toward cleaning the design, not just accepting working code.

   • If behavior can stay the same while the structure becomes meaningfully cleaner, push for the cleaner version.
   • Do not rubber-stamp "it works" implementations that leave the codebase messier.
   • Strongly prefer simplifications that remove moving pieces altogether over refactors that merely spread the same complexity around.

4. Prefer direct, boring, maintainable code over hacky or magical code.

   • Treat brittle, ad-hoc, or "magic" behavior as a code-quality problem.
   • Be skeptical of generic mechanisms that hide simple data-shape assumptions.
   • Flag thin abstractions, identity wrappers, or pass-through helpers that add indirection without buying clarity.

5. Push hard on type and boundary cleanliness when they affect maintainability.

   • Question unnecessary optionality, unknown, any, or cast-heavy code when a clearer type boundary could exist.
   • Prefer explicit typed models or shared contracts over loosely-shaped ad-hoc objects.
   • If a branch relies on silent fallback to paper over an unclear invariant, ask whether the boundary should be made explicit instead.

6. Keep logic in the canonical layer and reuse existing helpers.

   • Call out feature logic leaking into shared paths or implementation details leaking through APIs.
   • Prefer existing canonical utilities/helpers over bespoke one-offs.
   • Push code toward the right package, service, or module instead of normalizing architectural drift.

7. Treat unnecessary sequential orchestration and non-atomic updates as design smells when the cleaner structure is obvious.

   • If independent work is serialized for no good reason, ask whether the flow should run in parallel instead.
   • If related updates can leave state half-applied, push for a more atomic structure.
   • Do not over-index on micro-optimizations, but do flag avoidable orchestration complexity that makes the implementation more brittle.

Primary Review Questions

For every meaningful change, ask:

• Is there a "code judo" move that would make this dramatically simpler?
• Can this change be reframed so fewer concepts, branches, or helper layers are needed?
• Does this improve or worsen the local architecture?
• Did the diff add branching complexity where a better abstraction should exist?
• Did a previously cohesive module become more coupled, more stateful, or harder to scan?
• Is this logic living in the right file and layer?
• Did this change enlarge a file or component past a healthy size boundary?
• Are there repeated conditionals that signal a missing model or missing helper?
• Is the implementation direct and legible, or does it rely on special cases and incidental control flow?
• Is this abstraction actually earning its keep, or is it just a wrapper?
• Did the diff introduce casts, optionality, or ad-hoc object shapes that obscure the real invariant?
• Is this logic living in the canonical layer, or did the diff leak details across a boundary?
• Is this orchestration more sequential or less atomic than it needs to be?

What to Flag Aggressively

Escalate findings when you see:

• A complicated implementation where a cleaner reframing could delete whole categories of complexity.
• Refactors that move code around but fail to reduce the number of concepts a reader must hold in their head.
• A file crossing 1000 lines due to the change, especially if the new code could be split out.
• New conditionals bolted onto unrelated code paths.
• One-off booleans, nullable modes, or flags that complicate existing control flow.
• Feature-specific logic leaking into general-purpose modules.
• Generic "magic" handling that hides simple structure and makes the code harder to reason about.
• Thin wrappers or identity abstractions that add indirection without simplifying anything.
• Unnecessary casts, any, unknown, or optional params that muddy the real contract.
• Copy-pasted logic instead of extracted helpers.
• Narrow edge-case handling implemented in the middle of an already busy function.
• Refactors that technically pass tests but make the code less modular or less readable.
• "Temporary" branching that is likely to become permanent debt.
• Bespoke helpers where the codebase already has a canonical utility for the job.
• Logic added in the wrong layer/package when it should live somewhere more central.
• Sequential async flow where obviously independent work could stay simpler and clearer with parallel execution.
• Partial-update logic that leaves state less atomic than necessary.
• Feature envy — a method using another object's data more than its own; move it to where the data lives.
• Data clumps — the same few fields or params that always travel together; bundle them into a type.
• Divergent change — one module repeatedly edited for several unrelated reasons; split it by reason.

Preferred Remedies

When you identify a code-quality problem, prefer suggestions like:

• Delete a whole layer of indirection rather than polishing it.
• Reframe the state model so conditionals disappear instead of getting centralized.
• Change the ownership boundary so the feature becomes a natural extension of an existing abstraction.
• Turn special-case logic into a simpler default flow with fewer exceptions.
• Extract a helper or pure function.
• Split a large file into smaller focused modules.
• Move feature-specific logic behind a dedicated abstraction.
• Replace condition chains with a typed model or explicit dispatcher.
• Separate orchestration from business logic.
• Collapse duplicate branches into a single clearer flow.
• Delete wrappers that do not meaningfully clarify the API.
• Reuse the existing canonical helper instead of introducing a near-duplicate.
• Make type boundaries more explicit so the control flow gets simpler.
• Move the logic to the package/module/layer that already owns the concept.
• Parallelize independent work when that also simplifies the orchestration.
• Restructure related updates into a more atomic flow when partial state would be harder to reason about.

Do not be satisfied with "maybe rename this" feedback when the real issue is structural. Do not be satisfied with a merely cleaner version of the same messy idea if there is a plausible path to a much simpler idea.

Single source of truth

A second lens on the same diff: prefer existing code over new code; prefer deletion over addition. The maintainability rules above ask "is this the simplest structure?"; this asks "does this already exist, and is it now the only copy?" Assume parallel agents may have touched the tree, so watch for the same concept solved twice.

Flag, anchored to file:line:

• Duplication — functionality that already exists elsewhere: a second HTTP client, retry, cache, validation layer, serializer, config system, logging wrapper, or feature-flag mechanism. → reuse the existing implementation.
• Constant drift — a literal, limit, timeout, path, env var, regex, or protocol value duplicated instead of referenced from its canonical definition.
• Competing implementations — one concept built two ways: rival helpers, multiple utility files for the same problem, naming divergence for an identical concept. → consolidate into one.
• Unjustified dependencies — a dependency added for one trivial function, or replaceable by the stdlib or a platform feature. → drop it, name the replacement.
• Reinvented idioms & drifting patterns — hand-rolled functionality the language or stdlib already provides, or a new pattern/architecture style where the project already has an established one. → follow the existing convention.

Review Tone

Be direct, serious, and demanding about quality. Do not be rude, but do not soften major maintainability issues into mild suggestions. If the code is making the codebase messier, say so clearly. If the implementation missed an opportunity for a dramatic simplification, say that clearly too.

Good phrases:

• this pushes the file past 1k lines. can we decompose this first?
• this adds another special-case branch into an already busy flow. can we move this behind its own abstraction?
• this works, but it makes the surrounding code more spaghetti. let's keep the behavior and restructure the implementation.
• this feels like feature logic leaking into a shared path. can we isolate it?
• this abstraction seems unnecessary. can we just keep the direct flow?
• why does this need a cast / optional here? can we make the boundary more explicit instead?
• this looks like a bespoke helper for something we already have elsewhere. can we reuse the canonical one?
• i think there's a code-judo move here that makes this much simpler. can we reframe this so these branches disappear?
• this refactor moves complexity around, but doesn't really delete it. is there a way to make the model itself simpler?

Output

Prioritize findings in this order:

1. Structural code-quality regressions
2. Single-source-of-truth violations (duplicate or competing implementations, drifted constants, unjustified dependencies)
3. Missed opportunities for dramatic simplification / code-judo restructuring
4. Spaghetti / branching complexity increases
5. Boundary / abstraction / type-contract problems that make the code harder to reason about
6. File-size and decomposition concerns
7. Modularity and abstraction issues
8. Legibility and maintainability concerns

Anchor each finding to <file>:<line> where possible. Do not flood the review with low-value nits if there are larger structural issues. Skip anything a linter or formatter already enforces — spend the review on the structural findings tools can't see.

Report-only by default — changes nothing. With --fix, apply only the mechanical, behavior-preserving findings and leave the structural ones reported. After applying, re-run any build/test/lint check already in the loop and revert any fix that breaks it or that touched more than the intended edit; then summarize what was applied vs. left. Prefer a smaller number of high-conviction comments over a long list of cosmetic notes.

Approval Bar

Do not approve merely because behavior seems correct. The bar for approval is:

• no clear structural regression
• no obvious missed opportunity to make the implementation dramatically simpler when such a path is visible
• no unjustified file-size explosion
• no obvious spaghetti-growth from special-case branching
• no obviously hacky or magical abstraction that makes the code harder to reason about
• no unnecessary wrapper/cast/optionality churn obscuring the real design
• no clear architecture-boundary leak, avoidable canonical-helper duplication, or new duplicate/competing source of truth
• no missed opportunity for an obvious decomposition that would materially improve maintainability

Treat these as presumptive blockers unless the author can justify them clearly:

• the change preserves a lot of incidental complexity when there is a plausible code-judo move that would delete it
• the change pushes a file from below 1000 lines to above 1000 lines
• the change adds ad-hoc branching that makes an existing flow more tangled
• the change solves a local problem by scattering feature checks across shared code
• the change adds an unnecessary abstraction, wrapper, or cast-heavy contract that makes the design more indirect
• the change duplicates an existing helper or puts logic in the wrong layer when there is a clear canonical home, drifts a constant away from its canonical definition, introduces a competing implementation of an existing concept, or pulls in an unjustified dependency

If those conditions are not met, leave explicit, actionable feedback and push for a cleaner decomposition.