pre-land-review

name	pre-land-review
description	The review gate that must pass before any commit lands. Called automatically by the /commit skill — do NOT invoke directly when the user says "commit", "land", "ship it", etc. (use /commit instead). Invoke directly only when you want to run the review without committing, or when another skill references it. This is a MANDATORY gate — do not create a git commit without completing this checklist.
user-invocable	true
argument-hint	[git-ref range, default HEAD~1]

Pre-Land Review Checklist

This skill is the landing gate for vibeSpatial. Every commit must pass through it. The checklist has two tiers: deterministic checks (enforced by the pre-commit hook) and AI-powered analysis (run as a single review agent).

Tier 1: Deterministic Checks

Run each command. ALL must pass before committing.

uv run ruff check
uv run python scripts/check_docs.py --check
uv run python scripts/check_architecture_lints.py --all
uv run python scripts/check_zero_copy.py --all
uv run python scripts/check_perf_patterns.py --all
uv run python scripts/check_maintainability.py --all
uv run python scripts/check_import_guard.py --all

If any fail, fix the issues before proceeding. The pre-commit hook will also enforce these, but catching them here avoids a failed commit attempt.

Tier 2: AI-Powered Review

The pre-commit hook CANNOT do this — it requires AI judgment. The review runs as a single dedicated agent that performs all review passes sequentially in one context, analyzing the code with fresh eyes without being biased by the context of having written the code.

Step 1: Gather context

1. Run git diff --cached --name-only (or git diff HEAD~1 --name-only) and save the file list.
2. Run git diff --cached (or git diff HEAD~1) and save the full diff.
3. If the changes are test-only, skip Tier 2 entirely — deterministic checks suffice.

Step 2: Launch review agent

Spawn a single pre-land-reviewer agent with the file list and diff. This agent performs all review passes (GPU code, zero-copy, performance, maintainability, diff shape) sequentially in one context.

Prompt template:

Review the following changes for vibeSpatial.

## Changed Files
{file_list}

## Full Diff
{diff}

The agent already knows its review procedure and severity rules from its agent definition. You only need to provide the diff context.

Step 3: Collect and report

Wait for the agent to complete, then report its findings.

Report Format

## Pre-Land Review

### Changed Files
[list with categories]

### Deterministic Checks
[PASS/FAIL for each]

### Agent Review

#### GPU Code Review: [CLEAN / BLOCKING ISSUES]
[findings or "N/A — no GPU code touched"]

#### Zero-Copy Analysis: [CLEAN / LEAKY / BROKEN]
[findings or "N/A"]

#### Performance Analysis: [PASS / FAIL]
[findings or "N/A"]

#### Maintainability: [DISCOVERABLE / GAPS / ORPHANED]
[findings or "N/A"]

#### Diff Shape: [CLEAN / findings]
[findings or "N/A"]

### Overall Verdict
[LAND / FIX REQUIRED]

Note: LAND requires zero BLOCKING findings across all passes.

Severity Rules

The review agent follows these severity rules (defined in its agent definition):

• BLOCKING — Must fix before landing. Default for all findings.
• NIT — Only for pure style preferences with zero functional or performance impact.

"Existing codebase does it too" is NEVER a valid NIT justification. If new code builds on a broken upstream pattern, that is BLOCKING — fix the upstream too.

Rules

• ALL deterministic checks must pass.
• ANY BLOCKING finding means FIX REQUIRED.
• Test-only changes need only deterministic checks (skip agent).
• Be concise — this is a gate, not a code review.

After Review

If the verdict is LAND, write the content-addressable review marker:

printf '{\n  "timestamp": "%s",\n  "staged_hash": "%s",\n  "files": [%s],\n  "verdict": "LAND"\n}\n' \
  "$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
  "$(git diff --cached | sha256sum | cut -d' ' -f1)" \
  "$(git diff --cached --name-only | sed 's/.*/"&"/' | paste -sd,)" \
  > .claude/.review-completed

The commit-msg hook verifies:

1. The file exists and is less than 1 hour old.
2. staged_hash matches a fresh git diff --cached | sha256sum.
3. verdict is LAND.

The marker is single-use — the hook deletes it after a successful commit.

Then proceed with the commit.