add-tests

name	add-tests
description	Combined unit + UI test gap-filling for all changed code. Analyzes the branch diff and creates missing tests for domain logic, data access, presenters, and UI screens.

Add Tests

Comprehensive test gap-filling that combines unit tests and UI tests.

Steps

1. Analyze Changes

git diff origin/main...HEAD --name-only -- '*.kt'

Categorize changed files:

• impl/domain/ → needs unit tests (use case logic)
• impl/data/ → needs unit tests (repository logic)
• impl/presentation/src/commonMain/ → needs presenter unit tests
• impl/presentation/src/androidMain/ → needs UI tests (Robot pattern) + may need navint-tests
• api/navigation/ → may need navint-tests for navigation contract changes
• test/ → fake changes may require updating existing tests
• api/ → contract changes may require updating tests + fakes

2. Fill Unit Test Gaps

Follow the add-unit-tests skill instructions:

• Read .agents/skills/add-unit-tests/SKILL.md for templates and conventions
• Create missing test files for Impl classes, repositories, and presenters
• Ensure fakes exist in test/src/commonMain/ for all abstract use cases

3. Fill UI Test Gaps

Follow the add-ui-tests skill instructions:

• Read .agents/skills/add-ui-tests/SKILL.md for templates and conventions
• Create missing UiTest, UiRobot, StateRobot for new/changed screens
• Ensure TestTags exist in api/navigation/ for testable elements
• Ensure AndroidManifest.xml exists in androidDeviceTest

4. Check navint-tests Coverage

Android navint-tests: If impl/presentation/src/androidMain/ or api/navigation/ changed, check whether a corresponding test exists in testing/navint-tests/src/androidDeviceTest/kotlin/:

• Files end with NavigationTest.kt or IntegrationTest.kt
• Tests use JUnit4 @RunWith(AndroidJUnit4::class) — NOT Kotest BehaviorSpec
• Tests exercise real Circuit presenters with a fake data layer (fakes from features/{name}/test/)

If a navigation flow or integration scenario lacks coverage, add the test in testing/navint-tests/. See .agents/standards/testing-navint.md for the navint-tests conventions.

iOS navint-tests: If iosApp/iosApp/Circuit/ changed, check whether corresponding tests exist in iosApp/iosAppTests/NavInt/:

• Test suites: NavigationStateManagerTest, TabSwitchingTest, DeepLinkNavigationTest, AuthFlowNavigationTest
• Tests use Swift Testing (@Suite @MainActor struct) — NOT XCTest
• Tests exercise NavigationStateManager state transitions (no ViewInspector, state management only)

If a navigation state change or new navigation flow lacks iOS coverage, add or update tests in iosApp/iosAppTests/NavInt/. See .agents/standards/testing-navint.md for the iOS navint-tests conventions.

5. Check e2e-tests Coverage

If a new user journey, deep link, or tab navigation flow was added, check whether a corresponding test exists in testing/e2e-tests/src/main/kotlin/.../suites/:

• Journey test files end with JourneyTest.kt
• Tests use JUnit4 @RunWith(AndroidJUnit4::class) and AppRobot for all interactions
• Tests interact via UI Automator (By.desc(testTag)) — no direct code access
• TestTags come from features/*/api/navigation/

If a startup performance concern exists, check testing/benchmarks/src/main/kotlin/com/mockdonalds/app/benchmarks/ (separate module, minified target):

• Benchmark files end with Benchmark.kt
• Uses MacrobenchmarkRule with StartupTimingMetric()

See .agents/standards/testing-e2e.md for e2e-tests conventions, testing/e2e-tests/AGENTS.md for journey-test details, and testing/benchmarks/AGENTS.md for macrobenchmark details.

6. Post-Change Verification — MANDATORY

Work is NEVER complete until verification passes. Run the verify skill to validate all changes. It will:

• Detect which modules have new or changed test files
• Run lint, unit tests, and architecture checks scoped to those modules
• Catch test naming violations, Robot pattern issues, and convention problems
• Trigger navint-tests (./gradlew :testing:navint-tests:connectedAndroidDeviceTest) if presentation or navigation modules changed (requires emulator)

If ANY check fails, fix the issue and re-run. Do not declare the task complete until verification passes.