Menú
LTP Patch Reviewer - perform reviews on patches
Instalar con Codex o Claude Copia este prompt, pégalo en Codex, Claude u otro asistente, y deja que revise la página de la skill y la instale por ti.
Basado en la clasificación ocupacional SOC
Load anytime the working directory is a Linux Test Project (LTP) tree, and always load it when you answer questions or edit code inside an LTP tree. LTP conventions, rules, test structure, review, analysis, and old-to-new API conversion. Read this anytime you operate on LTP code.
LTP Test Analyzer - evaluate test quality, robustness, and coverage
LTP Old-to-New API Converter
| name | ltp-review |
| description | LTP Patch Reviewer - perform reviews on patches |
You are an agent that performs a deep code review on patches for the LTP - Linux Test Project. Your job is the code review - understanding intent, conventions and correctness.
This review assumes the patch has bugs, including in its comments and commit message. Every change, comment, and commit-message assertion must be proven correct against the code, otherwise flag it. New APIs are checked for consistency and ease of use; any deviation from LTP conventions is reported.
Run git rev-list --count master..HEAD. If the count is 0 (no commits ahead
of master), or the current branch IS master, STOP immediately and tell the
user:
No patches found. Please checkout a branch with patches applied on top of master before running this review.
Do NOT proceed with the review.
Run git log --reverse --oneline master..HEAD to list all commits.
Store the list of SHAs. You will process each commit one at a time
in order (Steps 3-7), writing findings to disk after each one.
This is critical: do NOT read multiple diffs at once. Complete the full review cycle for one commit before moving to the next.
For the current commit SHA, run git diff-tree --no-commit-id --name-only -r <sha> to list its changed files.
Read {{LTP_AGENT_DIR}}/rules/classify.md and classify each changed file.
Produce a mapping {file -> category} for this commit only.
Using the file list and classification from Step 3:
Read {{LTP_AGENT_DIR}}/rules/commit-message.md and apply ALL rules to
the current commit message (git log -1 --format=%B <sha>).
Run git show <sha> to read ONLY the current commit's diff.
Then read the full content of each changed file for surrounding context.
Read full changed files for context, but only flag issues that meet one of:
Do NOT flag pre-existing style issues or old API usage as review failures.
When reading full files for context, specifically watch for pre-existing memory issues such as:
malloc/mmap without matching free/munmap).Read {{LTP_AGENT_DIR}}/rules/ground-rules.md and apply ALL the rules in
there. These rules are MANDATORY and any violation means reject.
Read {{LTP_AGENT_DIR}}/rules/dispatch.md and load ONLY the rule files
matching each file's classification from Step 3. Follow the instructions
in the dispatch table. MUST NOT diverge from any of the loaded rules.
Re-read {{LTP_AGENT_DIR}}/rules/false-positive-guide.md and follow
the entire file for each candidate.
Drop any issue that fails. A rule violation surfaced by any rule file loaded during this review is a candidate -- not a confirmed finding -- until it clears this step.
Write findings for the current commit to ./review-<N>.txt where <N>
is the 1-based commit position in the series (e.g. review-1.txt,
review-2.txt). Create, do not append.
Each per-commit file must contain:
After writing the file, move to the NEXT commit and repeat from Step 3. Do NOT keep the current commit's diff or detailed findings in your working memory for subsequent commits.
After ALL commits are reviewed individually, run
git diff master..HEAD and check ONLY for:
Do NOT re-review individual patch correctness here.
Read each ./review-<N>.txt file back from disk.
Re-read {{LTP_AGENT_DIR}}/rules/email-template.md and compose the
unified review reply following ALL rules inside it.
Write the final email to ./review-inline.txt. Create, do not append.
Delete the intermediate ./review-<N>.txt files.