terraform-provider-hyperv

Walk through review comments and failed CI checks on the current branch's PR, propose a fix per finding, and stage it for the author to review BEFORE committing. One pause-and-review cycle per finding. Use when the user says "address PR feedback", "fix the PR comments", "go through the review", or after a `gh pr checks` shows failures and the author wants to work through them one at a time. Pairs with create-pr (outgoing) and review-pr (pre-commit).

Push the current branch and open or update its pull request with a calm, prose-first description that matches the project's claude-code-review.yaml style. Generates the description ONLY when the PR has no body (or just whitespace) -- a substantial human- or AI-authored body is preserved untouched. Run after committing and before announcing the PR. Use whenever the user asks to "open the PR", "push and PR", or after `task lint && test:unit && test:pester` are green and the branch is ready.

Author and maintain the embedded PowerShell scripts under internal/scripts/. Use when editing any *.ps1 file or the common preamble. Knows the §5 contract this provider locks in — Windows PowerShell 5.1 syntax floor, also tested on 7.4; -EncodedCommand for script body; UTF-8 stdout pin; $ProgressPreference suppression; structured JSON error envelope; ConvertTo-Json -Depth 10 -Compress; CIM cmdlets not WMI; ToString('o') for DateTime. These rules came from spikes

Author terraform-provider-hyperv resources, data sources, the typed Hyper-V client, and connection backends. Use when editing files under internal/provider, internal/resources, internal/datasources, internal/hyperv, internal/connection, internal/types, or when changing schema, plan modifiers, validators, or provider configuration. Knows the terraform-plugin-framework idioms this repo locks in (PLAN.md §8, §11), how MarkdownDescription drives Registry docs (§15), and the SDKv2 anti-patterns to avoid (§11). Not for PowerShell scripts (use powershell-scripter), tests (use test-engineer), or release plumbing.

Write and structure tests across the three tiers this provider uses — Pester (PowerShell scripts standalone), Go unit (with fakeRunner returning canned JSON), and acceptance (TF_ACC=1 against real Hyper-V using terraform-plugin-testing). Use when adding tests for any new resource or data source, expanding coverage, fixing flaky tests, or deciding which tier a given assertion belongs in. Knows the TDD ordering this repo enforces — Pester first to lock the JSON contract, then Go unit, then resource schema, then acceptance, then implementation. Knows the modern terraform-plugin-testing API (statecheck, knownvalue, tfjsonpath, plancheck) and why we don't use the legacy ComposeAggregateTestCheckFunc style.

Pre-commit bug review for terraform-provider-hyperv. Analyzes the staged diff across five parallel passes to find logic bugs, framework anti-patterns, schema-migration risks, sensitive-attribute leaks, PowerShell portability traps, and drift-handling errors before committing. Run as the final step before git commit. Adapted from the windsorcli/cli review-pr skill but tuned for terraform-plugin-framework + Hyper-V/PowerShell concerns. Do not flag style issues, missing comments, or refactoring suggestions — those are handled by other skills (provider-author, powershell-scripter, test-engineer).