fxa-test-draft

name	fxa-test-draft
description	Drafts Jest tests for changed code. Defaults to staged/unstaged changes or the most recent commit. Output is a starting point for review, not final.
allowed-tools	Bash, Read, Grep, Glob
argument-hint	["file-path | commit-ref | git-range"]
user-invocable	true
context	fork

FXA Draft Tests

Draft Jest tests for changed code following FXA conventions and the project testing guidelines. Output is a draft — review before committing.

Read the shared testing guidelines before proceeding: .claude/skills/fxa-testing-shared/GUIDELINES.md

If any of the changed files are React/TSX (fxa-settings and similar), also read Section 5 ("Testing Patterns (React/TSX)") of .claude/skills/fxa-check-react/SKILL.md and apply those rules to drafted component tests.

---

Step 1: Identify Scope

If $ARGUMENTS is provided, use it as the target (file path, commit ref, or git range). Otherwise determine scope automatically:

1. Unstaged + staged changes first:

git diff HEAD       # unstaged
git diff --cached   # staged

If either produces output, that is your scope.

2. Fallback — most recent commit (if working tree is clean):

git diff HEAD~1..HEAD

Read the full diff before proceeding.

---

Step 2: Identify Source Files to Test

From the diff, extract files that:

• Contain new or modified logic (functions, branches, classes, route handlers)
• Are not already test files (*.spec.ts, *.test.ts, *.test.tsx)
• Are not generated, config, or migration files

For each source file, check whether a co-located test file already exists and what it already covers. Most times, tests will be co-located but can be in a dedicated test[s]/ directory.

---

Step 3: Explore Existing Test Patterns

For each source file, read nearby test files and shared mocks to understand the conventions in that package. Substitute <pkg> with the package directory (e.g. fxa-auth-server, fxa-settings) and <src-dir> with the directory of the source file under test.

# 1. Find existing tests near the source file (auth-server uses *.spec.ts in lib/,
#    fxa-settings uses co-located *.test.tsx next to components)
find packages/<pkg>/<src-dir> -maxdepth 2 \( -name '*.spec.ts' -o -name '*.test.ts' -o -name '*.test.tsx' \) | head -20

# 2. Find shared mocks at the package root (e.g. packages/fxa-auth-server/test/mocks.js
#    exposes mockDB, mockLog, mockMailer, mockPush, etc.)
find packages/<pkg>/test -maxdepth 3 \( -iname 'mocks*' -o -iname 'mock-*' \) 2>/dev/null

# 3. Read a representative existing test in the package to mirror its jest.mock layout,
#    setup/teardown structure, and any custom matchers
grep -rn 'jest.mock(' packages/<pkg> --include='*.spec.ts' --include='*.test.ts' --include='*.test.tsx' | head -10

# 4. For React tests in fxa-settings: see how providers are wrapped (Intl, Router, etc.)
grep -rn 'renderWithProviders\|MockedProvider\|IntlProvider' packages/fxa-settings/src --include='*.test.tsx' | head -5

Determine:

• Framework in use — must be Jest. Flag if Mocha is present (legacy; no new Mocha tests).
• Co-location convention: *.spec.ts (auth-server lib/) or *.test.tsx (fxa-settings)
• Available shared mocks: mockDB, mockLog, mockMailer, mockPush, etc. from test/mocks.js
• How jest.mock() is structured in this package

---

Step 4: Analyze What Needs Tests

For each changed function or module, identify:

• Happy paths — the expected successful flows
• Error cases — thrown errors, rejected promises, validation failures
• Edge cases — nulls, empty arrays, boundary values, missing auth
• Branches — every if/else, switch, ternary, optional chaining path

Call out any code that is difficult to test due to:

• Missing dependency injection (direct new Foo() instantiation inside logic)
• Functions doing too many things (test surface too large)
• Side effects embedded in otherwise pure logic
• Missing error boundaries
• Business rules embedded in route handlers or React components that should live in pure functions / hooks / services for unit testing (see "Test layers and shift-left" in GUIDELINES.md)

Do not skip coverage for hard-to-test code — flag it explicitly and suggest a refactor where applicable.

Pick the right layer before drafting. Before writing route-handler or component tests, ask: is the branching here business logic, or wiring? If the changeset has nuanced internal rules (validation, calculation, decision logic) sitting inside a route handler or component, propose extracting the rule first and unit-testing the extracted unit. Reserve route/component tests for wiring (auth, request/response shape, error propagation, rendering). Heavy per-branch fixtures at the route/component level are the signal you're testing at the wrong layer.

---

Step 5: Present the Test Plan

Before writing any code, output a test plan table for the engineer to review:

File	Function / Handler	Type	Proposed test name
lib/account.ts	getAccount	happy path	returns account when found
lib/account.ts	getAccount	error	throws NotFound when account does not exist
lib/account.ts	getAccount	edge case	returns null when db returns empty result

Include a row for every case identified in Step 4. Mark any cases flagged as difficult to test with a ⚠️ and a brief inline note.

Pause here. Ask the engineer if the coverage looks right, if any cases should be added or removed, or if the scope should be adjusted. Do not proceed to drafting until confirmed.

---

Step 6: Draft the Tests

Write Jest tests for each identified case following the shared guidelines.

Place tests in the co-located test file (*.spec.ts or *.test.tsx). If the file doesn't exist, create it with the MPL-2.0 license header at the top.

Leave things better than you found them. When adding tests to an existing file, write new tests to the guidelines standard — don't copy existing patterns that violate them. If existing tests have clear issues, note them in the output and suggest the engineer run /fxa-test-repair. Don't rewrite existing tests wholesale unless that's explicitly in scope.

After drafting, consider running /fxa-test-independence to verify the new tests pass both as a suite and in isolation.

---

Step 7: Output

For each source file, produce:

1. Test file path — where the tests should live
2. Coverage summary — happy paths, error cases, and branches covered
3. Drafted tests — complete, runnable Jest test blocks
4. Callouts — any code that is difficult to test, with a brief explanation and suggested refactor if applicable

If a test file already exists, show only the new blocks to add, not the full file.

Remind the user: these are drafts. Review mock return values, error types, and edge case assumptions before committing.