worker-cli

name	worker-cli
description	Implements Rust CLI changes (MCP tools, transports, auth commands, tests)

CLI Worker

NOTE: Startup and cleanup are handled by worker-base. This skill defines the WORK PROCEDURE.

When to Use This Skill

Features that modify the Rust CLI at ./cli/. This includes:

• MCP server tools, transports, and modes (rmcp SDK)
• CLI commands (init, config, inject, deploy cloudflare, shares, auth, usage, etc.)
• Integration tests and unit tests
• Dependency changes in Cargo.toml
• CLI-adjacent docs / README / templates under ./ and ./docs/
• Version bumps and git tag creation (when explicitly the feature goal)

Required Skills

• tuistory — REQUIRED when implementing or verifying any interactive CLI prompt (stdin TTY). Invoke before driving prompts like spikes init's hosted/self-host selection or spikes deploy cloudflare's hosted-warning confirmation. Each tuistory session counts as one interactiveChecks entry in the handoff. Evidence requirement: for any feature that adds or modifies an interactive prompt, your handoff's verification.interactiveChecks MUST contain at least one entry per prompt branch (e.g., both the default and non-default answers) with the full action transcript. A handoff that lacks tuistory evidence for a prompt feature will be flagged as incomplete by scrutiny.
• agent-browser — REQUIRED when the feature includes an end-to-end widget-in-page flow (e.g., golden-path spikes init → spikes inject → widget POST to https://spikes.sh/spikes served via widget-test-server). Use it to click the widget button, submit a test spike, and capture network logs for the live POST response. Do not substitute with curl when an assertion calls for a real browser interaction.

Work Procedure

1. Read the feature description thoroughly. Understand preconditions, expected behavior, and verification steps.

2. Understand current code. Read relevant source files in ./cli/src/. Key files:

   • main.rs — Command routing (clap derive). MCP already wired.
   • commands/mcp.rs — MCP server (SpikesService, DataSource, TransportMode, all 9 tools)
   • commands/export.rs — Export formats (EXTEND with new variants)
   • spike.rs — Data models (Spike, Rating, SpikeType, is_resolved())
   • storage.rs — load_spikes() reads .spikes/feedback.jsonl
   • error.rs — Error types
   • Cargo.toml — Dependencies

3. Write tests FIRST (TDD).

   • Unit tests: Add #[cfg(test)] mod tests { ... } in the same file as the code being tested.
   • Integration tests: Add/extend files in ./cli/tests/ using assert_cmd and predicates.
   • For MCP write tools: test mutation logic (submit creates spike, resolve marks resolved, delete removes) as unit tests using in-memory spike vectors.
   • For MCP remote mode: test DataSource abstraction with mock HTTP responses.
   • For MCP transport: test HTTP endpoint with reqwest in integration tests.
   • For auth commands: test CLI output format, --json flag.
   • Run cd cli && cargo test — new tests MUST fail (red phase).

4. Add dependencies if needed.

   • rmcp 0.17 with server, transport-io, macros features already in Cargo.toml.
   • schemars 1.0 already in Cargo.toml.
   • For HTTP transport, check if rmcp has transport-sse-server or similar feature. If not, use axum (already a dependency).

5. Implement the feature. Make the tests pass (green phase).

   • For MCP write tools: Add new tool methods to SpikesService with #[tool] macro. Add arg structs with JsonSchema derive. Use storage::update_spike(), storage::remove_spike() for mutations. For submit, construct Spike struct and save via save_spikes().
   • For MCP remote mode: Create DataSource enum (Local/Remote). Pass to SpikesService::new(). Remote variant uses ureq HTTP calls. Token from auth::AuthConfig or SPIKES_TOKEN env.
   • For MCP HTTP transport: Add axum HTTP handler or use rmcp HTTP transport feature. Bind 127.0.0.1.
   • For auth commands: Create cli/src/commands/auth_keys.rs. Follow patterns from login.rs/shares.rs.
   • Follow existing patterns. No unwrap() in production. Punk/zine energy in user-facing strings.

6. Run all tests. cd cli && cargo test — ALL tests must pass (existing + new).

7. Build check. cd cli && cargo build — must succeed with zero errors.

8. Manually verify. Run the command directly:

   • MCP tools: printf '{"jsonrpc":"2.0","id":1,"method":"initialize","params":{}}\n{"jsonrpc":"2.0","id":2,"method":"tools/list","params":{}}\n' | cargo run -- mcp serve 2>/dev/null
   • MCP remote: SPIKES_TOKEN=test cargo run -- mcp serve --remote 2>/dev/null (verify starts)
   • MCP HTTP: cargo run -- mcp serve --transport http --port 3848 & then curl
   • Auth: cargo run -- auth create-key --help (verify subcommand exists)

9. Commit with descriptive message.

Example Handoff

{
  "salientSummary": "Rewrote MCP server using rmcp 0.17 SDK with #[tool_router] macro. Exposes get_spikes (page/rating/unresolved filters), get_element_feedback (selector), get_hotspots (limit). Added 10 unit tests for tool logic and 2 integration tests piping JSON-RPC to binary. All 172 tests pass.",
  "whatWasImplemented": "Complete MCP server rewrite in cli/src/commands/mcp.rs using rmcp SDK. SpikesService struct with 3 tools via #[tool_router]. Async stdio transport. Added rmcp 0.17 and schemars 1.0 to Cargo.toml. Replaced hand-rolled JSON-RPC with SDK macros. Server info: spikes-mcp, protocol 2024-11-05.",
  "whatWasLeftUndone": "",
  "verification": {
    "commandsRun": [
      { "command": "cd cli && cargo test", "exitCode": 0, "observation": "172 tests pass including 12 new MCP tests" },
      { "command": "cd cli && cargo build", "exitCode": 0, "observation": "No errors" },
      { "command": "echo '{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"initialize\",\"params\":{}}' | cargo run -- mcp serve 2>/dev/null", "exitCode": 0, "observation": "Response contains protocolVersion, capabilities.tools, serverInfo.name=spikes-mcp" },
      { "command": "printf '{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"initialize\",\"params\":{}}\\n{\"jsonrpc\":\"2.0\",\"id\":2,\"method\":\"tools/list\",\"params\":{}}\\n' | cargo run -- mcp serve 2>/dev/null", "exitCode": 0, "observation": "Two valid JSON responses, tools/list shows 3 tools" }
    ],
    "interactiveChecks": []
  },
  "tests": {
    "added": [
      {
        "file": "cli/src/commands/mcp.rs",
        "cases": [
          { "name": "test_get_spikes_no_filter", "verifies": "returns all spikes" },
          { "name": "test_get_spikes_filter_page", "verifies": "page filter works" },
          { "name": "test_get_spikes_filter_rating", "verifies": "rating filter works" },
          { "name": "test_get_spikes_unresolved_only", "verifies": "unresolved filter works" },
          { "name": "test_get_element_feedback_by_selector", "verifies": "selector matching" },
          { "name": "test_get_element_feedback_missing_selector", "verifies": "error on missing required param" },
          { "name": "test_get_hotspots_default_limit", "verifies": "returns top 10 sorted desc" },
          { "name": "test_get_hotspots_custom_limit", "verifies": "limit parameter respected" },
          { "name": "test_get_hotspots_empty", "verifies": "no element feedback message" },
          { "name": "test_tools_list", "verifies": "3 tools returned with schemas" }
        ]
      },
      {
        "file": "cli/tests/mcp_integration.rs",
        "cases": [
          { "name": "test_mcp_initialize", "verifies": "JSON-RPC initialize handshake" },
          { "name": "test_mcp_sequential_requests", "verifies": "multiple requests on same connection" }
        ]
      }
    ]
  },
  "discoveredIssues": []
}

API Contract Verification (CRITICAL for --remote features)

For any CLI feature that integrates with --remote or the hosted API, you MUST verify the actual API contract before implementation:

1. Read ../spikes-hosted/worker/src/index.ts to see which routes exist and their HTTP methods
2. Read the relevant handler in ../spikes-hosted/worker/src/handlers/ to see request/response shapes
3. Read ../spikes-hosted/worker/src/schema.ts for Zod validation requirements
4. Do NOT assume routes exist — the worker only has GET/POST, rarely PATCH/DELETE

When to Return to Orchestrator

• rmcp crate fails to compile on this platform/toolchain
• The rmcp API has changed from what's documented (breaking changes in 0.17)
• A new dependency is needed beyond rmcp and schemars
• Feature requires changes to spike.rs Spike struct that could break other commands
• cargo test reveals failures in existing (non-MCP) tests that aren't caused by your changes