kotlin-android-architecture

name	kotlin-android-architecture
description	Use this skill to statically review Android app architecture correctness: ViewModel lifecycle and scoping across configuration changes, SavedStateHandle persistence across process death, lifecycle-aware Flow collection (repeatOnLifecycle/collectAsStateWithLifecycle/flowWithLifecycle), and unidirectional data flow with a single source of truth. Reads source only; it never runs or instruments the app.
allowed-tools	Read Grep Glob
metadata	{"author":"github: Raishin","version":"0.1.0","updated":"2026-07-21","category":"architecture","lifecycle":"experimental"}

kotlin-android-architecture

Purpose

This skill decides whether Android app architecture is safe to ship. An architecture is safe only when ViewModel state survives configuration changes without leaking a Context/View reference, state that must survive process death is persisted via SavedStateHandle, Flow collection tied to the UI pauses while backgrounded, and state flows down from a single source of truth while events flow up without back-channel mutation.

Trigger conditions

• A user provides ViewModel, SavedStateHandle, or Flow-collection source and asks whether it correctly survives configuration change or process death.
• A user is diagnosing lost state after rotation or backgrounding, a memory leak tied to a ViewModel, or a Flow that keeps running in the background.
• A user asks how to structure state ownership and one-shot events between a ViewModel and its UI.

When not to use

• The concern is Compose recomposition performance/stability or accessibility — route to kotlin-compose-ui-quality-accessibility-agent.
• The concern is measured runtime jank, startup time, ANR, or memory — route to kotlin-android-performance-reliability-agent.
• The concern is security/privacy posture (exported components, storage, network) — route to kotlin-android-security-privacy-agent.
• The concern is coroutine dispatcher selection, cancellation, or context-propagation internals — route to kotlin-coroutines-flow-reliability-agent.
• The task requires running or instrumenting the app on a device — this skill is static-review only.

Lean operating rules

• CRITICAL — a ViewModel that survives configuration change is being asked to hold a reference to an Activity/Fragment/View Context (directly or via a listener) — this outlives the destroyed view and leaks it; require the ViewModel hold no Context/View reference (application context only where unavoidable).
• CRITICAL — state that must survive process death (not just configuration change) but is kept only as a plain ViewModel property, not in SavedStateHandle, is lost on process death; treat this as a defect for any state the product requires to survive backgrounding plus OS reclaim.
• HIGH — collecting a Flow in a bare lifecycleScope.launch { } / collect with no repeatOnLifecycle(STARTED), flowWithLifecycle, or collectAsStateWithLifecycle keeps collecting — and doing whatever work drives it — while the UI is backgrounded; require lifecycle-aware collection at STARTED (or the Compose equivalent) for any Flow tied to UI.
• HIGH — UI state mutated directly from the View/Composable instead of via an event sent up to the ViewModel breaks single-source-of-truth and lets state diverge from what the ViewModel believes; require all mutation flow through the ViewModel.
• HIGH — a ViewModel scoped to the wrong lifecycle owner (e.g. Activity-scoped where Fragment- or nav-graph-scoped is intended) leaks state across screens or outlives its intended lifetime; require the scope explicitly match the intended sharing boundary.
• MEDIUM — SavedStateHandle holding a large or non-trivial object bypasses the Bundle size limits and risks a TransactionTooLargeException; require only small, essential UI state (ids, scroll position, form input) be saved this way.
• MEDIUM — UI state modeled as several independent nullable/boolean fields (loading, error, data all separately nullable) allows impossible or partial states; require a single sealed UI-state hierarchy that makes invalid combinations unrepresentable.
• MEDIUM — a one-shot UI event (navigation, snackbar, toast) modeled as persistent StateFlow state re-fires on configuration change or recomposition; a SharedFlow(replay = 0) is not a safe drop-in fix — it drops any event emitted while no lifecycle-aware collector is actively collecting, silently losing navigation/snackbar events — and a Channel needs explicit buffering/capacity and clear ownership to avoid dropping events or racing with cancellation; require either a durable UI-state representation with an explicit consumed/acknowledged flag, or that the event stream's delivery and lifecycle guarantees (buffering, collector-active timing) be explicitly stated and verified, before recommending an event stream in place of persistent StateFlow state.
• LOW — a dependency crossing in the wrong direction (the domain or data layer importing a ViewModel or UI type) undermines testability and layering; flag any import that crosses the intended UI to domain to data direction.

References

Load these only when needed:

• ViewModel Lifecycle And State Persistence
• Lifecycle-Aware Collection And Unidirectional Data Flow
• Official Sources
• Safety Checklist

Response minimum

• A verdict (pass / pass-with-conditions / block) and the lifecycle scope assumed for each state holder.
• Findings grouped by ViewModel lifecycle, SavedStateHandle/process-death, lifecycle-aware collection, and unidirectional data flow.
• A severity-labelled finding list, each with an evidence-basis label, and safe next actions plus any runtime lifecycle claim needing confirmation.