en un clic
fix-bp-docs
// Audit and fix best practices docs for stale references, duplicates, obsolete content, and formatting issues. Triggers on: fix bp docs, fix best practice docs, audit bp docs.
// Audit and fix best practices docs for stale references, duplicates, obsolete content, and formatting issues. Triggers on: fix bp docs, fix best practice docs, audit bp docs.
Add a new best practice to the appropriate doc. Checks for duplicates, assigns stable IDs, creates new category docs if needed. Triggers on: add best practice, new best practice, add bp, new bp.
"Create an uplift PR that cherry-picks merged PRs from a contributor into a target branch (beta or release). Defaults to broad eligibility; the scope can be narrowed via a free-form description (e.g. 'only automated test and crash fixes'). Triggers on: /uplift, create uplift, uplift PRs."
Review PRs in the configured PR repository for best practices violations. Supports single PR (#12345), state filter (open/closed/all), and auto mode for cron. Triggers on: review prs, review recent prs, /review-prs, check prs for best practices.
Run all preflight checks (format, gn_check, presubmit, build, tests) to make sure the current work is ready for review.
Check if a failing test is a known upstream flake in Chromium's LUCI Analysis database. Provides flakiness statistics, verdict, and recommendation for filter file decisions. Triggers on: check upstream flake, is this test flaky upstream, check luci flakiness, upstream flake check.
Delete local branches whose PRs have been merged upstream. Checks GitHub PR status for each branch. Triggers on: clean branches, delete merged branches, prune branches, branch cleanup.
| name | fix-bp-docs |
| description | Audit and fix best practices docs for stale references, duplicates, obsolete content, and formatting issues. Triggers on: fix bp docs, fix best practice docs, audit bp docs. |
| disable-model-invocation | true |
| allowed-tools | Bash(find:*), Bash(ls:*), Bash(head:*), Bash(git:*), Bash(python3:*), Read, Grep, Glob, Edit |
Audit all best practices documentation files for issues and fix them. This skill
must be run from the brave-core directory.
This skill runs from the brave-core (src/brave) directory. Best practices docs
are at ./docs/best-practices/ and the index is at ./docs/best_practices.md.
Set DOCS_DIR="./docs/best-practices".
Read docs/best_practices.md and every file in $DOCS_DIR/*.md to understand
the full set of docs.
Scan across all docs for rules that cover the same topic. Look for:
When a duplicate is found, keep the version in the more appropriate category file and remove the other. Preserve all anchor IDs on the kept version so existing links don't break.
Do NOT create reference-only stubs that just point to another rule. Either keep the full rule or remove it entirely.
Extract all brave/... file paths from code examples and verify they exist in
src/brave/. For each missing file:
find or GlobSkip paths that are obviously placeholder/illustrative (e.g.,
brave/components/my_feature/my_header.h,
brave/chromium_src/path/to/override.h).
Extract Chromium file paths (e.g., components/omnibox/browser/...,
chrome/browser/ui/...) from code examples and verify they exist in src/. For
each missing file:
Skip paths that are obviously placeholder/illustrative.
Look for references to specific Chromium class names, method names, and other
symbols in code examples. Verify they still exist in the Chromium source
(src/). Update any that were renamed.
Look for references to specific Brave class names, method names, and other
symbols in code examples. Verify they still exist in src/brave/. Update any
that were renamed or removed.
Look for:
../testing-requirements.md)Look for:
--- separators between rules<a id="...">)--- separatorsVerify docs/best_practices.md:
$DOCS_DIR/ are represented in the indexFor each issue found:
After all fixes, run ID validation:
python3 ./script/manage-bp-ids.py --validate
path/to/foo.h), leave it
alone