// Review that new metrics are gated by the same feature flags as similar existing metrics.
| name | metrics-feature-gates |
| description | Review that new metrics are gated by the same feature flags as similar existing metrics. |
| license | Apache-2.0 |
| metadata | {"copyright":"The Kubernetes Authors"} |
Flag: A new metric similar to existing ClusterQueue resource metrics, where it's not obvious that EnableClusterQueueResources (see apis/config/v1beta2/configuration_types.go) controls it.
Ask: Make the feature flag gating explicit in code. If similar metrics are gated, this one should be too.
Write or review Kueue PR release notes. Use when a user asks to draft, refine, validate, or combine release notes for a Kueue pull request, especially when deciding whether the note should be framed as a bugfix, feature, observability improvement, or breaking change.
Review that algorithm comments match the implementation. Use when a comment describes a formula or algorithm and you want to verify it matches what the code actually does.
Review that new CRD fields have complete godoc comments with enum value descriptions.
Review that paired operations and fields that always appear together are encapsulated in a helper or nested struct.
Review that local variables with unnecessarily wide scope are extracted into helper functions.
Review that new feature-gated behavior has explicit gate checks on all reachable code paths.