Exécutez n'importe quel Skill dans Manus
en un clic

Exécutez n'importe quel Skill dans Manus en un clic

Commencer

$pwd:

14-fix-findings

Name: 14 Fix Findings
Author: neohaskell

// Addresses every blocker finding from phases 12 and 13 and re-runs build and tests.

Exécuter dans Manus

$ git log --oneline --stat

stars:346

forks:11

updated:19 mai 2026 à 19:06

SKILL.md

readonly

name	14-fix-findings
description	Addresses every blocker finding from phases 12 and 13 and re-runs build and tests.
kind	leaf
executor	sonnet
model	claude-sonnet-4-6

Fix Findings

Reads the implementation security and performance findings and resolves every blocker.

Inputs

.pipeline/findings-12.json
.pipeline/findings-13.json
docs/architecture/<adr-number>-<slug>.md

Plan

Read both findings files → verify: both load.
Filter to entries with blocker: true → verify: list captured.
Address each blocker with a code edit → verify: every blocker has a corresponding diff.
Re-run nix develop --command cabal build all && nix develop --command cabal test → verify: both pass.

Assumptions:

Only blocker findings (blocker: true) must be fixed in this phase. Non-blockers are tracked but not blocking.
If a fix significantly changes the architecture, escalate to the maintainer for re-review before continuing.
Test files remain immutable.
Boy scout rule applies. When the fix re-opens a file, any pre-existing style debt in that file gets cleaned up in the same diff — unqualified imports, point-free top-levels, wildcard _ params, let..in/where, $, <>/++ for strings, raw String/IO/Either. The rule is scoped to files the fix already touches; nothing else gets reformatted. See ../references/nhcore-context.md#boy-scout-rule.

If any assumption fails, refuse — do not guess.

Steps

Load .pipeline/findings-12.json and .pipeline/findings-13.json.
Collect every entry where blocker: true.
For each blocker, locate the file:line, read the surrounding code, and apply a targeted fix.
Run nix develop --command cabal build all. If it fails, apply one more targeted fix and retry — bounded to a total of 3 attempts (1 initial + 2 retries). If still failing, refuse and surface the build log.
Run nix develop --command cabal test. If it fails, apply one more targeted fix and retry — bounded to a total of 3 attempts (1 initial + 2 retries). If still failing, refuse and surface the test log.
If any fix changes a public type or module boundary, stop and escalate to the maintainer for re-review.
Run python3 .claude/skills/feature-pipeline-preview/scripts/pipeline.py complete 14.

Output

All blockers resolved; build and tests green; phase 14 marked complete.

Refusals

Either findings file missing → refuse: "phase 12 or 13 output missing".
Any blocker has no file:line reference → refuse: "blocker is unactionable".
Build or test still failing after fixes → refuse and surface the failure.

related-skills.json

même dépôt

10-implementation.md

from "neohaskell/NeoHaskell"

Implements the feature per the architecture doc using nhcore-first, NeoHaskell style.

2026-05-19346

03-fix-iter.md

from "neohaskell/NeoHaskell"

Reads build and test logs, identifies the root cause, and edits implementation files to fix it.

2026-05-19346

11-build-loop.md

from "neohaskell/NeoHaskell"

Iterates build and test until both are green, then captures hlint warnings without gating.

2026-05-19346

feature-pipeline-preview.md

from "neohaskell/NeoHaskell"

Use when implementing a new NeoHaskell feature end-to-end — from ADR draft through PR merge — and the work needs the structured 17-phase pipeline with ADR, security and performance reviews (each grounded against feature complexity and the Jess persona), outside-in test design, build loop, and PR/CI handling. Triggers on 'run feature pipeline', 'feature pipeline', 'start pipeline', 'implement feature', 'new NeoHaskell feature', 'implement issue

2026-05-19346

neohaskell-implementer.md

from "neohaskell/NeoHaskell"

NeoHaskell code implementation guide. Use when implementing features, writing tests, build/test loops, or any task requiring NeoHaskell code. Handles pipeline phases 7-9 (tests, implementation, build loop), 12-13 (fix reviews, final build), and 16 (fix bot comments).

2026-05-19346

neohaskell-style-guide.md

from "neohaskell/NeoHaskell"

NeoHaskell coding style reference and enforcement rules. Load when writing, reviewing, or modifying any Haskell code in the NeoHaskell project. Triggers on 'NeoHaskell style', 'NeoHaskell conventions', 'how to write NeoHaskell', 'code style', 'style guide'.

2026-05-19346

package.json

"author": "neohaskell"

"repository": "neohaskell/NeoHaskell"

Ouvrir le dépôt GitHub Voir les dépôts du créateur

$ install --global

$ download --local

Exécuter dans Manus

$ useful --forSOC

Développeurs de logicielsProfessions informatiques et mathématiques15-1252L4

Fix Findings

Reads the implementation security and performance findings and resolves every blocker.

Inputs

.pipeline/findings-12.json

.pipeline/findings-13.json

docs/architecture/<adr-number>-<slug>.md

Plan

Read both findings files → verify: both load.

Filter to entries with blocker: true → verify: list captured.

Address each blocker with a code edit → verify: every blocker has a corresponding diff.

Re-run nix develop --command cabal build all && nix develop --command cabal test → verify: both pass.

Assumptions:

Only blocker findings (blocker: true) must be fixed in this phase. Non-blockers are tracked but not blocking.

If a fix significantly changes the architecture, escalate to the maintainer for re-review before continuing.

Test files remain immutable.

Boy scout rule applies. When the fix re-opens a file, any pre-existing style debt in that file gets cleaned up in the same diff — unqualified imports, point-free top-levels, wildcard _ params, let..in/where, $, <>/++ for strings, raw String/IO/Either. The rule is scoped to files the fix already touches; nothing else gets reformatted. See ../references/nhcore-context.md#boy-scout-rule.

If any assumption fails, refuse — do not guess.

Steps

Load .pipeline/findings-12.json and .pipeline/findings-13.json.

Collect every entry where blocker: true.

For each blocker, locate the file:line, read the surrounding code, and apply a targeted fix.

Run nix develop --command cabal build all. If it fails, apply one more targeted fix and retry — bounded to a total of 3 attempts (1 initial + 2 retries). If still failing, refuse and surface the build log.

Run nix develop --command cabal test. If it fails, apply one more targeted fix and retry — bounded to a total of 3 attempts (1 initial + 2 retries). If still failing, refuse and surface the test log.

If any fix changes a public type or module boundary, stop and escalate to the maintainer for re-review.

Run python3 .claude/skills/feature-pipeline-preview/scripts/pipeline.py complete 14.

Output

All blockers resolved; build and tests green; phase 14 marked complete.

Refusals

Either findings file missing → refuse: "phase 12 or 13 output missing".

Any blocker has no file:line reference → refuse: "blocker is unactionable".

Build or test still failing after fixes → refuse and surface the failure.

14-fix-findings

Fix Findings

Inputs

Plan

Steps

Output

Refusals

Plus depuis ce dépôt

Plus depuis ce dépôt

Fix Findings

Inputs

Plan

Steps

Output

Refusals