arch-check

name	arch-check
description	Check changed feature code against charter architecture rules: layering, cycles, forbidden patterns, names, and size.

arch-check

Run the charter architecture fitness check — Checkpoint 7 (Light Verify), alongside crap-analyzer. Turns the charter's architectural vision from prose into an objective gate: dae_arch.py reads the manifest's architecture: rules and reports violations.

Read-only on the codebase — it reports, it does not fix.

When to use

Checkpoint 7, after the feature's code is implemented and refined. Also useful as a standalone audit (--full) of an existing project.

Not for: change-risk analysis (crap-analyzer); artifact consistency (consistency-check); fixing violations (that is a human/agent decision per violation).

Workflow

Step 0 — Entry gate

Verify the prior checkpoint is complete: run ${PLUGIN_ROOT}/scripts/dae_handoff.py <feature-dir> --through 6. On a non-zero exit, stop and surface the gap to the human.

Verify branch hygiene: run ${PLUGIN_ROOT}/scripts/dae_branch.py <feature-dir>. On a non-zero exit, stop and surface the message to the human — switch branches and re-invoke. The check honors the git.manual: true manifest opt-out.

After the gate passes, show the pipeline breadcrumb: run ${PLUGIN_ROOT}/scripts/dae_progress.py <feature-dir> and present its output to the human — it shows where this checkpoint sits in the DAE pipeline. The breadcrumb is advisory: a non-zero exit or a missing progress.md never blocks the skill. Then create one Codex plan item per workflow step below. See ${PLUGIN_ROOT}/references/progress-indicator.md.

Step 1 — Run the check

Run ${PLUGIN_ROOT}/scripts/dae_arch.py <methodology-root> (add --full for a whole-project audit). If it reports "no architecture: section", tell the user the charter has no machine-readable architecture rules yet and stop.

Step 2 — Present violations

Group the violations by kind (layering first — it is the architectural-vision core). For each, show file:line and the rule. Do not auto-fix.

Step 3 — Triage with the human

For each violation, the human decides: a real break (fix the code), or a rule that no longer fits (amend manifest.architecture — and the charter prose). dae_arch.py exiting non-zero means Checkpoint 7's architecture-fitness exit criterion is unmet until the violations are resolved.

Step 4 — Handoff

Emit a summary per ${PLUGIN_ROOT}/references/handoff-summary.md. checkpoint: 7; the exit_criteria block asserts the architecture-fitness criterion with verified_by: tool and the dae_arch.py exit status as evidence.

References

• Foundation Design — the architecture: manifest section (§2); the Checkpoint Exit Contract (§8)