メニュー
Use when running or preparing a global codebase review pass that produces tasks/review-N-<slug>/ findings; defines the 6-subagent batch workflow and the per-finding output format.
Codex または Claude でインストール この Prompt をコピーして Codex、Claude、または他のアシスタントに貼り付けると、Skill ページを確認してインストールできます。
SOC 職業分類に基づく
Conventions shared by the in-repo binaries (edgion-controller, edgion-gateway, edgion-cli) — project overview, command line / directory / config-path conventions, Core layering conventions, resource system.
KubernetesCenter implementation — K8s Reflector watching, leader election, HA mode, ResourceController lifecycle, status writeback.
ConfigCenter subsystem — ConfCenter trait abstraction, FileSystemCenter and KubernetesCenter implementations, unified Workqueue + ResourceProcessor pipeline.
edgion-controller control plane architecture — overall design, startup/shutdown, Admin API, ConfigCenter, Workqueue, ResourceProcessor, Requeue, CacheServer, ACME service.
Route matching overview — multi-stage pipeline (Listener→Domain→Path→DeepMatch), per-listener isolation, registration flow, atomic swap.
TLS subsystem overview — TLS Store, SNI matching, certificate management, BoringSSL/OpenSSL backend selection.
| name | fully-review |
| description | Use when running or preparing a global codebase review pass that produces tasks/review-N-<slug>/ findings; defines the 6-subagent batch workflow and the per-finding output format. |
Per-feature decision rules and closed-finding log live under 04-review/. This file describes the workflow for spawning a global review pass.
1. Define scope: split src/ into 6 non-overlapping subtrees (e.g., by crate / module cluster).
2. For each subtree, spawn a subagent with these pre-loads:
- skills/04-review/SKILL.md (routing index + closed-findings pointer)
- skills/04-review/CLOSED-FINDINGS.md (skip known false positives)
- skills/04-review/security/iron-rules.md (timing / password / cache-key rules)
- skills/03-coding/01-log-safety.md (data-plane tracing prohibition)
- Relevant topic dirs from 04-review/ matching the subtree content.
3. Each subagent verifies findings by reading cited file:line + grep-checking call sites;
drops speculative, stylistic, or closed items before reporting.
4. Each finding is emitted as a standalone file using the template:
Severity / Location / Summary / Details / Impact / Suggested fix / Notes
5. Collect all finding files into tasks/review-N-<slug>/ and generate INDEX.md
(columns: ID, Severity, Dimension, Title).
6. Cross-check every finding against already-closed findings (recorded one-file-per-finding
under `skills/04-review/<topic>/`; use `grep`/`ls` to find them); findings that match a
closed entry are dropped or annotated "already closed".
Six subtrees: edgion-controller/src/, edgion-gateway/src/runtime/,
edgion-gateway/src/plugins/, edgion-gateway/src/routes/, edgion-common/src/,
and edgion-resources/src/.
| Dimension | Where to load |
|---|---|
| Security | 04-review/security/iron-rules.md, plus topic dirs: auth-timing/, hmac-auth/, oidc/, ssrf/, ip-restriction/ |
| Correctness | 04-review/concurrency/, 04-review/rwlock-unwrap/, 04-review/handler-requeue/ |
| Observability | 04-review/observability/, 03-coding/01-log-safety.md |
| Architecture | 04-review/architecture/ |
| CPU / memory | 04-review/cpu-memory/, 04-review/memory-leak/ |
Closed findings are recorded one-file-per-finding, scattered by topic across the
skills/04-review/ subdirectories; use grep/ls to find them. After each global pass,
record newly closed items as a finding file under the relevant topic directory.