// Review code changes in pull requests or local diffs for S3Mock. Use when asked to review a PR, inspect changes, or provide structured feedback on correctness, conventions, test quality, and documentation. Outputs findings structured as Must fix / Should fix / Nit.
| name | review |
| description | Review code changes in pull requests or local diffs for S3Mock. Use when asked to review a PR, inspect changes, or provide structured feedback on correctness, conventions, test quality, and documentation. Outputs findings structured as Must fix / Should fix / Nit. |
Use this skill when asked to:
Read AGENTS.md (root) and the relevant module AGENTS.md — especially the DO/DON'T, Architecture, and Code Style sections.
Evaluate in this priority order:
INVARIANTS.md.S3Exception constants used — not custom exception classes? See INVARIANTS.md.INVARIANTS.md.Flag as Must fix:
2017-<current year> in every modified filecom.fasterxml.jackson.dataformat.xml.annotation — must use tools.jackson packages in 5.x@Autowired or field injection in production code (see docs/SPRING.md)@Mock/@InjectMocks/@ExtendWith(MockitoExtension::class) in tests — use @SpringBootTest + @MockitoBean (see docs/SPRING.md)var on public API properties (see docs/KOTLIN.md)ServiceTestBase, StoreTestBase, BaseControllerTest, or S3TestBase)?testInfo-based or UUID-based resource names?internal class, AssertJ assertions?givenBucket(testInfo)?See docs/KOTLIN.md for the full list of idioms and anti-patterns to check (null safety, expression bodies, scope functions, isEmpty()/isNotEmpty(), when expressions, naming).
CHANGELOG.md updated for user-facing changes?README.md operations table updated for new S3 operations?Structure feedback as:
INVARIANTS.md constraint violations, missing testsrefactor skill for purely style improvements rather than asking the author to add more code.For each finding, reference the specific AGENTS.md rule, INVARIANTS.md constraint, or AWS API doc.
AGENTS.md.lint skill.refactor skill.CHANGELOG.md is updated if the change is user-facing.CHANGELOG.md check confirmedAGENTS.md — architecture, DO/DON'T, CI gatesINVARIANTS.md — hard constraints; source for Must fix classificationsAGENTS.mddocs/KOTLIN.md — Kotlin idioms and anti-patternsdocs/SPRING.md — Spring Boot patterns, DI, exception handling, testingdocs/TESTING.md — base classes, test conventionsGenerate and update S3Mock project documentation. Use when asked to document code, update CHANGELOG.md, update README.md, update AGENTS.md files, or fix formatting, wording, or style in any existing documentation file. Also invoked at the end of the implement skill workflow.
Implement features, fix bugs, and modify production source code in S3Mock. Use when asked to add functionality, change behavior, or modify source files in server/, integration-tests/, or testsupport/. Not for documentation-only or test-only changes. Orchestrates lint, test, and document skills as part of the complete workflow.
Fix code style issues and ensure linting CI gates pass in S3Mock. Use when ktlint or Checkstyle violations are reported, when asked to fix formatting, or as a required final step after any code change. Runs ktlint for Kotlin source files and Checkstyle for Java and XML files.
Improve code readability, enforce idiomatic Kotlin conventions, and enhance documentation quality in S3Mock without changing behavior. Use when asked to clean up code, improve naming, add KDoc, or align with Kotlin/project idioms. Also invoked by the implement and test skills before adding new code to messy areas.
Write, update, and fix tests in S3Mock. Use when asked to add test coverage, create test cases, fix failing tests, or verify test correctness. Covers unit tests (*Test.kt in server/), controller slice tests (@WebMvcTest), and integration tests (*IT.kt in integration-tests/ against a live Docker container).