elite-standards

name	elite-standards
description	Enforce elite code quality standards for F3 Workout Builder. Use when writing code, reviewing changes, fixing bugs, or creating new features. Keywords: code quality, TypeScript, testing, coverage, lint, types.

Elite Code Standards

This skill enforces the project's strict code quality requirements. Every piece of code must meet these standards before being considered complete.

Core Requirements

1. Zero any Types

Every variable, parameter, and return value MUST be explicitly typed.

// CORRECT
function processExercise(exercise: Exercise): ProcessedExercise {
  const result: ProcessedExercise = transform(exercise);
  return result;
}

// WRONG - Will fail ESLint
function processExercise(exercise: any) {
  // NO!
  const result = transform(exercise);
  return result;
}

2. Explicit Return Types

ALL functions must declare their return type.

// CORRECT
const handlePress = (item: Exercise): void => {
  onSelect(item);
};

// WRONG
const handlePress = (item: Exercise) => {
  // Missing return type!
  onSelect(item);
};

3. 100% Test Coverage

All new code requires comprehensive tests covering:

• Happy path
• Edge cases
• Error handling
• All branches

4. Accessibility Labels

All interactive elements need accessibility attributes:

<Pressable
  accessibilityRole="button"
  accessibilityLabel="Add exercise to workout"
  accessibilityHint="Double tap to add this exercise"
>

Before Completing Any Task

Run the full quality check:

npm run check:all

This runs:

• npm run lint - ESLint with strict TypeScript rules
• npm run format - Prettier formatting
• npm run typecheck - TypeScript compilation
• npm test - All unit tests

Common Pitfalls

1. Inline objects in JSX - Use useMemo or extract to constants
2. Missing useCallback - Wrap event handlers to prevent re-renders
3. Unused imports - Remove immediately, ESLint will error
4. console.log - Remove before commit (security concern)

When This Skill Applies

• Writing new functions or components
• Modifying existing code
• Code review
• Bug fixes
• Refactoring

Always reference checklist.md for the complete verification checklist.

Related Skills & Agents

Skills

• component-dev - Component creation patterns
• zustand-testing - Store testing patterns
• f3-domain - F3 terminology for UI text

Agents

• code-reviewer - Automated quality review
• test-generator - Generate missing tests
• security-auditor - Security vulnerability checks