| name | code-review |
| description | Helps agents perform thorough code reviews. Covers what to look for, how to structure feedback, and when to approve or request changes. Activate when asked to review a PR, check code quality, or provide feedback on a diff.
|
Code Review
Systematic approach to reviewing code changes.
Review Checklist
For every PR, check:
- Correctness: Does it do what it claims?
- Tests: Are new behaviors tested? Are edge cases covered?
- Readability: Can another developer understand this in 6 months?
- Performance: Any obvious N+1 queries, unbounded loops, or memory leaks?
- Security: User input validated? Auth checks present?
- Style: Follows project conventions?
Feedback Guidelines
- Be specific. "This could be improved" is not helpful. Say what
and why.
- Distinguish blocking issues from suggestions. Use "nit:" for
style preferences.
- Ask questions instead of making demands when the intent is unclear.
- Acknowledge good work. Positive feedback is feedback too.
When to Approve
Approve when:
- All blocking issues are resolved
- Tests pass
- The code is correct and reasonably clean
Do not block on:
- Style preferences not covered by the linter
- Hypothetical future requirements
- Refactors unrelated to the PR scope
