// Review staged and unstaged code changes for FastLED coding standards violations, span usage mandates, and example quality. Use after making code changes to ensure compliance.
| name | code-review |
| description | Review staged and unstaged code changes for FastLED coding standards violations, span usage mandates, and example quality. Use after making code changes to ensure compliance. |
| disable-model-invocation | true |
You are a specialized code review agent for FastLED. Review staged and unstaged changes according to strict rules.
git diff --cached to see staged changesgit diff to see unstaged changesThe detailed rules in review-rules.md cover these areas:
| Files | Rules |
|---|---|
src/** | No try-catch, span usage, signed integer overflow, singleton patterns, alignment attributes, performance attributes, unused variables, API unit propagation |
src/** + examples/** | Span usage mandates, Arduino String ban |
examples/** | AI slop detection for new .ino files |
ci/**/*.py | KeyboardInterrupt handling, type annotations |
**/meson.build | No embedded Python, no duplication, config as data |
**/*.h + **/*.cpp | Platform header isolation, file/class name normalization, redundant virtual on override |
tests/** | No threading in mocks, FL_CHECK vs FL_REQUIRE, stack-use-after-scope with LED arrays |
src/platforms/** | Missing platform version guards |
src/** + tests/** | Unnecessary suppression comments |
## Code Review Results
### File-by-file Analysis
- **src/file.cpp**: [no issues / violations found]
- **examples/file.ino**: [status and action taken]
### Summary
- Files reviewed: N
- Violations found: N (categorized)
- Violations fixed: N
- User confirmations needed: N
Fetch CodeRabbit review comments on the current PR, classify each finding, apply fixes for valid issues, and reply to each thread. Use before attempting gh pr merge when CodeRabbit has posted a review. Blocks merge on unresolved threads. Routes security-critical findings to a human.
Generate a structured multi-layer test plan for FastLED changes targeting ESP32. Covers host unit tests, WASM compile checks, platform compile checks, and hardware validation. Use after defining an implementation contract, before writing any code.
Generate a structured implementation contract before making any code changes to FastLED. Defines scope, affected files, API changes, platform impact, risk assessment, and test plan. Use before implementing any feature, bug fix, driver addition, or refactoring.
Review and implement hardware driver code — DMA safety, interrupt correctness, timing constraints, peripheral register usage, channel drivers, and peripheral mock implementations. Use when writing, modifying, or reviewing LED drivers, SPI/I2S/RMT/UART/PARLIO/LCD_CAM peripherals, GPIO configuration, or peripheral mock code.
Scan all CI builds and tests, find failures, fetch error logs, and fix the code. Prioritizes unit tests, example tests, then uno, attiny85, esp32s3, esp32c6, teensy41. Use when CI is red and you need to diagnose and repair build/test failures.
Debug GitHub Actions build failures by fetching and analyzing workflow logs. Use when CI/CD pipelines fail and you need to identify the root cause.
