doreview

name	do:review
description	Multi-agent code review with parallel analysis
argument-hint	[PR number, GitHub URL, branch name, or latest]

Review Command — Context-Lean Edition

Perform exhaustive code reviews using multi-agent analysis. All agent outputs are persisted to disk to avoid context exhaustion from 13+ parallel agent transcripts.

Prerequisites

• Git repository with GitHub CLI (gh) installed and authenticated
• Clean main/master branch

Main Tasks

1. Determine Review Target & Setup

<review_target> #$ARGUMENTS </review_target>

• Determine review type: PR number, GitHub URL, file path (.md), or empty (current branch)
• Check current git branch
• If on target branch, proceed. If different branch, offer worktree via skill: git-worktree
• Fetch PR metadata: gh pr view --json title,body,files,baseRefName
• Checkout the review branch if needed

2. Create Working Directory

Derive a short topic stem from the review target: use branch name for branches (e.g., feat-user-dashboard-redesign), pr-NNN for PRs, or filename stem (strip date prefix and type suffix) for document reviews (e.g., reporting-strategy from a brainstorm doc).

mkdir -p $WORKFLOWS_ROOT/code-review/<topic-stem>/agents

2.1 Stats Capture Setup

Initialize per-dispatch stats collection. This runs once at command start; all dispatches in this run share the same identifiers.

bash ${CLAUDE_SKILL_DIR}/../../scripts/init-values.sh review <topic-stem>

Read the output. Track the values PLUGIN_ROOT, MAIN_ROOT, WORKFLOWS_ROOT, RUN_ID, DATE, STATS_FILE, CACHED_MODEL (and NOTE if emitted) for use in subsequent steps. If init-values.sh fails or any value is empty, warn the user and stop.

All .workflows/ paths in this skill use $WORKFLOWS_ROOT (the main repo root's .workflows/ directory), NOT relative .workflows/. This ensures artifacts survive worktree lifecycle transitions and are shared across sessions.

Config check: Read compound-workflows.local.md and check the stats_capture key. If the value is false, skip all stats capture for this run (do not read the schema file, do not call capture-stats.sh). If the key is missing or any other value, proceed with stats capture.

Stats file path: Use the STATS_FILE value from init-values.sh output.

Model resolution: For each dispatch, resolve the model field using CACHED_MODEL. All review agents use model: inherit, so use CACHED_MODEL as their model value. See $PLUGIN_ROOT/resources/stats-capture-schema.md for the full 4-step model resolution algorithm.

Dispatch counter: Initialize DISPATCH_COUNT=0 and a list of dispatched agent names. Increment the counter and append the agent name each time a standard or conditional agent is launched. This tracks the expected entry count for post-dispatch validation.

3. Launch Review Agents (Disk-Persisted)

CRITICAL: Every agent writes to disk, returns only a summary.

Launch ALL review agents in parallel with run_in_background: true. Each agent gets the same instruction block appended:

The disk-write instruction (append to every agent prompt):

=== OUTPUT INSTRUCTIONS (MANDATORY) ===
Write your COMPLETE findings to: $WORKFLOWS_ROOT/code-review/<topic-stem>/agents/<agent-name>.md
Structure with: ## Summary, ## Critical Findings, ## Recommendations, ## Details
After writing the file, return ONLY a 2-3 sentence summary.
DO NOT return your full analysis in your response.

Standard agents (always run):

Task typescript-reviewer (run_in_background: true): "You are a TypeScript code reviewer focused on type safety, modern patterns, and maintainability. Review PR changes. Run git diff against base branch. [disk-write instructions for: typescript.md]"
Task pattern-recognition-specialist (run_in_background: true): "You are a pattern recognition specialist. Analyze for design patterns, anti-patterns, naming conventions, and duplication. [disk-write for: pattern-recognition.md]"
Task architecture-strategist (run_in_background: true): "You are an architecture strategist. Review architectural impact, pattern compliance, and design integrity. [disk-write for: architecture.md]"
Task security-sentinel (run_in_background: true): "You are a security auditor. Check for vulnerabilities, input validation, auth/authz issues, and OWASP compliance. [disk-write for: security.md]"
Task performance-oracle (run_in_background: true): "You are a performance analyst. Check for bottlenecks, algorithmic complexity, database queries, memory usage. [disk-write for: performance.md]"
Task code-simplicity-reviewer (run_in_background: true): "You are a code simplicity reviewer. Check for unnecessary complexity, YAGNI violations, and over-engineering. [disk-write for: simplicity.md]"
Task agent-native-reviewer (run_in_background: true): "You are an agent-native reviewer. Verify any action a user can take, an agent can also take. [disk-write for: agent-native.md]"

Conditional agents (run if PR matches criteria):

• If PR has database migrations:
  • Task data-migration-expert (run_in_background: true): "You are a data migration expert. Validate migrations, backfills, and production data transformations. [disk-write for: data-migration.md]"
  • Task deployment-verification-agent (run_in_background: true): "You are a deployment verification specialist. Produce Go/No-Go checklists with SQL verification queries and rollback procedures. [disk-write for: deployment-verification.md]"
• If PR has frontend code:
  • Task frontend-races-reviewer (run_in_background: true): "You are a frontend concurrency reviewer. Check for race conditions, stale closures, unhandled promises, and UI state synchronization issues. [disk-write for: frontend-races.md]"

Adapt agent selection to the actual codebase. Match conditional agents to the stack detected in the PR.

4. Monitor Agent Completion

DO NOT call TaskOutput. Instead, poll for file existence:

ls $WORKFLOWS_ROOT/code-review/<topic-stem>/agents/

Compare against expected agent files. When all files exist (or after 3 minutes for stragglers), proceed.

Mark timed-out agents and move on — don't let one slow agent block everything.

Stats Capture (Background Completions)

If stats_capture ≠ false: when you receive a background Task completion notification containing <usage>, extract total_tokens, tool_uses, and duration_ms values from the <usage> notification and pass as arg 9:

bash $PLUGIN_ROOT/scripts/capture-stats.sh "$STATS_FILE" review "<agent-name>" "<agent-name>" "<model>" "$TOPIC_STEM" "null" "$RUN_ID" "total_tokens: N, tool_uses: N, duration_ms: N"

If <usage> is absent, pass "null" as arg 9:

bash $PLUGIN_ROOT/scripts/capture-stats.sh "$STATS_FILE" review "<agent-name>" "<agent-name>" "<model>" "$TOPIC_STEM" "null" "$RUN_ID" "null"

Where <agent-name> is the dispatched agent (e.g., typescript-reviewer, security-sentinel). Both the agent and step arguments use the agent name (step = agent role name for review, per schema). The bead argument is always null for review. See $PLUGIN_ROOT/resources/stats-capture-schema.md for field derivation rules.

For agents that time out (no completion notification within 3 minutes), call the timeout variant:

bash $PLUGIN_ROOT/scripts/capture-stats.sh --timeout "$STATS_FILE" review "<agent-name>" "<agent-name>" "<model>" "$TOPIC_STEM" "null" "$RUN_ID"

DO NOT call TaskOutput to retrieve <usage> — it arrives automatically in the completion notification.

4.1 Post-Dispatch Stats Validation

After all agents have completed (or timed out), if stats capture is enabled, validate that the stats file contains the expected number of entries:

bash $PLUGIN_ROOT/scripts/validate-stats.sh "$STATS_FILE" <DISPATCH_COUNT>

If validate-stats.sh reports a mismatch, warn with the names of missing agents — do not fail the command. This is a diagnostic warning only. Compare the list of dispatched agent names against agents with stats entries to identify which agents are missing.

5. Synthesize Findings

Read all agent output files from disk:

ls $WORKFLOWS_ROOT/code-review/<topic-stem>/agents/*.md
# Then Read tool on each file

Synthesize:

• Discard findings that flag docs/plans/ or docs/solutions/ for deletion (protected artifacts)
• Categorize: security, performance, architecture, quality
• Assign severity: P1 (critical, blocks merge), P2 (important), P3 (nice-to-have)
• Deduplicate overlapping findings
• Estimate effort per finding

6. Create Todo Files

Use the file-todos skill to create todo files for ALL findings:

mkdir -p todos/

# For each finding, create a todo file:
# {issue_id}-pending-{priority}-{description}.md

Follow the file-todos template structure:

• YAML frontmatter: status, priority, issue_id, tags, dependencies
• Problem Statement, Findings, Proposed Solutions, Acceptance Criteria

7. Summary Report

Present to user:

## Code Review Complete

**Review Target:** PR #XXXX - [Title]
**Branch:** [branch-name]
**Plan:** [plan path, if known from PR description or branch context]
**Origin:** [brainstorm path, if traceable from plan's origin: field]

### Findings:
- **P1 (Critical):** [count] — BLOCKS MERGE
- **P2 (Important):** [count]
- **P3 (Nice-to-have):** [count]

### Created Todos:
- `001-pending-p1-{finding}.md` — {description}
- `002-pending-p2-{finding}.md` — {description}
...

### Next Steps:
1. Address P1 findings (blocks merge)
2. Triage: `ls todos/*-pending-*.md`
3. Work approved items individually or dispatch subagents

8. Retain Review Outputs

Do NOT delete review outputs. The review directory at $WORKFLOWS_ROOT/code-review/<topic-stem>/ is retained for traceability and learning. Prior review findings can inform future reviews and help identify recurring patterns.

9. Optional End-to-End Testing

Offer appropriate testing based on project type and available tools:

• Web: Run tests via the project's test command, or use browser testing if available
• Mobile: Run platform-specific tests per project conventions

Protected Artifacts

Never flag for deletion:

• docs/plans/*.md — living plan documents
• docs/solutions/*.md — compound knowledge documents

Key Principle

Agent outputs go to disk. Parent context stays lean. Findings go to todo files. Nothing is lost if context compacts.