no-mistakes

name	no-mistakes
description	Core: TS/JS module graph (imports, dependents, exports, test impact, Playwright, React, queue/server, fetches, lockfile, no-mistakes checks). Also: CI-workflow, Terraform/OpenTofu, and Swift graphs. Prefer over rg when a question spans >2 workspace dirs or >5 import hops.
allowed-tools	Bash(no-mistakes:*) Bash(rg:*) Read Glob

No Mistakes

Use no-mistakes before rg when the question is structural: what a TS/JS file imports, who imports it, what it exports, which tests are related, whether a queue job is connected, which server route owns an endpoint, what a Next.js route fetches, or what React traits a component has.

Scope

Core: TypeScript/JavaScript module graphs — imports, dependents, exports, test impact, Playwright coverage, React traits, queue/server routes, Next.js fetches, lockfile diffs, and no-mistakes check rules.

Adjacent graph domains: Dotnet/C# test-impact edges participate in the canonical graph via configured tests.dotnet.projects. no-mistakes ci — GitHub Actions workflow graphs · no-mistakes infra — Terraform/OpenTofu resource graphs · no-mistakes swift — Swift package graphs.

When To Reach For It

✅ Use no-mistakes when the question spans >2 workspace dirs, involves

5 import hops, or requires transitive test-impact across a large graph.

⚡ Use rg for: exact call lines or text content (comments, strings, prose). For structural graph questions outside TS/JS, see Command Selection: .yml → ci · .tf → infra · .swift → swift · Rust binary CI impact → --relationship ci · CSS/JSON asset imports → --relationship asset. Go source files have no graph domain — use rg. For "what directly imports this one file?" in a single directory, no-mistakes importers <file> is faster than a full graph walk.

Pre-implementation: for existing TS/JS files, run the appropriate test planner before editing to discover affected tests first (for new files, rerun after creating them):

• Vitest: no-mistakes tests plan vitest --changed-file <file> --format paths
• Playwright (route/page changes): no-mistakes tests plan playwright --changed-file <file> --format paths

See references/tests.md. For high-signal multi-command workflows around UI selectors, selector-root expansion, named-export impact, workflow/static-analysis changes, diff test impact planning, API response-shape fanout, package entrypoints, shared-helper dependent tests, deleting a test, and queue enqueue call disposition, see references/impact-recipes.md.

Common Failure-Mode Recipes

Use these when the task sounds like a known review failure, not just a generic graph question.

When you add a new workspace package: verify both code importers and owning manifests before pushing.

# Direct files that import the new package entrypoint.
no-mistakes dependents ts-shared/feed-capabilities/index.mts --relationship import --relationship workspace --depth 1 --format paths

# package.json files that already declare the package edge.
no-mistakes dependents ts-shared/feed-capabilities/index.mts --relationship package --format json

Then compare the direct importer files with each file's nearest package.json. Every package that imports the workspace entrypoint should declare the dependency directly.

When you add a hook that needs context to an existing component: find render and test hosts before editing, especially for hooks such as useRouter, usePathname, or providers required by app context.

no-mistakes react usages web/components/news/news-item-actions.tsx#NewsItemActions --format json
no-mistakes tests plan vitest --changed-file web/components/news/news-item-actions.tsx --format paths

Check the returned call sites, stories, and tests for hosts that render the component without the new context. If a parent component is the actual test entry, run react usages on that parent too.

When you add fire-and-forget work around a suppression option: first find callers structurally, then grep exact option literals and verify each bypassed invariant is rebuilt where needed.

no-mistakes call-sites backend/services/urls/add-url.mts addUrl --format json
rg -n 'addUrl\(|skipCreatedEvents' backend/

no-mistakes does not model option propagation. Use the call site report to scope the review and rg to inspect exact argument objects such as skipCreatedEvents: true.

Command Selection

Question	Tool
What does this file transitively import?	no-mistakes dependencies <file>
What runtime modules can a Playwright route conservatively reach?	no-mistakes dependencies <route-file> --relationship route-import
Which files are affected by touching this file?	no-mistakes dependents <file>
Which files directly import this one file? (fast)	no-mistakes importers <file>
Which files import this named export?	no-mistakes dependents <file>#SYMBOL
What does this file export, and who imports each export?	no-mistakes exports-of <file>
Is this export still used anywhere? (yes/no)	no-mistakes dead-exports <file> [NAME...]
Where is this function called, and with what argument shapes?	no-mistakes call-sites <file> SYMBOL
Do all imports in this file resolve?	no-mistakes resolve-check <file>
What must I update before changing this function signature?	no-mistakes symbols <file> --mode signature-impact --symbol SYMBOL --format json
What multi-step recipe fits a UI selector, selector-root, named export, workflow/static-analysis, diff test impact, API-shape fanout, package entrypoint, shared-helper test discovery, test deletion, or queue call-disposition question?	Read references/impact-recipes.md
Which tests should rerun for everything changed in a diff?	no-mistakes tests plan vitest --from-git-diff <base>...<head> --format paths
Which tests should rerun?	no-mistakes tests plan vitest --changed-file <file> --format paths
Which tests should rerun? (lower-level fallback)	no-mistakes dependents <file> --test vitest --format paths
Why was this test selected?	no-mistakes tests why <test> --plan plan.json
What does this module export/import?	no-mistakes symbols <file> --include both
Which packages/specifiers are directly imported by source files?	no-mistakes import-usages --root <root> --filter 'src/**' --format json
What React traits does this component have?	no-mistakes react analyze <glob>
Does this component tree call fetch?	no-mistakes react check <glob> --assert-no-fetch
Which callsites render this component, and with what props?	no-mistakes react usages <file>#SYMBOL
Where is this test id (e.g. data-pw) used across source and tests?	no-mistakes data-pw <value>
Which cache/pubsub/queue effects does this entry reach?	no-mistakes effects <kind> --entry <file>
Which server components/pages render this component (RSC)?	no-mistakes rsc-callers <component-file>
How do existing entries register in this registry file?	no-mistakes registry-extension <registry-file>
Structural blast-radius ("which .tsx have onClick without cursor-pointer")?	ast-grep directly (see references/limits-and-fallbacks.md)
Are all App Router routes/selectors covered by Playwright?	no-mistakes playwright check
Which Playwright tests cover this page/component?	no-mistakes playwright related <file>
What does this Playwright test assert?	no-mistakes playwright tests <test-file>
Which API calls does this Next.js route make?	no-mistakes fetches <route-or-file>
Which packages changed between two lockfile refs?	no-mistakes lockfile diff --base <ref>
Which CI workflows/jobs does this changed file trigger, and with what permissions?	no-mistakes ci impact <file> --format json
Which workflows define or reference this env var?	no-mistakes ci env <VAR> --format json
What local validation commands should I run for these changed files?	no-mistakes impacted-checks <file...> --format paths
Which queue producer/worker files are connected?	no-mistakes queues related <file>
Are queue producers/workers unmatched?	no-mistakes queues check
What server routes exist?	no-mistakes server routes
Which server route files are related?	no-mistakes server related <file>
Raw queue/server edges for debugging	no-mistakes queues edges [file] / no-mistakes server edges [file]
Which Terraform/OpenTofu resources reference this resource?	no-mistakes infra resource-refs <type>.<name>
What outputs does this Terraform module export and who consumes them?	no-mistakes infra outputs <module-dir>
Which tests cover this .tf file?	no-mistakes infra test-for <tf-file>
Which Swift files import this file/type?	no-mistakes swift importers <file>
Which dotnet tests should rerun?	no-mistakes tests plan dotnet --changed-file <file> --format paths
Which Swift test targets cover this file?	no-mistakes swift test-targets <file>
Run configured project checks in parallel	no-mistakes check
What edge kinds are supported?	Read references/decision-tree.md or https://github.com/jonathanong/no-mistakes/blob/main/docs/graph-edges.md
Plain text, comments, log messages, exact call lines	rg

Quick Workflow

# Machine-readable graph query
no-mistakes dependents src/utils.mts --root /path/to/project --format json

# Test selection (preferred over dependents --test)
no-mistakes tests plan vitest --changed-file src/utils.mts --format paths
no-mistakes tests plan playwright --changed-file web/app/users/page.tsx --format paths

# Explain why a test was selected
no-mistakes tests why tests/users.test.mts --plan plan.json

# Public API and imports
no-mistakes symbols src/api.mts --include both --format json
no-mistakes import-usages --root . --filter 'src/**' --format json
no-mistakes symbols src/api.mts --mode signature-impact --symbol handler --format json

# Playwright coverage gate before finishing Next.js / Playwright work
no-mistakes playwright check --json
no-mistakes playwright related web/app/users/page.tsx --json

# Page-to-API coupling
no-mistakes fetches web/app/users/page.tsx --format json

# Lockfile diff (integrates with tests plan)
no-mistakes lockfile diff --base origin/main --format json

# Queue and server graph checks
no-mistakes queues check --format json
no-mistakes server routes --format json

Prefer --format json for agent parsing and --format paths for command substitution. Every command accepts root-global --timings; use --verbose-timings when deterministic discovery/read/parse/resolver/graph/ traversal/output work counts are needed. Both are stderr-only, verbose implies timings, and parallel phase lines are explicitly non-additive. Ordinary runs do not start diagnostic clocks. impacted-checks reuses one in-memory graph across configured test frameworks.

All analysis invocations share a per-user machine-wide lock. By default, --lock-timeout 30 waits up to 30 seconds to acquire it and --timeout 30 allows 30 seconds of execution after acquisition. Use --fail-on-lock when an agent should fail immediately instead of queueing; use 0 to disable either CLI timeout. Lock waits are silent, failures go to stderr, and successful JSON output is unchanged. The async Node API accepts timeout, lockTimeout, and failOnLock with the same semantics; 0 or null disables a Node timeout, and failures reject the Promise.

For repeated graph/symbol/playwright/project queries in the same process, prefer analyzeProject({reports:[…]}) from the async Node API documented at https://github.com/jonathanong/no-mistakes/blob/main/docs/node-api.md — it shares one request-scoped analysis dataset and one graph build per normalized effective plan and file universe across all requested reports. Note: analyzeProject does not support testsPlan, fetches, or lockfileDiff; call those dedicated Node API functions directly.

Graph Options

dependencies, dependents, and related support:

• --root <PATH> for the project root.
• --tsconfig <FILE> for path aliases; pass this explicitly in monorepos.
• --depth <N> to limit traversal depth.
• --filter <GLOB> to include only matching files; repeatable.
• --target-module <GLOB> to include only matching external module nodes (useful with --relationship package).
• --test vitest|playwright|cargo|dotnet|swift to filter to test files.
• --relationship import|import-static|import-dynamic|import-type|import-require|route-import|workspace|package|test|route|queue|md|ci|http|process|asset|react|dotnet|swift|terraform|all.
• --direction deps|dependents|both for queues related and server related.
• --format json|md|yml|paths|human, --json, root-global --timings / --verbose-timings (stderr), and --jobs.

FILE#SYMBOL works only for dependents/related, not dependencies. Namespace imports match all symbols; use rg on returned files to confirm exact member usage.

When To Read References

• references/decision-tree.md: choosing commands, relationships, filters, and outputs.
• references/dependencies.md: full dependencies reference.
• references/dependents.md: full dependents/related reference and FILE#SYMBOL behavior.
• references/impact-recipes.md: multi-command recipes for React selector impact, selector-root expansion, TS helper impact, workflow/static-analysis changes, diff test impact planning, API response-shape fanout audits, package entrypoint/direct-subpath reports, shared-helper dependent test discovery, pre-deletion test coverage checks, and queue enqueue call-disposition audits.
• references/symbols.md: full symbols reference.
• references/lightweight-queries.md: full importers, exports-of, dead-exports, call-sites, and resolve-check reference.
• references/tests.md: full tests plan/why reference and testPlan config.
• references/playwright.md: full playwright command reference.
• references/monorepo-resolution.md: tsconfig paths and workspace packages.
• references/limits-and-fallbacks.md: unsupported forms and rg fallbacks.
• Upstream repository docs (not vendored with this skill): the docs/ tree at https://github.com/jonathanong/no-mistakes/tree/main/docs — see the agent-guide, cli, graph-edges, rules, eslint-rules, and configuration pages there.

Hard Limits

• baseUrl-only imports are not resolved; use compilerOptions.paths.
• Dynamic import() and require() are tracked only with literals.
• route-import is deliberately conservative: it includes runtime static imports/re-exports and literal dynamic imports inside functions, but excludes type-only imports, require(), and computed dynamic imports. Use route for URL-route, Playwright route-test, and Next.js layout edges instead.
• route-import is explicit opt-in. Omitted relationships and all keep the standard call-pruned graph so test impact and dependency checks do not widen.
• Bare external specifiers such as react are terminal module nodes; their node_modules sources are not parsed. Node built-ins such as node:path remain excluded from module nodes.
• Graph tools answer file/symbol relationships, not exact call locations.
• Dynamic queue names, route paths, fetch URLs, and selectors should be made static when agent-readable analysis is required.
• Selector text edges are approximate; exact configured test ID selector edges are stronger evidence.
• Non-TS/JS files are not walked for import edges; use rg for Go, Rust, CSS, JSON.
• tests plan works without testPlan in .no-mistakes.yml (uses default direct + dependencies groups). Configure testPlan to add environments, custom limits, coverage groups (Playwright only), and global-config triggers.