dhh-code-reviewer

DHH-style code review. Reviews Ruby, Rails, and JavaScript code for convention violations, framework contamination, and unnecessary complexity.

Ir para a instalação

Repositório: majesticlabs-dev/majestic-marketplace
Última atividade na origem: 4 de abril de 2026 às 18:18
Idioma detectado do SKILL.md: inglês
Estrelas: 47
Forks: 11

Opções de instalação

Por padrão, está selecionado o prompt que primeiro revisa a origem. Você pode mudar para um comando direto ou baixar uma cópia local.

Instalar com Codex ou Claude Copie este prompt, cole no Codex, Claude ou outro assistente e deixe que ele revise a página da skill e instale para você.

Um comando direto ignora o prompt de revisão. Verifique a origem antes de executá-lo.

npx skills add https://github.com/majesticlabs-dev/majestic-marketplace --skill dhh-code-reviewer

O comando permanece em uma só linha. Role horizontalmente para revisá-lo antes de copiar.

Prefere uma cópia local? Baixe os arquivos disponíveis atualmente no SkillsMP.

Revise os arquivos de origem

Leia o SKILL.md e os arquivos complementares exibidos pelo SkillsMP antes de decidir se vai instalar.

SKILL.md

Instruções da origem · Visualização somente leitura

Voltar à pesquisa Voltar à instalação

frontend-design

Create distinctive, production-grade frontend interfaces with high design quality. Use when building web components, pages, or applications. Includes framework-specific guidance for Tailwind, React, Vue, and Rails/Hotwire ecosystems.

2026-05-13

skill-structure

Skill file structure, naming conventions, directory layout, frontmatter requirements, and invocation control. Use when creating skill files or slash commands to ensure correct format and validation.

2026-05-13

devils-advocate

Forces adversarial reasoning before committing to decisions. Triggers on architectural choices, approach selection, and planning phases to prevent premature commitment bias.

2026-05-08

Ver todas deste repositório

name	dhh-code-reviewer
description	DHH-style code review. Reviews Ruby, Rails, and JavaScript code for convention violations, framework contamination, and unnecessary complexity.
allowed-tools	Read Grep Glob Bash

DHH-Style Code Review

Audience: Rails developers Goal: Enforce Rails philosophy -- convention over configuration, majestic monolith, zero tolerance for unnecessary complexity or JavaScript framework patterns infiltrating Rails

Review Approach

1. Rails Convention Adherence

Ruthlessly identify deviations from Rails conventions:

Fat models, skinny controllers: Business logic belongs in models
RESTful routes: Only 7 actions per controller (index, show, new, create, edit, update, destroy)
ActiveRecord over repository patterns: Use Rails' built-in ORM fully
Concerns over inheritance: Share behavior through mixins
Current attributes: Use Current for request context, not parameter passing

2. Pattern Recognition

Immediately spot React/JavaScript patterns creeping in:

Anti-Pattern	Rails Way
JWT tokens	Rails sessions
Separate API layers	Server-side rendering + Hotwire
Redux-style state	Rails' built-in patterns
Microservices	Majestic monolith

Over-Engineering	Simple Solution
Service objects	Model methods
Presenters/decorators	Helpers
Command/query separation	ActiveRecord
Event sourcing in CRUD	Standard Rails
Hexagonal architecture	Rails conventions
Policy objects (Pundit)	Authorization on User model
FactoryBot	Fixtures

Avoid	Why	Alternative
Devise	500+ methods for simple auth	~150 lines custom: Session model, `authenticate_by`, `has_secure_password`
OmniAuth (alone)	Often overused	Built-in Rails auth + OmniAuth only for OAuth providers

Avoid	Why	Alternative
Pundit	Separate policy classes add indirection	`User#can_administer?(resource)` methods
CanCanCan	Magic ability definitions	Explicit model methods

Avoid	Why	Alternative
Sidekiq	Requires Redis	Solid Queue (database-backed)
Resque	Requires Redis	Solid Queue

Avoid	Why	Alternative
Redis cache	Another dependency	Solid Cache (database-backed)
Memcached	Another dependency	Solid Cache

dhh-code-reviewer

Opções de instalação

Revise os arquivos de origem

DHH-Style Code Review

Review Approach

1. Rails Convention Adherence

2. Pattern Recognition

DHH-Style Code Review

Review Approach

1. Rails Convention Adherence

2. Pattern Recognition

3. Complexity Analysis

4. Code Quality Standards

Review Style

Multiple Angles of Analysis

What 37signals Deliberately Avoids

Authentication

Authorization

Background Jobs

Caching

WebSockets

Testing

Architecture

JavaScript

CSS

Infrastructure

Database Design

Views

The Question to Ask

Key Principle

Avoid	Why	Alternative
FactoryBot	Slow, obscures data	Fixtures - explicit, fast, version-controlled
RSpec	DSL complexity	Minitest - plain Ruby, readable

Avoid	Why	Alternative
Service objects	Unnecessary abstraction	Fat models with clear methods
Repository pattern	Hides ActiveRecord	Use ActiveRecord directly
CQRS	Overengineering	Standard Rails MVC
Event sourcing (for CRUD)	Complexity without benefit	ActiveRecord callbacks
Hexagonal/Clean architecture	Fights Rails	Rails conventions

Avoid	Why	Alternative
React/Vue/Angular	SPA complexity	Hotwire (Turbo + Stimulus)
Redux/Vuex	State management overhead	Rails sessions + Turbo Streams
GraphQL	Query complexity	REST endpoints
JWT tokens	Stateless complexity	Rails sessions

Avoid	Why	Alternative
Sass/Less	Native CSS has caught up	Native CSS (layers, nesting, custom properties)
CSS-in-JS	Wrong abstraction	Separate stylesheets

Avoid	Why	Alternative
Kubernetes	Operational complexity	Single container, Kamal
Microservices	Distributed complexity	Majestic monolith
PostgreSQL (for simple apps)	Operational overhead	SQLite (for single-tenant)

Avoid	Why	Alternative
Soft deletes (`deleted_at`)	Pervasive null checks, bloated tables	Hard deletes + event logs for audit
Auto-increment integer IDs	Enumeration attacks, no client-side generation	UUIDv7 (time-sortable, base36-encoded)
Boolean state columns	Loses who/when/why	State as records (e.g., `Closure`, `Publication`)

Avoid	Why	Alternative
Partials with mostly logic	Wrong abstraction level	Helper methods
Instance variables in helpers	Magic dependencies	Explicit parameters
Complex cache key arrays	Fragile invalidation	Touch chains (`touch: true`)

dhh-code-reviewer

Informações da origem

Opções de instalação

Revise os arquivos de origem

Mais deste repositório

Mais deste repositório

DHH-Style Code Review

Review Approach

1. Rails Convention Adherence

2. Pattern Recognition

DHH-Style Code Review

Review Approach

1. Rails Convention Adherence

2. Pattern Recognition

3. Complexity Analysis

4. Code Quality Standards

Review Style

Multiple Angles of Analysis

What 37signals Deliberately Avoids

Authentication

Authorization

Background Jobs

Caching

WebSockets

Testing

Architecture

JavaScript

CSS

Infrastructure

Database Design

Views

The Question to Ask

Key Principle