sensei-reflect

name	sensei-reflect
description	Run a post-merge or post-session reflection to capture what was learned and identify what to practice next. Use after a PR is merged, after a bug is fixed, or at the end of a coaching session. Keep it short enough to review in two minutes.

Reflection

Capture what was learned and identify a single skill to practice deliberately next time.

Philosophy

Experience density is not just about writing more code. It is about extracting learning from each piece of code written.

Without reflection, the same mistakes repeat. With it, each PR builds toward a specific, named skill. The developer begins to see their own growth.

This is also where patterns in feedback become visible. If the same gap appears across three PRs, that is a development priority — not a one-off comment.

Questions

Ask these in order, one at a time. Let the developer answer in their own words before asking the next question. Never paste the full list into the conversation. Do not produce the reflection summary until the sequence is complete.

Start with:

What was the hardest part of this change to reason about?

Not the hardest to write — the hardest to think through.

After each answer, ask the next unanswered question from this sequence:

1. What was your first approach, and why did you change it?
   [If they did not change it, why not? Were you confident or did you push through uncertainty?]

2. What were the two main approaches you considered at the key decision point in this change,
   and what made you choose this one?
   [If you did not face a decision point: what would have changed your approach?]

3. What evidence made you comfortable shipping this?
   [Tests, logs, manual checks, reviewer confidence, or a constraint that made the risk acceptable]

4. Did this change touch any security-sensitive surface?
   [Sign-in, permissions, secrets, user data, customer account data, external input, logs, background jobs, or admin tools. If yes, what proved it was controlled?]

5. What did the review catch that you missed?
   - Was it a code smell?
   - A pattern mismatch?
   - A missing test case?
   - A logic error?
   - Something you did not know?

6. What would you do differently if you started this over?
   [Be specific — not "I'd write better tests" but "I'd isolate the permission logic from the handler"]

7. What specific skill do you want to practice in the next PR?
   [Choose one: debugging discipline, DRY, responsibility design, pattern alignment, test quality,
   security awareness, PR communication, tradeoff reasoning, reading existing code before writing]

8. Is there a concept from this change you still do not feel confident about?
   [If yes, what would help: a focused read, a pair session, or another PR in the same area?]

Output format

Keep this brief. A reflection that takes ten minutes to read is not used.

---
## TLDR
[Sentence 1: what this PR was about and the main thing learned]
[Sentence 2: the one habit to carry forward]
---

**PR / Task:** [Title]

### The main lesson
[One or two sentences in plain English — no jargon, understandable by anyone]

### What to practice next
**Skill:** [One named skill]
**Watch for this:** [The specific behavior or moment in the next PR where this skill applies]

### What landed well
[One or two specific things that showed good judgment — never vague, never skipped]

### Trade-off to remember
[The main option chosen, what it cost, and why it was acceptable — or "none named"]

### Security
[No security-sensitive surface / Surface touched and controlled / **Open concern: [name it]**]

### Open question
[Anything still unresolved — a concept, a decision, or a gap in understanding. "None" is a valid answer.]

### Suggested next challenge
[A specific type of task or code area that would develop the target skill]

Rules

• Do not skip this step even when the PR went smoothly. Clean PRs have lessons too — often about what was avoided.
• Keep the output short enough to review in two minutes.
• Make the learning summary understandable to someone who did not read the diff.
• Link "what to practice next" to a specific upcoming task or PR when possible.
• If the same gap appears across two or more reflections, name it as a development focus — not a coincidence.
• If the developer had a significant confusion during this cycle, note it separately for the senior engineer to discuss.
• The goal is one concrete thing to practice — not a long improvement list.