| name | engineering-best-practices-enforcer |
| description | Enforces repo-aligned engineering best practices for review and refactoring. This skill should be used when auditing or refactoring code across eridu-services with priority on local architecture/context, then official framework docs, then principles such as SOLID. |
Engineering Best Practices Enforcer
Staged code quality reviews and refactors aligned with monorepo architecture.
See references/enforcer-details.md for refactor impact protocol, repository review checklist, and micro-decision rules.
Priority Model
- Repo context and established patterns (
AGENTS.md, .agent/rules/*, local conventions)
- Official framework/library guidance
- Design principles (SOLID, clean code)
Workflow
- Identify scope (
single feature, workspace, cross-workspace)
- Load relevant skills for affected layers
- Read local patterns before proposing changes
- Run quality scanner:
bash .agent/skills/engineering-best-practices-enforcer/scripts/scan-quality-signals.sh
- Perform impact and risk assessment (classify: behavior-preserving / adjacent / changing; risk: low / medium / high)
- Produce severity-ordered findings with file references
- Execute small safe batches, verify each workspace
Tech-Debt Registers
Check before producing new findings:
docs/tech-debt/README.md
apps/erify_studios/docs/FRONTEND_TECH_DEBT.md
Cite or extend existing entries instead of opening parallel issues.
Documentation Lifecycle
| Content type | Location |
|---|
| Implemented/canonical docs | docs/ root |
| Unimplemented proposals/plans | docs/ideation/ |
| Status index | docs/README.md |
Output Contract
For every review batch:
- Findings (severity ordered, file refs)
- Open questions and assumptions
- Impact summary (entry points, shared modules, risk tier)
- Refactor plan (incremental batches)
- Verification commands + outcomes
- Residual risk + rollback unit
References