with one click
workflow-review-changes
// [Workflow] Use when activating the Review Current Changes workflow for review, fix, and re-review recursively until all issues resolved.
// [Workflow] Use when activating the Review Current Changes workflow for review, fix, and re-review recursively until all issues resolved.
[HINT] Download the complete skill directory including SKILL.md and all related files
| name | workflow-review-changes |
| version | 4.0.0 |
| description | [Workflow] Use when activating the Review Current Changes workflow for review, fix, and re-review recursively until all issues resolved. |
[BLOCKING] Execute skill steps in declared order. NEVER skip, reorder, or merge steps without explicit user approval. [BLOCKING] Before each step or sub-skill call, update task tracking: set
in_progresswhen step starts, setcompletedwhen step ends. [BLOCKING] Every completed/skipped step MUST include brief evidence or explicit skip reason. [BLOCKING] If Task tools are unavailable, create and maintain an equivalent step-by-step plan tracker with the same status transitions.
Goal: Review all uncommitted changes, fix issues found, then spawn a fresh code-reviewer sub-agent for unbiased re-review — repeat until clean.
Sequence: /review-changes → [parallel batch] /review-architecture + /review-domain-entities (if entity changes) + /performance + /integration-test-review + /security → /code-simplifier → /code-review → /integration-test-verify → /plan → /plan-validate → /why-review → /cook → fresh sub-agent re-review gate → /docs-update → /watzup → /workflow-end
Key Rules:
/cook applies fixes → spawn fresh code-reviewer sub-agent per SYNC:fresh-context-review → integrate findings → fix → spawn NEW sub-agent → repeatCreate one task per row in the table below — source of truth is workflows.json → review-changes.sequence (currently 17 steps; verify count matches if you suspect drift):
| # | Task Subject | Conditional? |
|---|---|---|
| 1 | [Workflow] /review-changes — Surface detection + dimensional review tasks (BE/FE/SCSS/Synthesis/General) + integration test sync check + multilingual translation sync check | No |
| 2 | [Workflow] /review-architecture — Architecture compliance review ⚡ PARALLEL BATCH | No — run as sub-agent in parallel with steps 3/4/5/6 |
| 3 | [Workflow] /review-domain-entities — DDD quality review of changed domain entity files ⚡ PARALLEL BATCH | Yes — skip if no domain entity files (Domain/, Entities/, ValueObjects/) in git diff |
| 4 | [Workflow] /performance — Performance analysis ⚡ PARALLEL BATCH | No — run as sub-agent in parallel with steps 2/3/5/6 |
| 5 | [Workflow] /integration-test-review — Integration test quality review ⚡ PARALLEL BATCH | No — run as sub-agent in parallel with steps 2/3/4/6 |
| 6 | [Workflow] /security — Security vulnerability review ⚡ PARALLEL BATCH | No — run as sub-agent in parallel with steps 2/3/4/5 |
| 7 | [Workflow] /code-simplifier — Simplify and refine code | No — runs AFTER parallel batch (modifies code; batch reviews pre-simplification state) |
| 8 | [Workflow] /code-review — Comprehensive code review | No — runs AFTER code-simplifier (reviews simplified code) |
| 9 | [Workflow] /integration-test-verify — Verify integration tests pass | No — runs AFTER code-simplifier (verifies simplified code) |
| 10 | [Workflow] /plan — Consolidate review findings into fix plan | Skip if all reviews PASS |
| 11 | [Workflow] /plan-validate — Critical questions on fix plan | Skip if all reviews PASS |
| 12 | [Workflow] /why-review — Sanity-check that proposed fixes are warranted | Skip if all reviews PASS |
| 13 | [Workflow] /cook — Implement fixes from plan | Skip if all reviews PASS |
| 14 | [Workflow] Fresh sub-agent re-review gate — spawn new Agent per SYNC:fresh-context-review | Skip if all reviews PASS |
| 15 | [Workflow] /docs-update — Update impacted documentation | Always run — /docs-update triages internally (fast-exits when only config/tool files changed) |
| 16 | [Workflow] /watzup — Wrap up and summarize | No |
| 17 | [Workflow] /workflow-end — End workflow | No |
NEVER consolidate, rename, or omit steps. If reviews PASS, mark conditional tasks completed with note "Skipped — all reviews passed".
Integration Test Sync: The
/review-changesskill (task #1) includes a mandatory integration test coverage check for changed command/query/handler files. When gaps are found, the skill usesAskUserQuestionto surface them — NOT purely advisory. The user must explicitly choose to run/integration-testor confirm tests are already written. No silent skip.
Translation Sync: The
/review-changesskill (task #1) includes a mandatory multilingual UI translation-sync check. When UI text changes in multilingual projects without locale updates, the skill usesAskUserQuestionfor an explicit user decision — NOT purely advisory.
Docs Update:
/docs-updateMUST run after EVERY review — it performs Phase 0 triage and fast-exits automatically when only non-business-code files changed (.claude/**, config). When business code is in the changeset, it WILL invoke: Phase 2/feature-docs(business feature doc update), Phase 2.5/spec-discovery update(engineering spec sync — ifdocs/specs/bundle exists; note: dirs may be app buckets or flat system folders — probels docs/specs/{name}/to find a specific service), Phase 3/tdd-spec(test spec sync), Phase 4/tdd-spec [direction=sync](dashboard sync). Never skip based on review PASS status alone.
Note: Steps 2–6 are ARCHITECTURAL/SECURITY reviewers (architecture compliance, DDD entities, performance, integration test quality, security vulnerabilities). They are separate from the DIMENSIONAL review (BE/FE/SCSS/Synthesis) that runs inside Step 1 (
/review-changes). Both operate in parallel — Steps 2–6 as explicit workflow parallel sub-agents; dimensional agents inside Step 1 as its internal parallel batch. No overlap in responsibility.
Steps 2–6 (/review-architecture, /review-domain-entities, /performance, /integration-test-review, /security) are read-only and independent — no shared mutable state, no ordering dependency between them. Run them as parallel sub-agents to preserve main session context budget and reduce wall-clock time.
Each reviewer reads the git diff independently and analyzes one concern. Sequential execution would burn 50K+ tokens in the main session absorbing all five inline. The stepMeta in workflows.json marks all five as executionMode: subagent, contextBudget: high — the workflow-step-tracker.cjs hook outputs 💡 [SUB-AGENT RECOMMENDED] as each step becomes active.
After step 1 (/review-changes) completes, spawn all active parallel reviewers in a single response with multiple Agent tool calls:
Agent(review-architecture, subagent_type="code-reviewer", ...) ← all in ONE message
Agent(review-domain-entities, subagent_type="code-reviewer", ...) ← only if entity files in diff
Agent(performance, subagent_type="code-reviewer", ...)
Agent(integration-test-review, subagent_type="code-reviewer", ...)
Agent(security, subagent_type="code-reviewer", ...)
Each sub-agent receives:
plans/reports/{skill}-{date}-{slug}.mdSYNC:review-protocol-injection (verbatim in prompt — never by file reference)Agent tool calls do NOT trigger workflow-step-tracker.cjs (hook fires only on Skill completions). After all parallel sub-agents return:
TaskUpdate step 2 → completedTaskUpdate step 3 → completed (or "Skipped — no entity files" if conditional)TaskUpdate step 4 → completedTaskUpdate step 5 → completedTaskUpdate step 6 → completed/code-simplifier) sequentiallyBefore running /code-simplifier, synthesize all parallel sub-agent findings:
/code-simplifier as context so simplification is informed by review findingsSurface Analysis from Step 1:
Step 1 (/review-changes) now emits a surface analysis summary in its report:
## Change Surface Analysis
BE files: {N}
FE-Logic files: {M}
SCSS files: {P}
Review Mode: [DIMENSIONAL | BE-ONLY | FE-ONLY | FE-SPLIT | TOOLING]
Include this surface analysis in the consolidation summary passed to /code-simplifier.
This lets the simplifier focus attention on the dominant surface without re-analyzing the diff.
Dimensional agent reports (if mode = DIMENSIONAL):
plans/reports/review-be-{date}.md — BE findingsplans/reports/review-fe-logic-{date}.md — FE-Logic findingsplans/reports/review-scss-{date}.md — SCSS findings (if spawned)plans/reports/synthesis-review-{date}.md — Cross-boundary findingsAll four feed into the consolidation summary alongside steps 2–5 architectural findings.
| Step | Why sequential |
|---|---|
review-changes (#1) | Establishes baseline — must run first |
code-simplifier (#7) | Modifies code — batch reviews pre-simplification state |
code-review (#8) | Must review simplified code (after #7) |
integration-test-verify (#9) | Must run tests on simplified code (after #7) |
plan → cook (#10–14) | Ordered fix cycle — each step depends on previous |
Reviews (steps 1-7) → ALL PASS? AND integration-test-verify (step 9) passes?
YES → skip steps 10-14, proceed to /docs-update → /watzup → /workflow-end → DONE
NO → /plan → /plan-validate → /why-review → /cook → FRESH SUB-AGENT RE-REVIEW GATE (step 14)
Note: /integration-test-verify (step 9) always runs — it is NOT conditional on review outcome.
/cook Applies FixesAgent tool call with subagent_type: "code-reviewer" using the canonical template from SYNC:review-protocol-injection in .claude/skills/shared/sync-inline-versions.md. Inject all 9 required SYNC protocol blocks verbatim (SYNC:evidence-based-reasoning, SYNC:bug-detection, SYNC:design-patterns-quality, SYNC:logic-and-intention-review, SYNC:test-spec-verification, SYNC:fix-layer-accountability, SYNC:rationalization-prevention, SYNC:graph-assisted-investigation, SYNC:understand-code-first). Target files = "run git diff to see all uncommitted changes". Report path = plans/reports/workflow-review-changes-round{N}-{date}.md./docs-update → /watzup → /workflow-end → DONE/plan + /cook again, then spawn a NEW Agent call (never reuse the previous sub-agent) for Round N+1AskUserQuestion — do NOT silently loop or fall back to any prior protocolIteration count is tracked in conversation context only — no persistent files. Each new conversation starts fresh at round 0.
Rules:
AskUserQuestion (manual review required)AskUserQuestionMain Session: Review → Issues? → Plan → Fix (/cook) → Spawn fresh sub-agent
│ │
│ (no issues) ↓
↓ Fresh sub-agent re-reads ALL
/docs-update changed files from scratch with
/watzup verbatim protocol injection
/workflow-end │
DONE ✓ ↓
Report → PASS? → DONE ✓
→ FAIL? → Fix → spawn
NEW sub-agent
(max 3 rounds)
IMPORTANT MANDATORY Steps: /review-changes -> /review-architecture -> /review-domain-entities -> /performance -> /integration-test-review -> /security -> /code-simplifier -> /code-review -> /integration-test-verify -> /plan -> /why-review -> /plan-validate -> /why-review -> /cook -> /workflow-review-changes -> /docs-update -> /watzup -> /workflow-end
[BLOCKING SEQUENCING] Step 1
/review-changesis SEQUENTIAL and MUST run FIRST — it produces the baseline (surface analysis + integration-test/translation gap detection) consumed by all downstream reviewers. Steps 2–6 (/review-architecture,/review-domain-entities,/performance,/integration-test-review,/security) form a PARALLEL BATCH — spawn all in ONE message viaAgenttool calls (subagent_type: "code-reviewer"). Step 7/code-simplifieris SEQUENTIAL and waits until ALL parallel batch sub-agents return + consolidation summary is built. Steps 8+ proceed sequentially as listed.
IMPORTANT MANDATORY Steps: /review-changes -> /review-architecture -> /review-domain-entities -> /performance -> /integration-test-review -> /security -> /code-simplifier -> /code-review -> /integration-test-verify -> /plan -> /why-review -> /plan-validate -> /why-review -> /cook -> /workflow-review-changes -> /docs-update -> /watzup -> /workflow-end
[BLOCKING SEQUENCING] Step 1
/review-changesis SEQUENTIAL and MUST run FIRST — it produces the baseline (surface analysis + integration-test/translation gap detection) consumed by all downstream reviewers. Steps 2–6 (/review-architecture,/review-domain-entities,/performance,/integration-test-review,/security) form a PARALLEL BATCH — spawn all in ONE message viaAgenttool calls (subagent_type: "code-reviewer"). Step 7/code-simplifieris SEQUENTIAL and waits until ALL parallel batch sub-agents return + consolidation summary is built. Steps 8+ proceed sequentially as listed.
[WORKFLOW-IN-WORKFLOW: MUST RUN AS SUB-AGENT when inside another workflow] This skill activates the full
review-changesworkflow (16 steps). When invoked as a step inside a parent workflow (e.g.,feature,bugfix,refactor), it MUST execute viaAgenttool (subagent_type: "code-reviewer") — NEVER as an inlineSkilltool call. Inline execution absorbs 16 steps of context into the parent session.Sub-agent prompt must include: current git diff, feature/task description, instruction to return SYNC:subagent-return-contract summary and write full findings to
plans/reports/.Standalone invocation (not inside a workflow): inline execution is fine — no sub-agent required.
[BLOCKING] Each step MUST ATTENTION invoke its
Skilltool — marking a taskcompletedwithout skill invocation is a workflow violation. NEVER batch-complete validation gates. [FRESH SUB-AGENT RE-REVIEW] After fixes in/cook, spawn a fresh sub-agent perSYNC:fresh-context-reviewfor unbiased re-review. Max 3 fresh rounds per conversation. [ITERATION CAP] Max 3 fresh-subagent re-review rounds per conversation (tracked in conversation context, not persistent files). PASS = zero Critical/High without fixes.
Activate the review-changes workflow. Run /workflow-start review-changes with the user's prompt as context.
Fresh Sub-Agent Review — Eliminate orchestrator confirmation bias via isolated sub-agents.
Why: The main agent knows what it (or
/cook) just fixed and rationalizes findings accordingly. A fresh sub-agent has ZERO memory, re-reads from scratch, and catches what the main agent dismissed. Sub-agent bias is mitigated by (1) fresh context, (2) verbatim protocol injection, (3) main agent not filtering the report.When: ONLY after a fix cycle. A review round that finds zero issues ENDS the loop — do NOT spawn a confirmation sub-agent. A review round that finds issues triggers: fix → fresh sub-agent re-review.
How:
- Spawn a NEW
Agenttool call — usecode-reviewersubagent_type for code reviews,general-purposefor plan/doc/artifact reviews- Inject ALL required review protocols VERBATIM into the prompt — see
SYNC:review-protocol-injectionfor the full list and template. Never reference protocols by file path; AI compliance drops behind file-read indirection (seeSYNC:shared-protocol-duplication-policy)- Sub-agent re-reads ALL target files from scratch via its own tool calls — never pass file contents inline in the prompt
- Sub-agent writes structured report to
plans/reports/{review-type}-round{N}-{date}.md- Main agent reads the report, integrates findings into its own report, DOES NOT override or filter
Rules:
- SKIP fresh sub-agent when the prior round found zero issues (no fixes = nothing new to verify)
- NEVER skip fresh sub-agent after a fix cycle — every fix invalidates the prior verdict
- NEVER reuse a sub-agent across rounds — every fresh round spawns a NEW
Agentcall- Max 3 fresh-subagent rounds per review — escalate via
AskUserQuestionif still failing; do NOT silently loop or fall back to any prior protocol- Track iteration count in conversation context (session-scoped, no persistent files)
Incremental Result Persistence — MANDATORY for all sub-agents or heavy inline steps processing >3 files.
- Before starting: Create report file
plans/reports/{skill}-{date}-{slug}.md- After each file/section reviewed: Append findings to report immediately — never hold in memory
- Return to main agent: Summary only (per SYNC:subagent-return-contract) with
Full report:path- Main agent: Reads report file only when resolving specific blockers
Why: Context cutoff mid-execution loses ALL in-memory findings. Each disk write survives compaction. Partial results are better than no results.
Report naming:
plans/reports/{skill-name}-{YYMMDD}-{HHmm}-{slug}.md
Sub-Agent Return Contract — When this skill spawns a sub-agent, the sub-agent MUST return ONLY this structure. Main agent reads only this summary — NEVER requests full sub-agent output inline.
## Sub-Agent Result: [skill-name] Status: ✅ PASS | ⚠️ PARTIAL | ❌ FAIL Confidence: [0-100]% ### Findings (Critical/High only — max 10 bullets) - [severity] [file:line] [finding] ### Actions Taken - [file changed] [what changed] ### Blockers (if any) - [blocker description] Full report: plans/reports/[skill-name]-[date]-[slug].mdMain agent reads
Full reportfile ONLY when: (a) resolving a specific blocker, or (b) building a fix plan. Sub-agent writes full report incrementally (per SYNC:incremental-persistence) — not held in memory.
AI Mistake Prevention — Failure modes to avoid on every task:
Check downstream references before deleting. Deleting components causes documentation and code staleness cascades. Map all referencing files before removal. Verify AI-generated content against actual code. AI hallucinates APIs, class names, and method signatures. Always grep to confirm existence before documenting or referencing. Trace full dependency chain after edits. Changing a definition misses downstream variables and consumers derived from it. Always trace the full chain. Trace ALL code paths when verifying correctness. Confirming code exists is not confirming it executes. Always trace early exits, error branches, and conditional skips — not just happy path. When debugging, ask "whose responsibility?" before fixing. Trace whether bug is in caller (wrong data) or callee (wrong handling). Fix at responsible layer — never patch symptom site. Assume existing values are intentional — ask WHY before changing. Before changing any constant, limit, flag, or pattern: read comments, check git blame, examine surrounding code. Verify ALL affected outputs, not just the first. Changes touching multiple stacks require verifying EVERY output. One green check is not all green checks. Holistic-first debugging — resist nearest-attention trap. When investigating any failure, list EVERY precondition first (config, env vars, DB names, endpoints, DI registrations, data preconditions), then verify each against evidence before forming any code-layer hypothesis. Surgical changes — apply the diff test. Bug fix: every changed line must trace directly to the bug. Don't restyle or improve adjacent code. Enhancement task: implement improvements AND announce them explicitly. Surface ambiguity before coding — don't pick silently. If request has multiple interpretations, present each with effort estimate and ask. Never assume all-records, file-based, or more complex path. Business terminology in Application/Domain layers. Comments and naming in Application/Domain must stay business-oriented and technical-agnostic; avoid implementation terms (say
background job, notHangfire background job).
Nested Task Expansion Contract — For workflow-step invocation, the
[Workflow] ...row is only a parent container; the child skill still creates visible phase tasks.
- Call
TaskListfirst. If a matching active parent workflow row exists, setnested=trueand recordparentTaskId; otherwise run standalone.- Create one task per declared phase before phase work. When nested, prefix subjects
[N.M] $skill-name — phase.- When nested, link the parent with
TaskUpdate(parentTaskId, addBlockedBy: [childIds]).- Orchestrators must pre-expand a child skill's phase list and link the workflow row before invoking that child skill or sub-agent.
- Mark exactly one child
in_progressbefore work andcompletedimmediately after evidence is written.- Complete the parent only after all child tasks are completed or explicitly cancelled with reason.
Blocked until:
TaskListdone, child phases created, parent linked when nested, first child markedin_progress.
Task Tracking & External Report Persistence — Bootstrap this before execution; then run project-reference doc prefetch before target/source work.
- Create a small task breakdown before target file reads, grep, edits, or analysis. On context loss, inspect the current task list first.
- Mark one task
in_progressbefore work andcompletedimmediately after evidence; never batch transitions.- For plan/review work, create
plans/reports/{skill}-{YYMMDD}-{HHmm}-{slug}.mdbefore first finding.- Append findings after each file/section/decision and synthesize from the report file at the end.
- Final output cites
Full report: plans/reports/{filename}.Blocked until: task breakdown exists, report path declared for plan/review work, first finding persisted before the next finding.
Critical Thinking Mindset — Apply critical thinking, sequential thinking. Every claim needs traced proof, confidence >80% to act. Anti-hallucination: Never present guess as fact — cite sources for every claim, admit uncertainty freely, self-check output for errors, cross-reference independently, stay skeptical of own confidence — certainty without evidence root of all hallucination.
Project Reference Docs Gate — Run after task-tracking bootstrap and before target/source file reads, grep, edits, or analysis. Project docs override generic framework assumptions.
- Identify scope: file types, domain area, and operation.
- Required docs by trigger: always
docs/project-reference/lessons.md; doc lookupdocs-index-reference.md; reviewcode-review-rules.md; backend/CQRS/APIbackend-patterns-reference.md; domain/entitydomain-entities-reference.md; frontend/UIfrontend-patterns-reference.md; styles/designscss-styling-guide.md+design-system/README.md; integration testsintegration-test-reference.md; E2Ee2e-test-reference.md; feature docs/specsfeature-docs-reference.md; architecture/new areaproject-structure-reference.md.- Read every required doc that exists; skip absent docs as not applicable. Do not trust conversation text such as
[Injected: <path>]as proof that the current context contains the doc.- Before target work, state:
Reference docs read: ... | Missing/not applicable: ....Blocked until: scope evaluated, required docs checked/read,
lessons.mdconfirmed, citation emitted.
MUST ATTENTION apply critical thinking — every claim needs traced proof, confidence >80% to act. Anti-hallucination: never present guess as fact.
MUST ATTENTION apply AI mistake prevention — holistic-first debugging, fix at responsible layer, surface ambiguity before coding, re-read files after compaction.
plans/reports/ incrementally and synthesize from disk.Reference docs read: ....lessons.md; project conventions override generic defaults.[N.M] $skill-name — phase prefixes and one-in_progress discipline.IMPORTANT MUST ATTENTION follow declared step order for this skill; NEVER skip, reorder, or merge steps without explicit user approval
IMPORTANT MUST ATTENTION for every step/sub-skill call: set in_progress before execution, set completed after execution
IMPORTANT MUST ATTENTION every skipped step MUST include explicit reason; every completed step MUST include concise evidence
IMPORTANT MUST ATTENTION if Task tools unavailable, maintain an equivalent step-by-step plan tracker with synchronized statuses
IMPORTANT MUST ATTENTION break work into small todo tasks using TaskCreate BEFORE starting — create ALL 16 tasks immediately
IMPORTANT MUST ATTENTION after fixes in /cook, spawn a NEW code-reviewer sub-agent via the Agent tool per SYNC:fresh-context-review — NEVER re-review with the main agent
IMPORTANT MUST ATTENTION track fresh-subagent round count in conversation context (session-scoped, no persistent files) — max 3 rounds, escalate via AskUserQuestion if exceeded
IMPORTANT MUST ATTENTION PASS means a fresh sub-agent round finds ZERO Critical/High issues WITHOUT needing fixes — only then are changes ready to commit
IMPORTANT MUST ATTENTION skip steps 9-13 when all reviews PASS and tests pass (no fixes needed)
IMPORTANT MUST ATTENTION each step MUST invoke its Skill tool — marking completed without invocation is a violation
IMPORTANT MUST ATTENTION treat multilingual UI translation gaps as mandatory user-decision gates — no silent pass when locale updates are missing
[TASK-PLANNING] Before acting, analyze task scope and systematically break it into small todo tasks and sub-tasks using TaskCreate.
[IMPORTANT] Analyze how big the task is and break it into many small todo tasks systematically before starting — this is very important.