Run any Skill in Manus with one click

review-checklist

LobeHub code review checklist. Use when reviewing a PR, diff, or branch for console leftovers, return await, secrets, i18n, desktop router drift, UI imports, migrations, or cloud impact.

Run Skill in Manus

Stars78,439

Forks15,402

UpdatedJune 9, 2026 at 17:42

Source

lobehub

lobehub/lobehub

View GitHub Repository View Creator Repositories

Install command

Download

Run Skill in Manus

SKILL.md

readonly

name	review-checklist
description	LobeHub code review checklist. Use when reviewing a PR, diff, or branch for console leftovers, return await, secrets, i18n, desktop router drift, UI imports, migrations, or cloud impact.
user-invocable	false

Review Checklist

Correctness

Leftover console.log / console.debug — should use debug package or remove
Missing return await in try/catch — see https://typescript-eslint.io/rules/return-await/ (not in our ESLint config yet, requires type info)
Can the fix/implementation be more concise, efficient, or have better compatibility?

Security

No sensitive data (API keys, tokens, credentials) in console.* or debug() output
No base64 output to terminal — extremely long, freezes output
No hardcoded secrets — use environment variables

Testing

Bug fixes must include tests covering the fixed scenario
New logic (services, store actions, utilities) should have test coverage
New database Model/Repository (packages/database/src/models/**, src/repositories/**) must ship a sibling __tests__/<name>.test.ts — incl. user-isolation tests; BM25 search guarded by describe.skipIf(!isServerDB) (see /testing → db-model-test.md)
Existing tests still cover the changed behavior?
Prefer vi.spyOn over vi.mock (see /testing skill)

i18n

New user-facing strings use i18n keys, not hardcoded text
Keys added to src/locales/default/{namespace}.ts with {feature}.{context}.{action|status} naming
For PRs: locales/ translations for all languages updated (pnpm i18n)

SPA / routing

desktopRouter pair: If the diff touches src/spa/router/desktopRouter.config.tsx, does it also update src/spa/router/desktopRouter.config.desktop.tsx with the same route paths and nesting? Single-file edits often cause drift and blank screens.

Reuse

Newly written code duplicates existing utilities in packages/utils or shared modules?
Copy-pasted blocks with slight variation — extract into shared function
antd imports replaceable with @lobehub/ui wrapped components (Input, Button, Modal, Avatar, etc.)
Use antd-style token system, not hardcoded colors; prefer createStaticStyles + cssVar.* over createStyles + token unless runtime computation is required

Database

Migration scripts must be idempotent (IF NOT EXISTS, IF EXISTS guards)

Cloud Impact

A downstream cloud deployment depends on this repo. Flag changes that may require cloud-side updates:

Backend route paths changed — e.g., renaming src/app/(backend)/webapi/chat/route.ts or changing its exports
SSR page paths changed — e.g., moving/renaming files under src/app/[variants]/(auth)/
Dependency versions bumped — e.g., upgrading next or drizzle-orm in package.json
@lobechat/business-* exports changed — e.g., renaming a function in src/business/ or changing type signatures in packages/business/
src/business/ and packages/business/ must not expose cloud commercial logic in comments or code

More from this repository

same repository

drizzle

lobehub/lobehub

LobeHub Drizzle ORM schema and query style. Use for pgTable schemas, indexes, joins, inferred types, db.select/db.query, schema fields, foreign keys, junction tables, or postgres query patterns.

2026-06-0978.4k

testing

lobehub/lobehub

Vitest testing guide. Use when writing or updating tests, fixing failing tests, improving coverage, debugging test issues, or setting up mocks.

2026-06-0978.4k

add-setting-env

lobehub/lobehub

Add server-side environment variables that control default values for user settings.

2026-06-0978.4k

agent-runtime-hooks

lobehub/lobehub

Agent runtime lifecycle hooks. Use for before/after tool or step hooks, tool mocks, human intervention, sub-agent calls, context compression, evals, tracing, callAgent, or lifecycle events.

2026-06-0978.4k

agent-signal

lobehub/lobehub

Build or extend LobeHub Agent Signal pipelines. Use for signal sources, signal/action types, policies, middleware, workflow handoff, dedupe, scope behavior, or observability.

2026-06-0978.4k

agent-tracing

lobehub/lobehub

Agent tracing CLI for execution snapshots. Use for agent-tracing, traces, snapshots, LLM call inspection, context engine data, agent step analysis, or execution debugging.

2026-06-0978.4k

Review Checklist

Correctness

Leftover console.log / console.debug — should use debug package or remove

Missing return await in try/catch — see https://typescript-eslint.io/rules/return-await/ (not in our ESLint config yet, requires type info)

Can the fix/implementation be more concise, efficient, or have better compatibility?

Security

No sensitive data (API keys, tokens, credentials) in console.* or debug() output

No base64 output to terminal — extremely long, freezes output

No hardcoded secrets — use environment variables

Testing

Bug fixes must include tests covering the fixed scenario

New logic (services, store actions, utilities) should have test coverage

New database Model/Repository (packages/database/src/models/**, src/repositories/**) must ship a sibling __tests__/<name>.test.ts — incl. user-isolation tests; BM25 search guarded by describe.skipIf(!isServerDB) (see /testing → db-model-test.md)

Existing tests still cover the changed behavior?

Prefer vi.spyOn over vi.mock (see /testing skill)

i18n

New user-facing strings use i18n keys, not hardcoded text

Keys added to src/locales/default/{namespace}.ts with {feature}.{context}.{action|status} naming

For PRs: locales/ translations for all languages updated (pnpm i18n)

SPA / routing

desktopRouter pair: If the diff touches src/spa/router/desktopRouter.config.tsx, does it also update src/spa/router/desktopRouter.config.desktop.tsx with the same route paths and nesting? Single-file edits often cause drift and blank screens.

Reuse

Newly written code duplicates existing utilities in packages/utils or shared modules?

Copy-pasted blocks with slight variation — extract into shared function

antd imports replaceable with @lobehub/ui wrapped components (Input, Button, Modal, Avatar, etc.)

Use antd-style token system, not hardcoded colors; prefer createStaticStyles + cssVar.* over createStyles + token unless runtime computation is required

Database

Migration scripts must be idempotent (IF NOT EXISTS, IF EXISTS guards)

Cloud Impact

A downstream cloud deployment depends on this repo. Flag changes that may require cloud-side updates:

Backend route paths changed — e.g., renaming src/app/(backend)/webapi/chat/route.ts or changing its exports

SSR page paths changed — e.g., moving/renaming files under src/app/[variants]/(auth)/

Dependency versions bumped — e.g., upgrading next or drizzle-orm in package.json

@lobechat/business-* exports changed — e.g., renaming a function in src/business/ or changing type signatures in packages/business/

src/business/ and packages/business/ must not expose cloud commercial logic in comments or code