corvus-phase-5

name	corvus-phase-5
description	Final validation - comprehensive objective and subjective checks

Phase 5: FINAL VALIDATION (Two-Step)

Goal: Comprehensive check of entire implementation with two-step validation.

Phase 5 has two steps:

• 5a: Objective validation (code-quality) - ALWAYS runs
• 5b: Subjective validation (ux-dx-quality) - ONLY if ANY task had requires_ux_dx_review: true

5a. Comprehensive Objective Check (MANDATORY)

DELEGATE TO: @code-quality

**TASK**: Final comprehensive validation of [feature name] implementation

**MASTER PLAN**: `.corvus/tasks/[feature]/MASTER_PLAN.md`

**ALL TASK FILES**: `.corvus/tasks/[feature]/*.md`

**MUST DO**:

When `tests_enabled: true, tests_deferred: false` (default):
- Run FULL test suite (not just affected tests)
- Run production build
- Verify ALL acceptance criteria from ALL task files
- Check for consistency across all changes
- Look for any regressions
- Verify no breaking changes to existing functionality

When `tests_enabled: true, tests_deferred: true` (deferred mode):
- Run FULL test suite — this is the FIRST time tests are executed (they were deferred during Phase 4)
- Run production build
- Verify ALL acceptance criteria from ALL task files
- Check for consistency across all changes
- Look for any regressions
- Verify no breaking changes to existing functionality
- Report clearly that this is the deferred test run

When `tests_enabled: false` (acceptance-only mode):
- Run production build
- Verify ALL acceptance criteria from ALL task files (with concrete evidence)
- Check for consistency across all changes
- Look for any regressions via code review
- Verify no breaking changes to existing functionality
- Do NOT attempt to run tests or report missing tests as a gap

**REPORT BACK**:

When `tests_enabled: true, tests_deferred: false`:
- **5a OBJECTIVE GATE STATUS**: PASS / FAIL
- Test results: [N]/[M] passing
- Build status: PASS/FAIL
- Acceptance criteria: [N]/[M] met (list any failures)
- Regressions found: [list or none]
- Any remaining issues (with severity)

When `tests_enabled: true, tests_deferred: true` (deferred mode):
- **5a OBJECTIVE GATE STATUS**: PASS / FAIL
- **Mode**: DEFERRED TEST RUN (first test execution)
- Test results: [N]/[M] passing
- Build status: PASS/FAIL
- Acceptance criteria: [N]/[M] met (list any failures)
- Regressions found: [list or none]
- Any remaining issues (with severity)
- Note: Tests were deferred from Phase 4 quality gates

When `tests_enabled: false`:
- **5a OBJECTIVE GATE STATUS**: PASS / FAIL
- **Mode**: ACCEPTANCE-ONLY
- Build status: PASS/FAIL
- Acceptance criteria: [N]/[M] met (list any failures with evidence)
- Regressions found: [list or none] (via code review)
- Any remaining issues (with severity)

Decision Point after 5a:

• 5a PASS + UX/DX required → Proceed to 5b
• 5a PASS + No UX/DX required → Proceed to Phase 6
• 5a FAIL → Create fix tasks, return to Phase 4

Note: Decision logic is identical regardless of tests_enabled or tests_deferred. The gate always produces PASS/FAIL; only the evidence model differs. When tests_deferred: true, Phase 5a uses the full test+acceptance model (same as tests_enabled: true, tests_deferred: false).

5b. Comprehensive Subjective Check (IF REQUIRED)

WHEN TO INVOKE: If ANY task in the feature had requires_ux_dx_review: true

This aggregates all UX/DX review requirements from individual tasks into a single feature-level review.

DELEGATE TO: @ux-dx-quality

**TASK**: Final UX/DX review of [feature name] implementation

**MASTER PLAN**: `.corvus/tasks/[feature]/MASTER_PLAN.md`

**TASKS REQUIRING UX/DX REVIEW**:
- Task NN: [name] - [focus area: UI/API/docs/architecture]
- Task NN: [name] - [focus area]

**SCOPE**: All user-facing and developer-facing changes in this feature

**MUST DO**:
- Assess overall user experience quality
- Assess overall developer experience quality
- Assess documentation quality and completeness
- Assess architectural coherence across all changes
- Verify consistency of patterns across the feature

**MUST NOT DO**:
- Re-check objective criteria (already passed in 5a)
- Fix issues directly

**REPORT BACK**:
- **5b SUBJECTIVE GATE STATUS**: PASS / FAIL
- Overall UX assessment
- Overall DX assessment
- Documentation assessment
- Architecture assessment
- Strengths identified
- Issues requiring fixes (if FAIL)

Decision Point after 5b:

• 5b PASS → Proceed to Phase 6
• 5b FAIL → Create fix tasks, return to Phase 4 (fixes must pass 5a again)