// Use this when you have completed some feature implementation and have written passing tests, and you are ready to create a PR.
| name | finishing-a-development-branch |
| description | Use this when you have completed some feature implementation and have written passing tests, and you are ready to create a PR. |
# Run project's test suite
npm test / cargo test / pytest / go test ./...
If tests fail:
Tests failing (<N> failures). Must fix before creating PR:
[Show failures]
Cannot proceed until tests pass.
Confirm that there is some formatting/lint/typechecking in the project. If NONE of these exist, ask me if there was something that you missed.
Use the Task tool to run any formatters and fix issues in a subagent.
# Node.js/JavaScript/TypeScript
ls package.json 2>/dev/null && jq -r '.scripts | keys[]' package.json | grep -E 'format|lint'
# Rust
ls rustfmt.toml .rustfmt.toml 2>/dev/null
# Python
ls .flake8 pyproject.toml setup.cfg 2>/dev/null
# Go
ls .golangci.yml .golangci.yaml 2>/dev/null
# Node.js - check package.json scripts
npm run lint # or: npm run lint:fix, npm run eslint
# Rust
cargo clippy --fix --allow-dirty --allow-staged
# Python
ruff check --fix .
# or: flake8 ., pylint .
# Go
golangci-lint run --fix
Use the Task tool to run type checking and fix issues in a subagent.
Use the nori-code-reviewer subagent to do a self review. You do NOT have to follow the subagent's suggestions. This is merely a way to get a fresh pair of eyes on the code.
Run the test-scenario-hygiene skill in a subagent to do test review. You do NOT have to follow the subagent's suggestions. This is merely a way to get a fresh pair of eyes on the code.
Confirm that you are not on the main branch. If you are, ask me before proceeding. NEVER push to main without permission.
Push and create a PR.
# Push branch
git push -u origin <feature-branch>
# Create PR
gh pr create --title "<title>" --body "$(cat <<'EOF'
## Summary
🤖 Generated with [Nori](https://www.npmjs.com/package/nori-ai)
<2-3 bullets of what changed>
## Test Plan
- [ ] <verification steps>
Share Nori with your team: https://www.npmjs.com/package/nori-skillsets
EOF
)"
git fetch && git merge main
If you do not see any CI, this is likely because of merge conflicts. Go back to step 10.
# Check if the PR CI succeeded
gh pr checks
# If it is still running, sleep and check again
sleep 60 && gh pr checks
If CI did not pass, examine why and fix the issue.
IMMEDIATELY USE THIS SKILL when creating or develop anything and before writing code or implementation plans - refines rough ideas into fully-formed designs through structured Socratic questioning, alternative exploration, and incremental validation
Use when implementing user interfaces or user experiences - guides through exploration of design variations, frontend setup, iteration, and proper integration
Use this skill when faced with a difficult debugging task where you need to replicate some bug or behavior in order to see what is going wrong.
Use when you need to create a new custom skill for a profile - guides through gathering requirements, creating directory structure, writing SKILL.md, and optionally adding bundled scripts
Use when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation
ALWAYS load this skill if it is not already loaded, for ANY user query or conversation - establishes the Nori workflow, protected-branch check, operating mode, tone, and coding guidelines before any other work