// Review pull requests for the zowex codebase. Analyze C++ backend and middleware (ibm-clang), TypeScript clients (CLI, SDK, VS Code extension), and z/OS-specific concerns. Use when asked to review a PR, branch, or code changes.
| name | review-prs |
| description | Review pull requests for the zowex codebase. Analyze C++ backend and middleware (ibm-clang), TypeScript clients (CLI, SDK, VS Code extension), and z/OS-specific concerns. Use when asked to review a PR, branch, or code changes. |
Review pull requests for code quality, security, and adherence to project standards.
git diff --name-only main...HEAD 2>nul (or target branch)git diff main...HEAD 2>nul.github/PULL_REQUEST_TEMPLATE.mdCategorize all findings:
Issues that must be fixed before merge:
Issues that should be addressed:
Optional improvements:
native/c/, native/zowed/)Compiler constraints:
Check for:
new/delete pairing, no leakszowex server codeStyle (from .clang-format):
char *ptr)Use the cpp-code-quality skill to evaluate quality of new or changed C++ code. Use the metalc-code-quality skill to evaluate quality of new or changed Metal C code.
packages/cli/, packages/sdk/)Check for:
any outside tests)Style (from biome.json):
Use the frontend-code-quality skill to evaluate quality of new or changed TypeScript code.
Flag as 🔴 Critical if changes affect:
C++ API:
native/c/*.h, native/c/*.hpp)TypeScript API:
packages/sdk/src/Ensure the PR addresses:
Consider these during review:
Improve TypeScript code quality in CLI, SDK, and VS Code extension packages. Apply DRY, YAGNI, SRP principles to reduce duplication and complexity. Use when refactoring, deduplicating, simplifying, or improving code in packages/cli/ or packages/sdk/.
Validate VS Code extensions and CLI plug-ins against Zowe V3 Conformance Criteria. Audit package.json, settings, commands, menus, profile usage, and API registration for conformance. Use when checking Zowe conformance, preparing for conformance submission, auditing an extension/plug-in against Zowe criteria, or when the user mentions conformance.
Use when writing, debugging, or maintaining tests for the native C/C++ and Metal C components in native/c/test/. Covers the custom ztest framework, test patterns, build system integration, and debugging test failures.
Guides users through creating new zowex commands across the Zowe Remote SSH stack (native C++, server, SDK). Use when the user wants to add a new command, implement a zowex command, or add functionality to the native backend.
Improve C++ code quality by identifying duplication, complexity, and design issues. Apply DRY, YAGNI, SRP principles. Use when refactoring, deduplicating, simplifying, or improving backend code in native/c/.
Prevent data loss and unsafe operations in data set and USS workflows, including cross-profile, cross-LPAR, and overwrites. Use when performing move, copy, upload, rename, or delete operations on z/OS resources.