القائمة
Review a diff for small-scale structural problems — unjustified complexity, duplicated logic, scope creep, or misplaced code.
التثبيت باستخدام Codex أو Claude انسخ هذا Prompt والصقه في Codex أو Claude أو مساعد آخر ليراجع صفحة Skill ويثبّتها لك.
استنادا إلى تصنيف SOC المهني
Build and manage a kind cluster for Workload-Aware Scheduling (WAS) e2e tests. Use when the user wants to set up, run tests against, or tear down a WAS test cluster built from Kubernetes main.
Flag solutions more elaborate than the problem requires — complexity that exists only because the author reached for a pattern.
Flag identical (or near-identical) blocks across types/adapters/call sites that should live in a shared helper — and newly extracted helpers with only one caller.
Flag code organization that a future maintainer will struggle to follow, modify, or extend.
Flag code put somewhere a reader would not expect to find it — cleanup scattered across callers, validation deep in business logic.
Flag unnecessary indirection, mismatched abstractions, or confusing data flow that obscures what the code is doing.
| name | architectural-decisions |
| description | Review a diff for small-scale structural problems — unjustified complexity, duplicated logic, scope creep, or misplaced code. |
| license | Apache-2.0 |
| metadata | {"copyright":"The Kubernetes Authors"} |
Use this when reviewing a diff for small-scale structural problems: how code is organized, how parts connect, and whether complexity is justified. Complex problems may need complex solutions, but every unit of complexity must earn its keep.
Each rule in this domain is its own sub-skill. Scan the diff for violations of every rule below.
| Rule | Triggers on |
|---|---|
| illogical-structure | code a future maintainer will struggle to follow, modify, or extend |
| nonsensical-decisions | unnecessary indirection, mismatched abstractions, confusing data flow |
| avoidable-complexity | solutions more elaborate than the problem requires |
| pointless-intermediate-variables | redundant local variables that add noise without clarity |
| duplicated-logic | identical blocks across types/adapters/call sites that should be shared — or new helpers with one caller |
| scope-creep | diffs bundling a bugfix with an unrelated refactor, or over-generalizing a change |
| misplaced-logic | code placed somewhere a reader would not expect to find it |
@./illogical-structure/SKILL.md @./nonsensical-decisions/SKILL.md @./avoidable-complexity/SKILL.md @./pointless-intermediate-variables/SKILL.md @./duplicated-logic/SKILL.md @./scope-creep/SKILL.md @./misplaced-logic/SKILL.md
Do not report personal preferences or architectural taste. This skill is for structural problems that materially hurt maintainability, simplicity, or evolution of the code.
In particular, do not flag:
For each finding, cite the exact file and line, name which rule it violates, and classify severity (high / medium / low). Severity scales with how much the issue hurts maintainability, simplicity, or backward compatibility. Decisions that make the code materially harder to extend are high; cosmetic structural nits are low.
Return two sections:
A bullet list, one per violation, in this format:
- <High/Medium/Low> | <Finding Title>: <one-sentence explanation grounded in the diff>
One recommendation per finding above, numbered sequentially within this skill. Each recommendation MUST contain all four sections below.
### Recommendation N: <short title>
**Problem**: Describe the specific issue in the diff.
**Reason**: Explain why this is a problem — what goes wrong or degrades over time.
**Solution**: Give a concrete, actionable fix. Where possible, show a before/after code snippet.
**Locations**: List every place this issue occurs, one per line, in `filepath:line` form.