القائمة
Review a diff for behavioral defects — logic errors, broken edge cases, feature-gate bugs, and deletions that break backwards compatibility during rolling upgrades.
التثبيت باستخدام Codex أو Claude انسخ هذا Prompt والصقه في Codex أو Claude أو مساعد آخر ليراجع صفحة Skill ويثبّتها لك.
استنادا إلى تصنيف SOC المهني
Build and manage a kind cluster for Workload-Aware Scheduling (WAS) e2e tests. Use when the user wants to set up, run tests against, or tear down a WAS test cluster built from Kubernetes main.
Flag solutions more elaborate than the problem requires — complexity that exists only because the author reached for a pattern.
Flag identical (or near-identical) blocks across types/adapters/call sites that should live in a shared helper — and newly extracted helpers with only one caller.
Flag code organization that a future maintainer will struggle to follow, modify, or extend.
Flag code put somewhere a reader would not expect to find it — cleanup scattered across callers, validation deep in business logic.
Flag unnecessary indirection, mismatched abstractions, or confusing data flow that obscures what the code is doing.
| name | buggy-behavior |
| description | Review a diff for behavioral defects — logic errors, broken edge cases, feature-gate bugs, and deletions that break backwards compatibility during rolling upgrades. |
| license | Apache-2.0 |
| metadata | {"copyright":"The Kubernetes Authors"} |
Use this when reviewing a diff for behavioral defects: logic errors, broken edge cases, and changes that break compatibility with objects created by older versions of the controller.
Each rule in this domain is its own sub-skill. Scan the diff for violations of every rule below.
| Rule | Triggers on |
|---|---|
| logic-errors | incorrect conditionals, inverted checks, off-by-one, unhandled edge cases, races, mishandled errors |
| deleted-backwards-compatibility-code | removal or relocation of code that reconciles state owned by previous controller versions |
| feature-gate-interaction-bugs | gated behavior whose gate-off path is untested or incorrect |
| unnecessary-guard-conditions | extra checks that are logically unreachable at the call site |
@./logic-errors/SKILL.md @./deleted-backwards-compatibility-code/SKILL.md @./feature-gate-interaction-bugs/SKILL.md @./unnecessary-guard-conditions/SKILL.md
Cite the exact file and line, describe the failure mode (what input triggers it, what goes wrong), and classify severity (high / medium / low). Hot-path logic errors and deleted compatibility code are high. Untested gate-off paths are typically medium. Stray unreachable guards are low.
Return two sections:
A bullet list, one per violation, in this format:
- <High/Medium/Low> | <Finding Title>: <one-sentence explanation grounded in the diff>
One recommendation per finding above, numbered sequentially within this skill. Each recommendation MUST contain all four sections below.
### Recommendation N: <short title>
**Problem**: Describe the specific issue in the diff.
**Reason**: Explain why this is a problem — what goes wrong or degrades over time.
**Solution**: Give a concrete, actionable fix. Where possible, show a before/after code snippet.
**Locations**: List every place this issue occurs, one per line, in `filepath:line` form.