القائمة
Review a diff for naming precision, convention drift, reinvented helpers, log-verbosity mistakes, misaligned test names, and typos.
التثبيت باستخدام Codex أو Claude انسخ هذا Prompt والصقه في Codex أو Claude أو مساعد آخر ليراجع صفحة Skill ويثبّتها لك.
استنادا إلى تصنيف SOC المهني
Build and manage a kind cluster for Workload-Aware Scheduling (WAS) e2e tests. Use when the user wants to set up, run tests against, or tear down a WAS test cluster built from Kubernetes main.
Flag solutions more elaborate than the problem requires — complexity that exists only because the author reached for a pattern.
Flag identical (or near-identical) blocks across types/adapters/call sites that should live in a shared helper — and newly extracted helpers with only one caller.
Flag code organization that a future maintainer will struggle to follow, modify, or extend.
Flag code put somewhere a reader would not expect to find it — cleanup scattered across callers, validation deep in business logic.
Flag unnecessary indirection, mismatched abstractions, or confusing data flow that obscures what the code is doing.
| name | code-style |
| description | Review a diff for naming precision, convention drift, reinvented helpers, log-verbosity mistakes, misaligned test names, and typos. |
| license | Apache-2.0 |
| metadata | {"copyright":"The Kubernetes Authors"} |
Use this when reviewing a diff for naming, convention, and stylistic violations against the surrounding code. The goal is consistency with the existing package, not the reviewer's personal taste.
Each rule in this domain is its own sub-skill. Scan the diff for violations of every rule below.
| Rule | Triggers on |
|---|---|
| imprecise-names | identifier whose name does not describe exactly what it contains |
| convention-drift | new code that breaks naming conventions already established in the same file or package |
| reinvented-helpers | logic that duplicates an existing util/helper function instead of reusing it |
| wrong-log-verbosity | per-reconcile-cycle log lines emitted at V(2) |
| misaligned-test-names | test function names that do not reflect the function or behavior under test |
| code-style-typos | typos in identifiers, strings, or any text introduced by the diff |
@./imprecise-names/SKILL.md @./convention-drift/SKILL.md @./reinvented-helpers/SKILL.md @./wrong-log-verbosity/SKILL.md @./misaligned-test-names/SKILL.md @./code-style-typos/SKILL.md
Do not report personal preferences or taste-based objections. This skill is about consistency, precision, and established local conventions, not about the reviewer's favorite naming style or formatting habits.
In particular, do not flag:
Cite the exact file and line, name the convention or rule being violated, and classify severity (high / medium / low). Naming-precision issues that introduce semantic ambiguity (a name that lies about its contents) are high. Convention drift and reinvented helpers are typically medium. Stray typos and minor wording choices are low.
Return two sections:
A bullet list, one per violation, in this format:
- <High/Medium/Low> | <Finding Title>: <one-sentence explanation grounded in the diff>
One recommendation per finding above, numbered sequentially within this skill. Each recommendation MUST contain all four sections below.
### Recommendation N: <short title>
**Problem**: Describe the specific issue in the diff.
**Reason**: Explain why this is a problem — what goes wrong or degrades over time.
**Solution**: Give a concrete, actionable fix. Where possible, show a before/after code snippet.
**Locations**: List every place this issue occurs, one per line, in `filepath:line` form.