abap-code-review

name	ABAP Code Review
description	Use when reviewing ABAP source for Clean ABAP conformance before object activation, transport release, or after importing foreign code. Covers the three ABAP-specific dimensions that general-purpose review skills do not - naming conventions, pretty-printer formatting, and anti-pattern compliance - against docs/clean-abap-checklist.md. Trigger on "review the ABAP code", "Clean ABAP check", "naming convention review", "pretty printer check", "anti-pattern scan".
version	1.0.0
last_reviewed	2026-08-25T00:00:00.000Z
status	active
scope	co-abap
owner	code-writer
prerequisites	vsp MCP server
metadata	{"type":"core","triggers":["abap-code-review","code review","Clean ABAP","naming convention","pretty printer","anti-pattern"]}

ABAP Code Review

Context

co-develop's general-purpose code-review skill covers language-agnostic review practice - it does not cover ABAP-specific compliance. This skill operationalizes the Clean ABAP Conformance Checklist (docs/clean-abap-checklist.md) as a structured review pass over ABAP source. The checklist is the review standard: this skill walks its rule families and cites section numbers - it does not restate or duplicate the rules themselves.

When to Use

• Before object activation - author self-review by code-writer immediately after WriteSource/EditSource, ahead of the post-write chain (SyntaxCheck → RunUnitTests → GetCodeCoverage → RunATCCheck)
• Before the transport release gate - verification by test-runner during the Phase 4 QA pass, and pre-release confirmation by devops-admin alongside docs/transport-release-checklist.md
• After receiving foreign code - legacy imports, repair imports, or code copied from other systems that never passed this variant's gates
• Not for non-ABAP artifacts - general-purpose code review stays with the co-develop code-review skill

Review Dimensions

Walk exactly three dimensions. Each cites the checklist sections that define it.

Dimension	Checklist sections	What is checked
(a) Naming	§1	snake_case, no type/Hungarian encoding, plural collections, nouns for classes and verbs for methods, no noise words, consistent terms
(b) Pretty-printer & formatting	§10	ABAP Formatter run before activation, one statement per line, line length, blank-line and bracket placement conventions, alignment and indentation
(c) Anti-patterns	§2, §4, §6, §7, §8	Obsolete language elements (§2), table and string anti-patterns such as DEFAULT KEY (§4), control-flow anti-patterns such as empty IF branches (§6), class/method anti-patterns such as CHECK in the method body or mixed export mechanisms (§7), error-handling anti-patterns such as non-class-based exceptions or silent failures (§8)

Execution Steps

1. Load the review standard - read docs/clean-abap-checklist.md before reviewing. Review against the checklist as written, never from memory.