review-architecture

Review Apache Pinot diffs for architectural concerns — module boundaries, SPI vs. impl separation, circular deps, misplaced logic (broker code in server, server code in controller), abstraction choice (interface vs. abstract class), plugin layering, and layering violations between pinot-spi / pinot-common / pinot-core / pinot-segment-spi / pinot-segment-local. Trigger keywords — new interface, abstract class, package move, module, SPI, broker-server boundary, plugin, shaded.

Jump to install

Repository: apache/pinot
Last source activity: May 12, 2026 at 17:15
Detected SKILL.md language: English
Stars: 6,128
Forks: 1,503

Install options

The review-first prompt is selected by default. You can switch to a direct command or download a local copy.

Install with Codex or Claude Copy this prompt, paste it into Codex, Claude, or another assistant, and let it review the skill page and install it for you.

A direct command skips the review prompt. Inspect the source before running it.

npx skills add https://github.com/apache/pinot --skill review-architecture

The command stays on one line. Scroll horizontally to inspect it before copying.

Prefer a local copy? Download the files currently available to SkillsMP.

Review the source files

Read SKILL.md and any companion files shown by SkillsMP before deciding whether to install.

SKILL.md

Source instructions · Read-only preview

Back to search Back to installation

bench-compare

Run a Pinot JMH benchmark twice — once on a baseline commit, once with the current changes — and report both sets of results side by side. Uses a git worktree so the user's working tree is never disturbed.

2026-05-12

flaky-analyze

Pull recent GitHub Actions failures for a Pinot test class and analyze whether they share a root cause. Uses the gh CLI. Surfaces stack traces, failure patterns, and a candidate hypothesis — does not auto-fix.

2026-05-12

precommit

Run Pinot's mandatory pre-commit checks (spotless, license, checkstyle) and compiler warning checks on only the modules affected by the current diff. Auto-fixes what it can, reports what it can't.

2026-05-12

View all from this repository

name	review-architecture
description	Review Apache Pinot diffs for architectural concerns — module boundaries, SPI vs. impl separation, circular deps, misplaced logic (broker code in server, server code in controller), abstraction choice (interface vs. abstract class), plugin layering, and layering violations between pinot-spi / pinot-common / pinot-core / pinot-segment-spi / pinot-segment-local. Trigger keywords — new interface, abstract class, package move, module, SPI, broker-server boundary, plugin, shaded.
domain	kb/code-review-principles.md#3-code-architecture--module-design
triggers	["diff adds/moves classes across module boundaries","diff introduces a new SPI interface or abstract class","diff adds a new plugin directory under pinot-plugins/","diff introduces cross-module imports (broker → server internals, etc.)","diff touches module POM dependencies"]
license	Apache-2.0

Skill: review-architecture

Procedure: see kb/skills/review-architecture.md. Read it first, then follow it.

review-architecture

Source facts

Install options

Review the source files

More from this repository

More from this repository

Skill: review-architecture

Skill: review-architecture