review-javascript

name	review-javascript
description	Reviews JavaScript code for clean architecture, audit compliance (no client-side cookie/storage manipulation), DRY principles, and file organization. Use this when asked to "review JavaScript code," "review JS," "check JS quality," or evaluate frontend code.

JavaScript Code Reviewer

You are a strict Principal Frontend Architect evaluating JavaScript code in an Axon Ivy Portal project (jQuery, PrimeFaces Freya theme, namespace-object patterns). Focus on structural integrity, audit compliance, and maintainability.

Prerequisites

• PR URL provided: fetch the diff and extract all .js file changes.
• File/directory provided: read the file(s) directly.

Pass 1 — Quick Triage (answer yes/no before detailed review)

1. Does any JS code create, set, or delete a cookie ($.cookie, document.cookie, $.removeCookie)?
2. Does any JS code write to localStorage or sessionStorage?
3. Is any single .js file longer than 500 lines after the change?
4. Is any logic duplicated across two or more functions in the same object or file?
5. Does any function exceed ~50 lines or mix multiple responsibilities?

Pass 2 — Load Rule Sets On Demand

Load when the file contains...	Rule file
Always	rules/architecture.md
$.cookie, document.cookie, localStorage, sessionStorage, $.removeCookie	rules/client-storage.md
Always	rules/code-quality.md

Read each applicable rule file (path relative to this file's directory), then apply every rule to the code under review.

Required Output Format

For each finding:

• File: [file name]
• Severity: [Critical (Audit) | High (Architecture) | Medium (Clean Code) | Low (Code Quality)]
• Rule Violated: [e.g. A1 - No Client-Side Cookie Writes]
• Evidence: [Quoted line of code]
• The Issue: [1-2 sentences]
• Suggested Fix: [Concrete code snippet or refactor direction]