Skip to main content

java-refactoring-remove-parameter

Refactoring using Remove Parameter in Java Language

Source facts

Repository
boshi-xixixi/TraeSkill
Last source activity
May 12, 2026 at 13:57
Detected SKILL.md language
English
Stars
278
Forks
65

Install options

The review-first prompt is selected by default. You can switch to a direct command or download a local copy.

Review the source files

Read SKILL.md and any companion files shown by SkillsMP before deciding whether to install.

Showing SKILL.md

SKILL.md
Source instructions · Read-only preview
name
java-refactoring-remove-parameter
description
Refactoring using Remove Parameter in Java Language
# Refactoring Java Methods with Remove Parameter ## Role You are an expert in refactoring Java methods. Below are **2 examples** (with titles code before and code after refactoring) that represents **Remove Parameter**. ## Code Before Refactoring 1: ```java public Backend selectBackendForGroupCommit(long tableId, ConnectContext context, boolean isCloud) throws LoadException, DdlException { if (!Env.getCurrentEnv().isMaster()) { try { long backendId = new MasterOpExecutor(context) .getGroupCommitLoadBeId(tableId, context.getCloudCluster(), isCloud); return Env.getCurrentSystemInfo().getBackend(backendId); } catch (Exception e) { throw new LoadException(e.getMessage()); } } else { return Env.getCurrentSystemInfo() .getBackend(selectBackendForGroupCommitInternal(tableId, context.getCloudCluster(), isCloud)); } } ``` ## Code After Refactoring 1: ```java public Backend selectBackendForGroupCommit(long tableId, ConnectContext context) throws LoadException, DdlException { if (!Env.getCurrentEnv().isMaster()) { try { long backendId = new MasterOpExecutor(context) .getGroupCommitLoadBeId(tableId, context.getCloudCluster()); return Env.getCurrentSystemInfo().getBackend(backendId); } catch (Exception e) { throw new LoadException(e.getMessage()); } } else { return Env.getCurrentSystemInfo() .getBackend(selectBackendForGroupCommitInternal(tableId, context.getCloudCluster())); } } ``` ## Code Before Refactoring 2: ```java NodeImpl( long id, long firstRel, long firstProp ) { this( id, false ); } ``` ## Code After Refactoring 2: ```java NodeImpl( long id) { this( id, false ); } ``` ## Task Apply **Remove Parameter** to improve readability, testability, maintainability, reusability, modularity, cohesion, low coupling, and consistency. Always return a complete and compilable method (Java 17). Perform intermediate steps internally: - First, analyze each method and identify parameters that are unused or redundant (i.e., values that can be obtained from class fields, constants, or other method calls). - For each qualifying method, remove the unnecessary parameters from its definition and from all its internal calls. - Ensure that the method continues to function correctly after parameter removal. - Output only the refactored code inside a single ```java``` block. - Do not remove any functionality from the original method. - Include a one-line comment above each modified method indicating which parameter was removed and why. ## Code to be Refactored: Now, assess all methods with unused parameters and refactor them using **Remove Parameter**
View on GitHub