fboss-review

name	fboss-review
description	Comprehensive FBOSS code review with 11 parallel reviewers (5 generic + 6 FBOSS-specific). Covers reliability, engineering, code quality, silent failures, agent architecture, SAI/SDK, FSDB/thrift_cow, platform/config, testing, and cross-cutting design. Self-contained alternative to /review-diff for FBOSS diffs. Findings shown to user only, never auto-posted.
user-invocable	true

FBOSS Review

Overview

Multi-reviewer code review for FBOSS diffs. Subsumes general review (/review-diff functionality) plus FBOSS-specific domain expertise.

Scope

Currently fboss/ only. TODO: extend to configerator/source/neteng/fboss, neteng/netcastle, neteng/fboss.

IMPORTANT: No Auto-Posting

All findings are shown to the user only. Never post to Phabricator automatically.

Review Workflow

Step 1: Identify Changes

• Run sl status and sl diff to get changed files
• If user specifies a diff number, fetch diff details via mcp__plugin_meta_mux__get_phabricator_diff_details

Step 2: Determine Applicable FBOSS Reviewers

• Files in agent/, SwSwitch, HwSwitch -> Agent Reviewer (#6)
• Files in fsdb/, thrift_cow/ -> FSDB/thrift_cow Reviewer (#7)
• Files in platform/, config, sensor/fan -> Platform Reviewer (#8)