code-quality-excellence

# Code Quality Excellence Skill ## Purpose Maintain high code quality through automated static analysis, TypeScript strict mode, and quality gates for MCP server projects. ## When to Use - ✅ Before committing TypeScript code - ✅ In CI/CD pipeline quality checks - ✅ During code reviews - ✅ Regular quality audits ## TypeScript Strict Mode ```json { "compilerOptions": { "strict": true, "noImplicitAny": true, "strictNullChecks": true, "noUncheckedIndexedAccess": true, "noImplicitReturns": true, "noFallthroughCasesInSwitch": true, "exactOptionalPropertyTypes": true } } ``` ## ESLint Configuration ```javascript // eslint.config.js import tseslint from 'typescript-eslint'; export default tseslint.config( tseslint.configs.strictTypeChecked, { rules: { '@typescript-eslint/no-explicit-any': 'error', '@typescript-eslint/prefer-nullish-coalescing': 'error', '@typescript-eslint/strict-boolean-expressions': 'error', '@typescript-eslint/explicit-function-return-type': 'error', } } ); ``` ## Quality Gates | Metric | Threshold | |--------|-----------| | Test coverage | ≥80% lines, ≥70% branches | | Security coverage | ≥95% for security-critical code | | TypeScript errors | 0 | | ESLint errors | 0 | | Unused exports (Knip) | 0 | | License violations | 0 | ## Quality Commands ```bash npm run lint # ESLint check npx tsc --noEmit # Type checking npm run knip # Unused detection npm test # Unit tests npm run test:coverage # Coverage report npm run test:licenses # License compliance ``` ## ISMS Policy References **Core policies:** - [Secure Development Policy](https://github.com/Hack23/ISMS-PUBLIC/blob/main/Secure_Development_Policy.md) — **Primary**: Code-quality gates are mandatory SDLC controls; TypeScript strict + ESLint + tests + SAST - [Open Source Policy](https://github.com/Hack23/ISMS-PUBLIC/blob/main/Open_Source_Policy.md) — Licence compliance (allowlist), `npm run test:licenses`, SBOM - [Information Security Policy](https://github.com/Hack23/ISMS-PUBLIC/blob/main/Information_Security_Policy.md) — Quality as a risk-reduction control and transparency enabler **Supporting policies:** - [Change Management](https://github.com/Hack23/ISMS-PUBLIC/blob/main/Change_Management.md) — Gates run on every PR before merge - [Vulnerability Management](https://github.com/Hack23/ISMS-PUBLIC/blob/main/Vulnerability_Management.md) — Lint / CodeQL findings triaged with CVSS where applicable - [AI Policy](https://github.com/Hack23/ISMS-PUBLIC/blob/main/AI_Policy.md) — AI-generated code must pass the same quality gates as human code