code-quality

name

code-quality

description

Use when writing, reviewing, or refactoring QuantConnect/LEAN algorithm code for style correctness. Triggers: new algorithm code, code review, cleanup, "fix code style", "review code quality", "clean up the algorithm", redundant imports, subscription variable usage, comment format, blank-line rules, multi-line boolean layout, or catch-all error handling. Skip when only debugging runtime behavior or performance, unless the fix also changes style.

QuantConnect Algorithm Code Quality

Apply these rules to pymain.pycsMain.cs and custom data classes. The goal is compiling code that does not hide real failures.

Imports

Use AlgorithmImports for LEAN APIs and common algorithm types. Do not add redundant imports for datetime, timedelta, date, pandas, numpy, or math. Put required standard library imports before AlgorithmImports, separated by one blank line. Preserve template using statements. Add or remove them only when a compile error proves one is needed.

Subscription Variables

Store the Security returned by add_data, add_equity, or add_crypto. Pass that Security directly anywhere a Symbol is expected; do not store or use .symbol. Store the Symbol returned by AddData(...).Symbol or AddEquity(...).Symbol. Pass the Symbol directly.

# Bad
self._custom_symbol = self.add_data(MyData, "TICKER").symbol
data[self._custom_btc.symbol]
# Good
self._custom_btc = self.add_data(MyData, "TICKER")
if self._custom_btc not in data:
    return
bar = data[self._custom_btc]

// Bad
private Security _customBtc;
// Good
private Symbol _customSymbol;
_customSymbol = AddData<MyData>("TICKER", Resolution.Daily).Symbol;

Use x in data and x not in data, not data.contains_key(x). Use Slice.ContainsKey(symbol) or slice.Get(symbol) consistently with the stored Symbol.

Comments

Follow PEP 8: block comments start with # , use complete sentences, start sentences with capitals, and end sentences with periods. Inline comments are rare, separated from code by at least two spaces, and start with # . Use comments to clarify intent, not restate code. Full-line comments start with // plus a space, use sentence form, and start with a capital letter.

# Bad
# add equity
x = price*quantity #calculate value
# Good
# Add the equity subscription.
x = price * quantity  # Calculate the order value.

// Bad
// schedule the monthly insight
var x = 1; //calculate price
// Good
// Schedule a monthly insight event.
var x = 1; // Calculate the weighted price.

Multi-Line Boolean Expressions

Put and/or at the end of each continued line. Put && or || at the beginning of each continued line.

# Bad
if (
    close > ema_fast
    and open_ > ema_fast
    and rsi > 50):
    return
# Good
if (close > ema_fast and
    open_ > ema_fast and
    rsi > 50):
    return

Blank Lines

Use two blank lines before top-level classes, one blank line before methods inside classes, and no blank lines inside method bodies. Use one blank line between methods, no blank lines inside method bodies, and standard C# brace style.

Error Handling

Do not wrap algorithm logic in pytry / exceptcstry / catch blocks. Exceptions reveal invalid state, missing data, and incorrect assumptions; catch-all handlers make bugs invisible.

# Bad
try:
    self.set_holdings(self._spy, target_weight)
except Exception:
    pass
# Good
if target_weight:
    self.set_holdings(self._spy, target_weight)

// Bad
try
{
    SetHoldings(_spy, targetWeight);
}
catch
{
}
// Good
if (targetWeight != 0)
{
    SetHoldings(_spy, targetWeight);
}

Checklist

1. Standard library imports precede AlgorithmImports.

2. Stored subscription variables are Security objects, not .symbol values.

1. Template using statements are preserved.

2. Stored subscription variables are Symbol values.

3. Comments follow language-specific rules.
4. Multi-line boolean expressions follow language-specific continuation style.
5. Blank lines match language rules.
6. Algorithm code has no pytry / exceptcstry / catch; it uses explicit guards for expected conditions.