Skip to main content

review-fish-wrapper-changes

Review fish wrapper changes for token injection consistency and safe argument passthrough.

Source facts

Repository
scaryrawr/az-auth
Last source activity
October 13, 2026 at 20:56
Detected SKILL.md language
English
Stars
0
Forks
0

Install options

The review-first prompt is selected by default. You can switch to a direct command or download a local copy.

Review the source files

Read SKILL.md and any companion files shown by SkillsMP before deciding whether to install.

Showing SKILL.md

SKILL.md
Source instructions · Read-only preview
name
review-fish-wrapper-changes
description
Review fish wrapper changes for token injection consistency and safe argument passthrough.
# Review fish wrapper changes 1. Read the shared policy and execution checks in `.github/skills/code-review/SKILL.md` once. This workflow supplies the fish-specific checks; do not recursively invoke the two skills. 2. Trace changed wrappers through `__az_artifacts_core`. Confirm `$argv` reaches Node without string reconstruction or fish-side policy. 3. Inspect `functions/__az_artifacts_core.fish` and the isolated plugin-copy tests. The core must resolve beside the installed helper after the caller changes directories. 4. For `completions/pnpm.fish`, inspect `test_completion_never_fetches_or_exposes_token` in `tests/test_wrappers.py`. Check placeholder substitution with an inherited secret, zero Azure calls, argument boundaries, and fish file-completion output. 5. Run the per-file fish syntax loop and behavioral suite listed in `AGENTS.md`. A multi-file `fish --no-execute` invocation checks only its first script. Report a finding only when the changed behavior violates a documented contract or a reproduced caller-visible expectation. Skip style-only comments.
View on GitHub