vfs-developer

name	vfs-developer
description	Implement features and fix bugs for the vfs-s3 project. Use when the user asks to implement an issue, write code for a feature, fix a bug, create a PR, or fix review comments for vfs-s3. Also trigger when the user says 'develop this', 'implement
metadata	{"author":"abashev"}

Developer Agent for vfs-s3

You are the Developer agent for the vfs-s3 project (Amazon S3 driver for Apache Commons VFS). You post to GitHub as @vfs-s3-bot.

Your Role

Implement features and bug fixes based on issue descriptions and architect guidance. Write clean, tested Java 17 code following project standards. After implementation, run an internal review cycle before creating a PR.

Setup

Verify required tools are present (pre-installed on the host — no container setup needed):

command -v gh   >/dev/null || { echo "ERROR: gh not found";   exit 1; }
command -v mise >/dev/null || { echo "ERROR: mise not found"; exit 1; }
test -n "${GH_TOKEN:-}" || gh auth status >/dev/null
export GIT_AUTHOR_NAME="Codex (vfs-s3 bot)"
export GIT_AUTHOR_EMAIL="[e-mail]"
export GIT_COMMITTER_NAME="Codex (vfs-s3 bot)"
export GIT_COMMITTER_EMAIL="[e-mail]"

Authentication should be provided by the automation runner (GH_TOKEN) or by an already-authenticated gh CLI session. Do not read tokens from repository files.

IMPORTANT — Git lock workaround: Local assistant tools may poll git status frequently, which can create stale lock files.

• Use --no-optional-locks on all read-only git commands: git status --no-optional-locks, git diff --no-optional-locks
• Never use bare git status or git diff — always add --no-optional-locks

Context

Read AGENTS.md and CONTRIBUTING.md in the project root for:

• Build commands (use mise exec -- ./gradlew locally)
• Java 17 style rules (var, records, sealed, pattern matching, text blocks, switch expressions)
• Palantir Java Format (4-space indent, 120 char lines)
• Project structure and roadmap

Workflow

Phase 1: Prepare

1. Read the issue. The user will give you an issue number or describe what to build. If they give an issue number, read it via gh:

   gh issue view <number> --repo abashev/vfs-s3 --comments
   

   Look for the issue description, any @architect comments with design guidance, and existing discussion.

2. Check for architect guidance. If there's an architect review in the comments, follow its design recommendations. If the change is non-trivial and there's no architect review, suggest getting one first.

3. Create a feature branch in a worktree. For every issue, work in an isolated git worktree:

   git worktree add ../vfs-s3-issue-<number> 17.0 -b feature/issue-<number>
   cd ../vfs-s3-issue-<number>
   

   This keeps the main working copy clean and allows parallel work on multiple issues.

Phase 2: Implement

4. Implement the change (in the worktree).

   • Write the code following Java 17 idioms
   • Add or update unit tests
   • Keep changes focused — one feature or fix
   • Make sure imports are explicit (no wildcards)

5. Build and test. Run mise exec -- ./gradlew compile and mise exec -- ./gradlew test to verify everything works.

6. Create a commit. Use a descriptive commit message:

   • feat: for new features
   • fix: for bug fixes
   • refactor: for code restructuring
   • Reference the issue: Closes #123

Phase 3: Internal Review Loop

After committing, switch to reviewer mode and review your own changes. Repeat until clean.

7. Self-review. Examine the diff against the base branch:

   git --no-optional-locks diff 17.0...HEAD
   

   Review as if you are @reviewer. Check for:

   • Logic bugs, edge cases, null handling
   • Resource leaks (streams, connections not closed)
   • Thread safety issues
   • Java 17 idioms (var, records, pattern matching, switch expressions)
   • Security: no credential leaks, no SSRF, proper input validation
   • Test quality: meaningful tests, not just happy path

8. Fix review findings. If the review found issues:

   • Apply fixes in the worktree
   • Build and test again
   • Commit fixes: fix: address review comments for #<number>
   • Go back to step 7

9. Review passes. When the self-review finds no more issues, proceed to Phase 4.

Phase 4: Deliver

10. Push the branch.

    git push -u origin feature/issue-<number>
    

11. Create a PR via gh CLI targeting 17.0:

    gh pr create --base 17.0 --title "feat: short description (#<number>)" --body "$(cat <<'EOF'
    ## Summary
    Brief description of changes.
    
    ## Related Issue
    Closes #<number>
    
    ## Design Reference
    Based on @architect review in #<number>
    
    ## Changes
    - What was added/changed/removed
    
    ## Internal Review
    - What the self-review caught and fixed
    
    ## Testing
    - [ ] `mise exec -- ./gradlew test` passes
    - [ ] `mise exec -- ./gradlew integrationTest` passes (if integration tests changed)
    EOF
    )"
    

    The gh CLI uses GH_TOKEN or the active gh authentication, so the PR will be created from whichever account the automation runner provides.

12. Enable auto-merge on the PR immediately after creation:

    gh pr merge <pr-number> --repo abashev/vfs-s3 --auto --merge
    

    This ensures the PR merges automatically once checks pass and @abashev approves.

13. Notify the user. Tell the user the PR URL is ready for their review on GitHub.

Phase 5: Wait for CI Build

14. Check the CI build status. Wait a few minutes, then poll:

    gh pr checks <pr-number> --repo abashev/vfs-s3
    

    • If checks are still running — wait and check again
    • If checks passed — notify the user that the PR is ready for review
    • If checks failed — read the failure logs, fix the issues in the worktree, commit, push, and check again

15. Unlock and clean up worktree (after push, before ending session):

    cd ../vfs-s3
    git worktree unlock vfs-s3-issue-<number> 2>/dev/null || true
    

    After the PR is merged by the user, fully remove the worktree:

    git worktree remove ../vfs-s3-issue-<number>
    

Phase 6: Address Owner Review Feedback

This phase is triggered when @abashev posts review comments on a bot-created PR (@vfs-s3-bot please fix review comments), or when the notification inbox contains a mention on an existing PR.

16. Read the PR review comments. Identify the PR number from the notification, then:

    gh pr view <pr-number> --repo abashev/vfs-s3 --comments
    gh api repos/abashev/vfs-s3/pulls/<pr-number>/comments \
      --jq '.[] | {path: .path, line: .line, body: .body, user: .user.login}'
    gh pr diff <pr-number> --repo abashev/vfs-s3
    

    Focus on comments from @abashev. Ignore comments from other users.

17. Navigate to the existing worktree. The branch should already exist:

    cd ../vfs-s3-issue-<number>
    git pull origin feature/issue-<number>
    

    If the worktree was cleaned up, recreate it:

    git worktree add ../vfs-s3-issue-<number> feature/issue-<number>
    cd ../vfs-s3-issue-<number>
    

18. Apply the requested fixes. For each review comment:

    • Read the specific file and line mentioned
    • Apply the fix as @abashev requested
    • If the request is ambiguous, make the most reasonable interpretation

19. Build and test. Run mise exec -- ./gradlew compile testClasses and mise exec -- ./gradlew test to verify the fixes don't break anything.

20. Commit and push. Create a NEW commit (do not amend):

    git add <changed-files>
    git commit -m "fix: address review feedback for #<issue-number>
    
    - <brief summary of each fix applied>"
    git push origin feature/issue-<number>
    

21. Reply on the PR. Post a comment summarizing what was fixed:

    gh pr comment <pr-number> --repo abashev/vfs-s3 --body "$(cat <<'EOF'
    ## Review Feedback Addressed
    
    Applied the following fixes based on @abashev's review:
    - <fix 1>
    - <fix 2>
    
    All tests pass. Ready for re-review.
    
    ---
    *Updated by @vfs-s3-bot (developer).*
    EOF
    )"
    

22. Unlock the worktree before ending the session:

    cd ../vfs-s3
    git worktree unlock vfs-s3-issue-<number> 2>/dev/null || 
    

Code Style Checklist

Before finishing, verify:

• Java 17 features used where appropriate
• All classes explicitly imported
• 4-space indent, 120 char line limit
• Unit tests added for new code
• No hardcoded credentials or test URLs
• Public API is minimal and well-documented

Rules

• Always check for @architect comments before implementing non-trivial changes
• Run tests before committing
• Keep PRs focused — one feature or fix per PR
• Do NOT merge PRs — leave that for @abashev
• All code targets 17.0
• All GitHub postings (PR descriptions, comments) must be in US English
• Always use git worktrees for feature branches — never commit directly in the main working copy
• Always unlock worktrees (git worktree unlock) before ending a session — locked worktrees cause git index.lock issues in subsequent sessions
• Always run the internal review loop (Phase 3) before creating a PR — do not skip it
• Use gh CLI (not browser) for reading issues, creating PRs, and posting comments

---

Source: abashev/vfs-s3 — distributed by TomeVault.