commit

name	commit
description	Create conventional commits with quality gates and validation
allowed-tools	Bash(git add*), Bash(git commit*), Bash(git diff*), Bash(git status*), Bash(.claude/skills/shared/discover-verification-cmd.sh*), Read

/commit — Quality-Gated Conventional Commits

Create conventional commits with automatic validation and quality gates.

PURPOSE

Commit changes reliably with validation checks and consistent messaging.

CRITICAL

• Never commit secrets — Run git diff --cached before committing. No hardcoded API keys, passwords, credentials, or tokens.
• Always validate before committing — Project verification command must pass. No commits that break tests or linting.
• Message must follow conventional format — type(scope): description. Malformed messages create merge and CI problems downstream.
• Stage specific files — Never use git add -A or git add . blindly. Review git status and stage intentionally.

ASSUMES

• You're in a git repository with a verification command available
• You can identify which files should be committed (no accidental includes)
• You know the type of change: feat, fix, refactor, docs, chore, test

STANDARD PATH

1. Stage Changes

Review and stage files intentionally:

git status                          # See what changed
git add <file1> <file2> ...         # Stage specific files
git diff --cached                   # Review staged changes

Never: git add -A or git add . — stage intentionally.

2. Run Project Validation

Discover and run the verification command:

cmd=$(.claude/skills/shared/discover-verification-cmd.sh)
eval "$cmd"

ALL checks must pass. No commits that break validation.

3. Write Commit Message

Format: type(scope): description

Example:

feat(auth): add OAuth2 login flow

See DETAIL: Message Format for all types and examples.

4. Create Commit

git commit -m "type(scope): description

Optional detailed explanation here.
Mention related issues: #123, closes #456."

For complex messages, use HEREDOC:

git commit -m "$(cat <<'EOF'
feat(scope): brief description

- Detailed explanation line 1
- Detailed explanation line 2

Closes #NNN
EOF
)"

EDGE CASES

• [Complex commit messages] — Read DETAIL: Message Format (when to use HEREDOC, multi-line bodies)
• [Large changes spanning files] — Read DETAIL: Staging Multiple Files (review each category before committing)
• [Partial file commits] — Read DETAIL: Staging Hunks (commit part of a file)
• [Fixing mistakes] — Read DETAIL: Fixing Commit Mistakes (amend, reset, rebase)

---

DETAIL: Message Format

Conventional Commit Types

Type	Use Case	Example
feat	New feature or capability	feat(auth): add two-factor authentication
fix	Bug fix	fix(api): handle null responses from upstream
refactor	Code restructuring (no behavior change)	refactor: extract validation into utility
docs	Documentation updates	docs: clarify API rate limits in README
chore	Maintenance, dependencies, build	chore: upgrade prettier to latest
test	Test additions or fixes	test: add edge case coverage for date parsing
style	Formatting, missing semicolons (rarely used)	N/A
perf	Performance improvements (rarely used)	perf: use memoization for expensive calculation

Scope

Optional, indicates area of change:

• Use project naming conventions: auth, api, ui, database, etc.
• Omit for project-wide changes
• Examples: feat(keyboard): add macro support, fix: resolve memory leak

Description

• Imperative mood: "add feature" not "added feature" or "adds feature"
• No period at end
• ≤50 characters (aim for ~30)
• Specific: "add password reset flow" not "fix auth stuff"

Body (Optional)

• Explain why, not what (code shows the what)
• Wrap at 72 characters
• Separated from subject by blank line
• Link to issues: Closes #NNN, Fixes #NNN, Relates to #MMM

Example: Good Commit

feat(keyboard): add macro recording and playback

Users can now record key sequences and replay them with a hotkey.
This addresses frequent requests for repetitive key patterns.

Macro storage uses ~/.config/daskeyboard/macros.json for
persistence across sessions.

Testing: Added 12 test cases covering:
- Basic record/playback
- Edge cases (empty macros, special keys)
- Storage persistence

Closes #234

Example: Bad Commit

fix stuff                           ← Too vague
feat: add oauth                     ← Missing scope, too brief
docs: update                        ← What did you update?
refactor(everything): big cleanup   ← Scope "everything" is suspicious

---

DETAIL: Staging Multiple Files

When committing changes across many files:

Review by Category

git status | grep -E "modified|new"     # See all changes
git diff --stat                         # Summary by file

# Stage by category
git add programs/zsh.nix programs/vim.nix   # Shell config
git add docs/*.md                           # Documentation
git diff --cached                           # Review staged
git commit -m "..."

Don't Mix Unrelated Changes

Each commit should be coherent:

❌ Bad: Single commit with shell config, docs, and bug fix ✅ Good: Three separate commits, one for each type of change

This makes history clearer and simplifies reverting if needed.

---

DETAIL: Staging Hunks

Commit part of a file (not all changes):

git add --patch <file>              # Interactive hunk selection
# Review each hunk, stage with 'y', skip with 'n'

git diff --cached                   # Review staged hunks
git commit -m "feat: related change"

Use when:

• Multiple unrelated changes in one file
• You want to split into multiple commits
• You want to exclude debugging code you accidentally added

---

DETAIL: Fixing Commit Mistakes

Undo Last Commit (Keep Changes)

git reset --soft HEAD~1             # Undo commit, keep staged
git reset HEAD                       # Unstage all
# Now fix and re-commit

Amend Last Commit (Not Yet Pushed)

git add <fixed-files>
git commit --amend                  # Amend with new changes
# Or: git commit --amend --no-edit   (keep message)

Never amend commits already pushed. Use a new commit instead.

Reset to Before Last Commit

git reset --hard HEAD~1             # Discard all changes in last commit

Use with caution — this is destructive.

---

RELATED

• /review-pr — Review pull requests
• /open-pr — Open PR with validation
• /rollback — Recover from failed changes
• Conventional Commits Spec