| name | code-review |
| description | Apply when preparing a PR, reviewing code changes, running git diff, or generating a changeset. Use when user says "review", "PR prep", "code review", or "changeset". |
PR Workflow & Code Review
Git & PR Workflow
| Requirement | Details |
|---|
| No force-push after review | GitHub loses review history; use merge commits instead |
| Changelog required | Run pnpm changelog before merge |
| Conventional commits | PR title must follow conventional commit format |
| Separate concerns | Unrelated changes go in separate PRs; easier revert and isolation |
| Changeset messages are user-facing | Write "Add X to Y" or "Fix X in Y", not implementation details |
skip changelog label | Use only for non-user-facing changes (CI, tests, docs); never for bug fixes |
Use --frozen-lockfile | Run pnpm install --frozen-lockfile to avoid unnecessary lockfile changes |
| Deprecation rules | Add to @drivenets/eslint-plugin-design-system when deprecating |
<!-- Good changeset message -->
Add DsCard component
<!-- Bad changeset message - implementation details -->
Refactor card to use CSS modules and fix hover state selector specificity
Code Review Process
- Get diff:
git diff origin/main
- Review every changed file — read the matching skill(s) fully for paths in the diff:
- Flag only clear, high-severity issues (max 10 inline comments)
Inline comment format
- One issue per comment; place on the exact changed line
- Natural tone, specific and actionable; do not mention automated or high-confidence
- Severity: 🚨 Critical 🔒 Security ⚡ Performance ⚠️ Logic ✨ Improvement
PR Checklist
Before submitting a PR:
